Skip to content

Commit 363a917

Browse files
dabrtadriendupuis
andauthored
Apply suggestions from code review
Co-authored-by: Adrien Dupuis <[email protected]>
1 parent af1c0ae commit 363a917

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

docs/content_management/images/add_image_asset_from_dam.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ Then, in `config\services.yaml`, register the handler as a service:
110110

111111
### Create transformation factory
112112

113-
The transformation factory transforms image variations coming from Wikimedia Commons to the ones used by [= product_name =].
113+
The transformation factory transforms image variations coming from Wikimedia Commons to the ones used by [[= product_name =]].
114114

115115
In `src\Connector\Dam\Transformation` folder, create the `WikimediaCommonsTransformationFactory.php` file that resembles the following example:
116116

@@ -134,7 +134,7 @@ For example, the handler generates the following URL with `new AssetUri()`:
134134

135135
`https://commons.wikimedia.org/w/index.php?title=Special:Redirect/file/Ibexa_Logo.svg`
136136

137-
When the user requests a specific variation of the image, the variation generator modifies the URL and returns it in the following form:
137+
When the user requests a specific variation of the image, for example, "large", the variation generator modifies the URL and returns it in the following form:
138138

139139
`https://commons.wikimedia.org/w/index.php?title=Special:Redirect/file/Ibexa_Logo.svg&width=300`
140140

@@ -146,7 +146,7 @@ For this to happen, register the variations generator as a service:
146146

147147
### Create Twig template for Admin UI
148148

149-
The template deffines how images that come from Wikimedia Commons appear in the back office.
149+
The template defines how images that come from Wikimedia Commons appear in the back office.
150150

151151
In `templates/bundles/WikimediaCommonsConnector/`, add the `commons_asset_view.html.twig` file that resembles the following example:
152152

@@ -160,6 +160,10 @@ Then, register the template in configuration files:
160160
[[= include_file('code_samples/back_office/images/config/packages/views.yaml') =]]
161161
```
162162

163+
!!! caution
164+
165+
As it overrides the parameter, make sure that you define the default template, too.
166+
163167
### Add Wikimedia Commons connection to DAM configuration
164168

165169
You can now configure a connection with Wikimedia Commons under the `ibexa.system.<scope>.content.dam` key:

0 commit comments

Comments
 (0)