Skip to content

Commit 57a8174

Browse files
adriendupuismnocon
andauthored
Apply suggestions from code review
Co-authored-by: Marek Nocoń <[email protected]>
1 parent a30b86a commit 57a8174

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

docs/update_and_migration/from_4.6/update_to_5.0.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ It's important to stop using deprecated PHP classes as they're removed in 5.0.
2929

3030
The [`ibexa/compatibility-layer`](to_4.0.md#add-compatibility-layer-package) isn't supported in 5.0.
3131
If you use it, remove it (`composer remove ibexa/compatibility-layer`) and make the necessary changes.
32-
See [Ibexa DXP v4.0 deprecations and backwards compatibility breaks](ibexa_dxp_v4.0_deprecations.md) for some of the changes it was avoiding.
32+
See [Ibexa DXP v4.0 deprecations and backwards compatibility breaks](ibexa_dxp_v4.0_deprecations.md) for the list of changes.
3333

3434
[Rector](https://getrector.com/) and the [[= product_name_base =]] rule sets help to upgrade your code.
3535

@@ -105,7 +105,7 @@ rm -r config/graphql
105105
#### Update package requirements
106106

107107
[[= product_name =]] 5.0 is based on Symfony 7.3 and both must be updated.
108-
Your development package must be updated as well.
108+
Your development packages must be updated as well.
109109
The example below assumes that [`symfony/debug-pack`](https://symfony.com/packages/Debug%20Pack) and `ibexa/rector` are installed.
110110
Adjust the list based on your project requirements.
111111
Notice the use of the `--no-update` option to only edit the `composer.json` entries and avoid triggering the package update and Composer scripts.
@@ -231,7 +231,7 @@ rm assets/bootstrap.js
231231
composer recipes:install symfony/webpack-encore-bundle --reset --force --yes
232232
```
233233

234-
Compare with your previous version, and merge and test customization if needed.
234+
Compare with your previous version, merge them together and test your customizations if needed.
235235

236236
#### Apply [[= product_name =]] recipe
237237

@@ -865,7 +865,7 @@ You can find an [`ibexa-rename-icons` map in `vendor/ibexa/rector/js/rules.confi
865865
866866
The following example illustrates the update of a custom page block's icon:
867867
868-
```diff+yaml
868+
```diff
869869
ibexa_fieldtype_page:
870870
blocks:
871871
event:
@@ -881,7 +881,7 @@ Features which were optional 4.6 LTS Updates are now part of 5.0.0.
881881
882882
* If you have already installed the feature, its schema has been updated by the previous step.
883883
* If you haven't installed the feature, you need to add its schema to your database.
884-
Store the SQL of the schema into a file, review it, then run it.
884+
Store the SQL of the schema into a file, **review it carefully**, then run it.
885885
* If you mistakenly reinstall a schema, you might encounter "Table already exists" errors which can be ignored.
886886
887887
#### Install AI actions schema
@@ -890,7 +890,7 @@ Features which were optional 4.6 LTS Updates are now part of 5.0.0.
890890
891891
```bash
892892
php bin/console ibexa:doctrine:schema:dump-sql vendor/ibexa/connector-ai/src/bundle/Resources/config/schema.yaml > schema_connector-ai.sql
893-
# schema_connector-ai.sql review
893+
# Pause to review schema_connector-ai.sql
894894
mysql -u <username> -p <password> <database_name> < schema_connector-ai.sql
895895
```
896896

@@ -1031,7 +1031,7 @@ Ensure your search index is up to date with the following command:
10311031
php bin/console ibexa:reindex
10321032
```
10331033

1034-
### Finalising
1034+
### Finalizing
10351035

10361036
#### Clear cache and rebuild
10371037

docs/update_and_migration/update_ibexa_dxp.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ To update [[= product_name =]] to a newer version, select the version you're cur
3232
=== "I am using v4.x"
3333

3434
- If you have a v4.x installation prior to v4.6, [update to the v4.6 LTS](from_4.5/update_from_4.5.md).
35-
- If you have a v4.6 installation, (update to the latest patch v[[= latest_tag_4_6 =]])(from_4.6/update_from_4.6.md).
35+
- If you have a v4.6 installation, [update to the latest patch v[[= latest_tag_4_6 =]]](from_4.6/update_from_4.6.md).
3636

3737
Afterwards, it's strongly recommended to also [update to the lastest v5.0 LTS](from_4.6/update_to_5.0.md).
3838

0 commit comments

Comments
 (0)