test:type:usage: handle arrays of objects

Author: adriendupuis

tools/raml2html/src/Command/TestTypeUsageCommand.php

@@ -7,6 +7,7 @@
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
 
 final class TestTypeUsageCommand extends Command
 {
@@ -42,6 +43,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         foreach ($usedByRouteTypeList as $usedByRouteType) {
             $definedType = $this->definedTypes[$usedByRouteType];
+            if (!array_key_exists('type', $definedType)) {
+                //TODO: warning
+                dump($definedType);
+            }
             $usedType = str_ends_with($definedType['type'], '[]') ? substr($definedType['type'], 0, -2) : $definedType['type'];
             if (!in_array($usedType, $this->usedByOtherTypeTypeList)) {
                 $this->usedByOtherTypeTypeList[] = $usedType;
@@ -52,7 +57,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $usedTypeList = array_merge($usedByRouteTypeList, $this->usedByOtherTypeTypeList);
         $unusedTypeList = array_values(array_diff(array_keys($this->definedTypes), $usedTypeList));
         sort($unusedTypeList);
-        dump($unusedTypeList);
+
+        if (!empty($unusedTypeList)) {
+            $style = new SymfonyStyle($input, $output);
+            $style->title('Unused types');
+            $style->listing($unusedTypeList);
+            return Command::FAILURE;
+        }
 
         return Command::SUCCESS;
     }
@@ -65,9 +76,13 @@ private function exploreProperties(array $definedType)
                 if (is_array($propertyDefinition)) {
                     if (array_key_exists('type', $propertyDefinition)) {
                         if ('array' === $propertyDefinition['type']) {
-                            $usedType = $propertyDefinition['items'];
+                            if (is_array($propertyDefinition['items']) && array_key_exists('properties', $propertyDefinition['items'])) {
+                                $this->exploreProperties($propertyDefinition['items']);
+                            } else {
+                                $usedType = $propertyDefinition['items'];
+                            }
                         } elseif (array_key_exists('properties', $propertyDefinition)) {
-                            $this->exploreProperties($propertyDefinition, $this->usedByOtherTypeTypeList);
+                            $this->exploreProperties($propertyDefinition);
                         } elseif (str_ends_with($propertyDefinition['type'], '[]')) {
                             $usedType = substr($propertyDefinition['type'], 0, -2);
                         } else {
@@ -82,8 +97,16 @@ private function exploreProperties(array $definedType)
                     }
                 }
                 if (null !== $usedType && !in_array($usedType, $this->usedByOtherTypeTypeList)) {
+                    if (!is_string($usedType)) {
+                        //TODO: warning
+                        dump($propertyDefinition, $usedType);
+                    }
                     $this->usedByOtherTypeTypeList[] = $usedType;
                     if (array_key_exists($usedType, $this->definedTypes)) {
+                        if (!is_array($this->definedTypes[$usedType])) {
+                            //TODO: warning
+                            dump($usedType, $this->definedTypes[$usedType]);
+                        }
                         $this->exploreProperties($this->definedTypes[$usedType]);
                     }
                 }