Apply suggestions from code review

Co-authored-by: Adrien Dupuis <[email protected]>

Author: mnocon

docs/content_management/data_migration/importing_data.md

@@ -522,7 +522,7 @@ The provided conditions overwrite any already existing ones.
 [[= include_file('code_samples/data_migration/examples/discounts/discount_update.yaml') =]]
 ```
 
-For a list of available conditions, see [Discounts API](discounts_api.md).
+For a list of available conditions, see [Discounts API](discounts_api.md#conditions).
 
 ## Criteria
 

docs/discounts/discounts_api.md

@@ -14,15 +14,15 @@ By integrating with the [Discount feature](discounts_guide.md) you can automate
 
 For example, you can automatically create a discount when a customer places their 3rd order, encouraging them to make another purchase and increase their chances of becoming a local customer.
 
-You can manage discounts using [data migrations](importing_data.md#discounts), [REST API](/api/rest_api/rest_api_reference/rest_api_reference.html#discounts), or the PHP API by using the [Ibexa\Contracts\Discounts\DiscountServiceInterface](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Discounts-DiscountServiceInterface.html) service.
+You can manage discounts using [data migrations](importing_data.md#discounts), [REST API](/api/rest_api/rest_api_reference/rest_api_reference.html#discounts), or the PHP API by using the [`Ibexa\Contracts\Discounts\DiscountServiceInterface`](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Discounts-DiscountServiceInterface.html) service.
 
 The core concepts when working with discounts through the APIs are listed below.
 
 ### Types
 
 When using the PHP API, the discount type defines where the discount can be applied.
 
-Discounts are applied in two places, listed in the [DiscountType](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Discounts-Value-DiscountType.html) class:
+Discounts are applied in two places, listed in the [`DiscountType`](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Discounts-Value-DiscountType.html) class:
 
 - **Product catalog** - `catalog` discounts are activated when browsing the product catalog and do not require any action from the customer to be activated
 - **Cart** - `cart` discounts can activate when entering the [cart](cart.md), if the right conditions are met. They may also require entering a discount code to be activated
@@ -31,7 +31,7 @@ Regardless of activation place, discounts always apply to products and reduce th
 
 To define when a discount activates and how the price is reduced, use rules and conditions.
 They make use of the [Symfony Expression language]([[= symfony_doc=]]//components/expression_language.html).
-Use the expression values provided below when using data migrations or the REST API to pass the right values.
+Use the expression values provided below when using data migrations or when parsing REST API responses.
 
 ### Rules
 
@@ -40,8 +40,8 @@ The following discount rule types are available:
 
 | Rule type | Identifier | Description | Expression value |
 |---|---|---|---|
-| `Ibexa\Discounts\Value\DiscountRule\FixedAmount` | `fixed_amount` | Deducts the specified amount, for example 10 EUR, from the base price | `discount_amount` |
-| `Ibexa\Discounts\Value\DiscountRule\Percentage` | `percentage` | Deducts the specified percentage, for example -10%, from the base price | `discount_percentage` |
+| `Ibexa\Discounts\Value\DiscountRule\FixedAmount` | <nobr>`fixed_amount`</nobr> | Deducts the specified amount, for example <nobr>10 EUR</nobr>, from the base price | <nobr>`discount_amount`</nobr> |
+| `Ibexa\Discounts\Value\DiscountRule\Percentage` | <nobr>`percentage`</nobr> | Deducts the specified percentage, for example -10%, from the base price | <nobr>`discount_percentage`</nobr> |
 
 Only a single discount can be applied to a given product, and a discount can only have a single rule.
 
@@ -90,13 +90,13 @@ The discount has four properties that can be translated:
 | Promotion label | Information displayed to customers |
 | Promotion description | Information displayed to customers |
 
-Use the [DiscountTranslationStruct](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Discounts-Value-Struct-DiscountTranslationStruct.html) to provide translations for discounts.
+Use the [`DiscountTranslationStruct`](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Discounts-Value-Struct-DiscountTranslationStruct.html) to provide translations for discounts.
 
 ### Discount codes
 
 To activate a cart discount only after a proper discount code is provided, you need to:
 
-1. Create a discount code using the [DiscountCodeServiceInterface::createDiscountCode()](/api/php_api/php_api_reference/classes/Ibexa-Contracts-DiscountsCodes-DiscountCodeServiceInterface.html#method_createDiscountCode) method
+1. Create a discount code using the [`DiscountCodeServiceInterface::createDiscountCode()`](/api/php_api/php_api_reference/classes/Ibexa-Contracts-DiscountsCodes-DiscountCodeServiceInterface.html#method_createDiscountCode) method
 1. Attach it to a discount by using the `IsValidDiscountCode` condition
 
 Set the [`usedLimit`](/api/php_api/php_api_reference/classes/Ibexa-Contracts-DiscountsCodes-Value-Struct-DiscountCodeCreateStruct.html#method___construct) property to the number of times a single customer can use this code, or to `null` to make the usage unlimited.
@@ -107,12 +107,13 @@ The [`DiscountCodeServiceInterface::registerUsage()`](/api/php_api/php_api_refer
 
 The example below contains a Command creating a cart discount. The discount:
 
-- has the highest possible priority value
-- deducts 10 EUR from the base price of the product
-- is permanent
-- is valid in Germany and France
-- applies to 2 products
-- requires a `summer10` discount code to be activated. The code can be used unlimited number of times
+- has the highest possible [priority](#priority) value
+- [rule](#rules) deducts 10 EUR from the base price of the product
+- is [permanent](#start-and-end-date)
+- [depends](#conditions) on
+    - being bought from Germany or France
+    - 2 products
+    - a `summer10` [discount code](#discount-codes) which can be used unlimited number of times
 
 ``` php hl_lines="60-66 68-92"
 [[= include_file('code_samples/discounts/src/Command/ManageDiscountsCommand.php') =]]
@@ -122,7 +123,7 @@ Similarly, use the `deleteDiscount`, `deleteTranslation`, `disableDiscount`, `en
 
 ## Search
 
-You can search for Discounts using the [`DiscountServiceInterface::findDiscounts()](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Discounts-DiscountServiceInterface.html#method_findDiscounts) method.
+You can search for Discounts using the [`DiscountServiceInterface::findDiscounts()`](/api/php_api/php_api_reference/classes/Ibexa-Contracts-Discounts-DiscountServiceInterface.html#method_findDiscounts) method.
 To learn more about the available search options, see Discounts' [Search Criteria](discounts_criteria.md) and [Sort Clauses](discounts_sort_clauses.md).
 
 For discount codes, you can query the database for discount code usage using [`DiscountCodeServiceInterface::findCodeUsages()`](/api/php_api/php_api_reference/classes/Ibexa-Contracts-DiscountsCodes-DiscountCodeServiceInterface.html#method_findCodeUsages) and [`DiscountCodeUsageQuery`](/api/php_api/php_api_reference/classes/Ibexa-Contracts-DiscountsCodes-Value-Query-DiscountCodeUsageQuery.html).