ReferenceTester.php: inc. code readability

adriendupuis · adriendupuis · commit ad1a184a3e84 · 2024-09-19T14:45:26.000+02:00
diff --git a/tools/raml2html/src/Test/ReferenceTester.php b/tools/raml2html/src/Test/ReferenceTester.php
@@ -170,13 +170,14 @@ private function parseRouterOutput($consolePath)
                 continue;
             }
             $lineParts = preg_split('/\s+/', $outputLine);
-            $routeId = $lineParts[0];
-            $methods = explode('|', $lineParts[1]);
+            $routeProperties = array_combine(['Name', 'Method', 'Scheme', 'Host', 'Path'], $lineParts);
+            $routeId = $routeProperties['Name'];
+            $methods = explode('|', $routeProperties['Method']);
             foreach ($methods as $method) {
                 if ('OPTIONS' === $method) {
                     continue;
                 }
-                $routePath = str_replace($this->apiUri, '', $lineParts[4]);
+                $routePath = str_replace($this->apiUri, '', $routeProperties['Path']);
                 if (!array_key_exists($routePath, $confRoutes)) {
                     $confRoutes[$routePath] = ['methods' => []];
                 }

Original file line number	Diff line number	Diff line change
`@@ -170,13 +170,14 @@ private function parseRouterOutput($consolePath)`
`170`	`170`	`continue;`
`171`	`171`	`}`
`172`	`172`	`$lineParts = preg_split('/\s+/', $outputLine);`
`173`		`- $routeId = $lineParts[0];`
`174`		`- $methods = explode('\|', $lineParts[1]);`
	`173`	`+ $routeProperties = array_combine(['Name', 'Method', 'Scheme', 'Host', 'Path'], $lineParts);`
	`174`	`+ $routeId = $routeProperties['Name'];`
	`175`	`+ $methods = explode('\|', $routeProperties['Method']);`
`175`	`176`	`foreach ($methods as $method) {`
`176`	`177`	`if ('OPTIONS' === $method) {`
`177`	`178`	`continue;`
`178`	`179`	`}`
`179`		`- $routePath = str_replace($this->apiUri, '', $lineParts[4]);`
	`180`	`+ $routePath = str_replace($this->apiUri, '', $routeProperties['Path']);`
`180`	`181`	`if (!array_key_exists($routePath, $confRoutes)) {`
`181`	`182`	`$confRoutes[$routePath] = ['methods' => []];`
`182`	`183`	`}`