Fix PHPStan errors (#2610)

* Fix errors found by PHPStan
* code_samples_usage.php: Tri more visible 'highlighted line' marker

Author: adriendupuis

code_samples/search/custom/src/EventSubscriber/CustomQueryFilterSubscriber.php

@@ -6,7 +6,7 @@
 
 use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\LogicalAnd;
 use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\ObjectStateIdentifier;
-use Ibexa\Contracts\ElasticSearch\Query\Event\QueryFilterEvent;
+use Ibexa\Contracts\Elasticsearch\Query\Event\QueryFilterEvent;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 
 final class CustomQueryFilterSubscriber implements EventSubscriberInterface

code_samples/search/custom/src/Query/Aggregation/Elasticsearch/PriorityRangeAggregationVisitor.php

@@ -18,6 +18,8 @@ public function supports(Aggregation $aggregation, LanguageFilter $languageFilte
 
     /**
      * @param \App\Query\Aggregation\PriorityRangeAggregation $aggregation
+     *
+     * @return array<string, array<string, mixed>>
      */
     public function visit(AggregationVisitor $dispatcher, Aggregation $aggregation, LanguageFilter $languageFilter): array
     {

code_samples/search/custom/src/Query/Criterion/Elasticsearch/CameraManufacturerVisitor.php

@@ -17,7 +17,7 @@ public function supports(Criterion $criterion, LanguageFilter $languageFilter):
     }
 
     /**
-     * @param \App\Query\Criterion\Elasticsearch\CameraManufacturerCriterion $criterion
+     * @param \App\Query\Criterion\CameraManufacturerCriterion $criterion
      */
     public function visit(CriterionVisitor $dispatcher, Criterion $criterion, LanguageFilter $languageFilter): array
     {

code_samples/search/custom/src/Query/Criterion/Solr/CameraManufacturerVisitor.php

@@ -16,7 +16,7 @@ public function canVisit(Criterion $criterion)
     }
 
     /**
-     * @param \App\Query\Criterion\Solr\CameraManufacturerCriterion $criterion
+     * @param \App\Query\Criterion\CameraManufacturerCriterion $criterion
      */
     public function visit(Criterion $criterion, CriterionVisitor $subVisitor = null)
     {

phpstan-baseline.neon

@@ -355,11 +355,6 @@ parameters:
 			count: 1
 			path: code_samples/search/custom/src/Query/Aggregation/Elasticsearch/PriorityRangeAggregationResultExtractor.php
 
-		-
-			message: "#^Method App\\\\Query\\\\Aggregation\\\\Elasticsearch\\\\PriorityAggregationVisitor\\:\\:visit\\(\\) return type has no value type specified in iterable type array\\.$#"
-			count: 1
-			path: code_samples/search/elasticsearch/src/Query/Aggregation/Elasticsearch/PriorityAggregationVisitor.php
-
 		-
 			message: "#^Method App\\\\Query\\\\Criterion\\\\Elasticsearch\\\\CameraManufacturerVisitor\\:\\:visit\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 1

tools/code_samples/code_samples_usage.php

@@ -35,7 +35,7 @@ function displayBlocks(array $docFileBlocks, string $docFilePath = null, $lineOf
         try {
             $blockContents = getBlockContents($block);
             foreach ($blockContents['contents'] as $contentLineNumber => $contentLine) {
-                $prefixedBlockContentLines[] = str_pad($contentLineNumber, 3, 0, STR_PAD_LEFT) . (in_array($contentLineNumber, $blockContents['highlights']) ? '⫸' : '⫶') . $contentLine;
+                $prefixedBlockContentLines[] = str_pad($contentLineNumber, 3, 0, STR_PAD_LEFT) . (in_array($contentLineNumber, $blockContents['highlights']) ? '❇️' : '⫶') . $contentLine;
             }
             echo implode(PHP_EOL, $prefixedBlockContentLines) . PHP_EOL . PHP_EOL;
         } catch (Exception $exception) {