Skip to content

Commit da0eced

Browse files
mnoconmnocon
committed
Generated baseline and fixed some usages
1 parent f4593c0 commit da0eced

File tree

10 files changed

+195
-37
lines changed

10 files changed

+195
-37
lines changed

‎code_samples/api/commerce/src/Command/CartCommand.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
use Ibexa\Contracts\Cart\Value\EntryAddStruct;
1313
use Ibexa\Contracts\Cart\Value\EntryUpdateStruct;
1414
use Ibexa\Contracts\Checkout\Reorder\ReorderService;
15+
use Ibexa\Contracts\Core\Repository\PermissionResolver;
1516
use Ibexa\Contracts\Core\Repository\UserService;
1617
use Ibexa\Contracts\OrderManagement\OrderServiceInterface;
1718
use Ibexa\Contracts\ProductCatalog\CurrencyServiceInterface;
1819
use Ibexa\Contracts\ProductCatalog\ProductServiceInterface;
19-
use Ibexa\Core\Repository\Permission\PermissionResolver;
2020
use Symfony\Component\Console\Command\Command;
2121
use Symfony\Component\Console\Input\InputInterface;
2222
use Symfony\Component\Console\Output\OutputInterface;

‎code_samples/api/migration/src/Command/MigrationCommand.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace App\Command;
44

5-
use Ibexa\Migration\MigrationService;
5+
use Ibexa\Contracts\Migration\MigrationService;
66
use Ibexa\Migration\Repository\Migration;
77
use Symfony\Component\Console\Command\Command;
88
use Symfony\Component\Console\Input\InputInterface;

‎code_samples/api/public_php_api/src/Command/SegmentCommand.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Ibexa\Contracts\Core\Repository\PermissionResolver;
66
use Ibexa\Contracts\Core\Repository\UserService;
7-
use Ibexa\Segmentation\Service\SegmentationService;
7+
use Ibexa\Contracts\Segmentation\SegmentationServiceInterface;
88
use Ibexa\Segmentation\Value\SegmentCreateStruct;
99
use Ibexa\Segmentation\Value\SegmentGroupCreateStruct;
1010
use Symfony\Component\Console\Command\Command;
@@ -13,13 +13,13 @@
1313

1414
class SegmentCommand extends Command
1515
{
16-
private SegmentationService $segmentationService;
16+
private SegmentationServiceInterface $segmentationService;
1717

1818
private UserService $userService;
1919

2020
private PermissionResolver $permissionResolver;
2121

22-
public function __construct(SegmentationService $segmentationService, UserService $userService, PermissionResolver $permissionResolver)
22+
public function __construct(SegmentationServiceInterface $segmentationService, UserService $userService, PermissionResolver $permissionResolver)
2323
{
2424
$this->segmentationService = $segmentationService;
2525
$this->permissionResolver = $permissionResolver;

‎code_samples/back_office/calendar/src/Calendar/Holidays/EventSourceFactory.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44

55
use DateTime;
66
use DateTimeInterface;
7-
use Ibexa\Calendar\EventSource\InMemoryEventSource;
87
use Ibexa\Contracts\Calendar\EventCollection;
98
use Ibexa\Contracts\Calendar\EventSource\EventSourceInterface;
9+
use Ibexa\Contracts\Calendar\EventSource\InMemoryEventSource;
1010

1111
class EventSourceFactory
1212
{

‎code_samples/back_office/calendar/src/Calendar/Holidays/EventType.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
namespace App\Calendar\Holidays;
44

5-
use Ibexa\Calendar\EventAction\EventActionCollection;
65
use Ibexa\Contracts\Calendar\Event;
6+
use Ibexa\Contracts\Calendar\EventAction\EventActionCollection;
77
use Ibexa\Contracts\Calendar\EventType\EventTypeInterface;
88

99
class EventType implements EventTypeInterface

‎code_samples/back_office/images/src/PlaceholderProvider.php‎

Lines changed: 0 additions & 18 deletions
This file was deleted.

‎code_samples/back_office/limitation/src/Security/Limitation/CustomLimitationType.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public function acceptValue(Limitation $limitationValue): void
2727
}
2828
}
2929

30-
/** @return \Ibexa\Core\FieldType\ValidationError[] */
30+
/** @return \Ibexa\Contracts\Core\FieldType\ValidationError[] */
3131
public function validate(Limitation $limitationValue): array
3232
{
3333
$validationErrors = [];

‎deptrac.baseline.yaml‎

Lines changed: 185 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,185 @@
1+
deptrac:
2+
skip_violations:
3+
App\Attribute\Percent\Form\PercentValueFormMapper:
4+
- Ibexa\Bundle\ProductCatalog\Validator\Constraints\AttributeValue
5+
App\Attribute\Percent\PercentOptionsFormMapper:
6+
- Ibexa\Bundle\ProductCatalog\Validator\Constraints\AttributeDefinitionOptions
7+
App\Attribute\Percent\Storage\PercentStorageConverter:
8+
- Ibexa\ProductCatalog\Local\Persistence\Legacy\Attribute\Float\StorageSchema
9+
App\Attribute\Percent\Storage\PercentStorageDefinition:
10+
- Ibexa\ProductCatalog\Local\Persistence\Legacy\Attribute\Float\StorageSchema
11+
App\Block\Listener\MyBlockListener:
12+
- Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\BlockRenderEvents
13+
- Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\Event\PreRenderEvent
14+
App\CatalogFilter\ProductNameFilterFormMapper:
15+
- Ibexa\Bundle\ProductCatalog\Form\Type\TagifyType
16+
App\Checkout\Workflow\Strategy\NewWorkflow:
17+
- Ibexa\Checkout\Value\Workflow\Workflow
18+
App\Checkout\Workflow\Strategy\NewWorkflowConditionalStep:
19+
- Ibexa\Checkout\Value\Workflow\Workflow
20+
App\Command\CalendarCommand:
21+
- Ibexa\Scheduler\Calendar\EventAction\RescheduleEventActionContext
22+
App\Command\CatalogCommand:
23+
- Ibexa\ProductCatalog\Local\Repository\Values\Catalog\Status
24+
App\Command\CreateImageCommand:
25+
- Ibexa\Core\FieldType\Image\Value
26+
App\Command\MigrationCommand:
27+
- Ibexa\Migration\Repository\Migration
28+
App\Command\PaymentMethodCommand:
29+
- Ibexa\Payment\Values\PaymentMethodType
30+
App\Command\SegmentCommand:
31+
- Ibexa\Segmentation\Value\SegmentCreateStruct
32+
- Ibexa\Segmentation\Value\SegmentGroupCreateStruct
33+
App\Command\ShippingMethodCommand:
34+
- Ibexa\ProductCatalog\Local\Repository\Values\Region
35+
- Ibexa\Shipping\Value\ShippingMethodType
36+
App\Command\ViewCommand:
37+
- Ibexa\Core\MVC\Symfony\View\Builder\ContentViewBuilder
38+
- Ibexa\Core\MVC\Symfony\View\Renderer\TemplateRenderer
39+
App\Controller\AllContentListController:
40+
- Ibexa\AdminUi\Form\Factory\FormFactory
41+
- Ibexa\Core\Pagination\Pagerfanta\LocationSearchAdapter
42+
App\Controller\BreadcrumbController:
43+
- Ibexa\Bundle\Core\Controller
44+
App\Controller\Checkout\OnePageCheckout:
45+
- Ibexa\Bundle\Checkout\Controller\AbstractStepController
46+
App\Controller\Checkout\Step\SelectSeatStepController:
47+
- Ibexa\Bundle\Checkout\Controller\AbstractStepController
48+
App\Controller\CustomCheckoutController:
49+
- Ibexa\Bundle\Core\Controller
50+
App\Controller\CustomController:
51+
- Ibexa\Bundle\Core\Controller
52+
App\Controller\CustomFilterController:
53+
- Ibexa\Bundle\Core\Controller
54+
- Ibexa\Core\MVC\Symfony\View\ContentView
55+
App\Controller\PaginationController:
56+
- Ibexa\Bundle\Core\Controller
57+
- Ibexa\Core\Pagination\Pagerfanta\ContentSearchAdapter
58+
App\Controller\RelationController:
59+
- Ibexa\Core\MVC\Symfony\View\View
60+
App\Controller\SvgController:
61+
- Ibexa\Core\Helper\TranslationHelper
62+
- Ibexa\Core\IO\IOServiceInterface
63+
- Ibexa\Core\MVC\Symfony\Controller\Controller
64+
App\Corporate\EventSubscriber\ApplicationDetailsViewSubscriber:
65+
- Ibexa\Bundle\CorporateAccount\EventSubscriber\AbstractViewSubscriber
66+
- Ibexa\Core\MVC\Symfony\SiteAccess\SiteAccessServiceInterface
67+
- Ibexa\Core\MVC\Symfony\View\View
68+
- Ibexa\CorporateAccount\View\ApplicationDetailsView
69+
App\Corporate\EventSubscriber\VerifyStateEventSubscriber:
70+
- Ibexa\CorporateAccount\Event\ApplicationWorkflowEvents
71+
- Ibexa\CorporateAccount\Persistence\Legacy\ApplicationState\HandlerInterface
72+
- Ibexa\CorporateAccount\Persistence\Values\ApplicationStateUpdateStruct
73+
App\EventListener\TextAnchorMenuTabListener:
74+
- Ibexa\AdminUi\Menu\ContentEditAnchorMenuBuilder
75+
- Ibexa\AdminUi\Menu\Event\ConfigureMenuEvent
76+
App\EventSubscriber\BreadcrumbsMenuSubscriber:
77+
- Ibexa\Bundle\Storefront\Menu\Builder\BreadcrumbsMenuBuilder
78+
App\EventSubscriber\FormFieldDefinitionSubscriber:
79+
- Ibexa\FormBuilder\Definition\FieldAttributeDefinitionBuilder
80+
- Ibexa\FormBuilder\Event\FieldDefinitionEvent
81+
- Ibexa\FormBuilder\Event\FormEvents
82+
App\EventSubscriber\MyMenuSubscriber:
83+
- Ibexa\AdminUi\Menu\Event\ConfigureMenuEvent
84+
- Ibexa\AdminUi\Menu\MainMenuBuilder
85+
App\Event\RandomBlockListener:
86+
- Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\BlockRenderEvents
87+
- Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\Event\PreRenderEvent
88+
App\Event\Subscriber\BlockEmbedEventEventSubscriber:
89+
- Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\BlockRenderEvents
90+
- Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\Event\PreRenderEvent
91+
App\Event\Subscriber\RichTextBlockSubscriber:
92+
- Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\BlockRenderEvents
93+
- Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\Event\PreRenderEvent
94+
- Ibexa\FieldTypePage\FieldType\Page\Block\Renderer\Twig\TwigRenderRequest
95+
- Ibexa\FieldTypeRichText\RichText\DOMDocumentFactory
96+
App\FieldType\HelloWorld\Comparison\Comparable:
97+
- Ibexa\VersionComparison\ComparisonValue\StringComparisonValue
98+
App\FieldType\HelloWorld\Comparison\HelloWorldComparisonEngine:
99+
- Ibexa\VersionComparison\Engine\Value\StringComparisonEngine
100+
App\FieldType\HelloWorld\Comparison\HelloWorldComparisonResult:
101+
- Ibexa\VersionComparison\Result\Value\StringComparisonResult
102+
App\FieldType\HelloWorld\Comparison\Value:
103+
- Ibexa\VersionComparison\ComparisonValue\StringComparisonValue
104+
App\FormBuilder\FieldType\Field\Mapper\CheckboxWithRichtextDescriptionFieldMapper:
105+
- Ibexa\FormBuilder\FieldType\Field\Mapper\GenericFieldMapper
106+
App\FormBuilder\Field\Mapper\CountryFieldMapper:
107+
- Ibexa\FormBuilder\FieldType\Field\Mapper\GenericFieldMapper
108+
App\FormBuilder\FormSubmission\Converter\RichtextDescriptionFieldSubmissionConverter:
109+
- Ibexa\FormBuilder\FormSubmission\Converter\BooleanFieldSubmissionConverter
110+
App\FormBuilder\Form\Type\FieldAttribute\AttributeRichtextDescriptionType:
111+
- Ibexa\FieldTypeRichText\Form\Type\RichTextType
112+
App\Form\Type\OnePageCheckoutType:
113+
- Ibexa\Bundle\Checkout\Form\Type\AddressType
114+
- Ibexa\Bundle\Payment\Form\Type\PaymentMethodChoiceType
115+
- Ibexa\Bundle\Shipping\Form\Type\ShippingMethodChoiceType
116+
App\GraphQL\Schema\MyCustomFieldDefinitionMapper:
117+
- Ibexa\GraphQL\Schema\Domain\Content\Mapper\FieldDefinition\DecoratingFieldDefinitionMapper
118+
App\Kernel:
119+
- Ibexa\Bundle\Core\DependencyInjection\IbexaCoreExtension
120+
App\Migrations\Action\AssignSection:
121+
- Ibexa\Migration\ValueObject\Step\Action
122+
App\Migrations\Action\AssignSectionExecutor:
123+
- Ibexa\Migration\StepExecutor\ActionExecutor\ExecutorInterface
124+
- Ibexa\Migration\ValueObject\Step\Action
125+
App\Migrations\Matcher\SectionIdentifierGenerator:
126+
- Ibexa\Migration\Generator\CriterionGenerator\GeneratorInterface
127+
App\Migrations\Matcher\SectionIdentifierNormalizer:
128+
- Ibexa\Bundle\Migration\Serializer\Normalizer\Criterion\AbstractCriterionNormalizer
129+
App\Migrations\Step\ReplaceNameStep:
130+
- Ibexa\Migration\ValueObject\Step\StepInterface
131+
App\Migrations\Step\ReplaceNameStepExecutor:
132+
- Ibexa\Core\FieldType\TextLine\Value
133+
- Ibexa\Migration\ValueObject\Step\StepInterface
134+
App\Migrations\Step\ReplaceNameStepNormalizer:
135+
- Ibexa\Migration\ValueObject\Step\StepInterface
136+
App\Notification\MyRenderer:
137+
- Ibexa\Core\Notification\Renderer\NotificationRenderer
138+
App\OAuth\GoogleResourceOwnerMapper:
139+
- Ibexa\OAuth2Client\ResourceOwner\ResourceOwnerToExistingOrNewUserMapper
140+
App\QueryType\LatestContentQueryType:
141+
- Ibexa\Core\QueryType\QueryType
142+
App\QueryType\MenuQueryType:
143+
- Ibexa\Core\QueryType\QueryType
144+
App\QueryType\OptionsBasedLatestContentQueryType:
145+
- Ibexa\Core\QueryType\OptionsResolverBasedQueryType
146+
- Ibexa\Core\QueryType\QueryType
147+
App\Rest\Controller\DefaultController:
148+
- Ibexa\Rest\Message
149+
- Ibexa\Rest\Server\Controller
150+
App\Rest\InputParser\GreetingInput:
151+
- Ibexa\Rest\Input\BaseParser
152+
App\Rest\ValueObjectVisitor\RestLocation:
153+
- Ibexa\Rest\Server\Output\ValueObjectVisitor\RestLocation
154+
- Ibexa\Rest\Server\Values\URLAliasRefList
155+
App\Search\Model\Suggestion\ProductSuggestion:
156+
- Ibexa\ProductCatalog\Local\Repository\Values\Product
157+
App\Security\Limitation\CustomLimitationType:
158+
- Ibexa\Core\Base\Exceptions\InvalidArgumentException
159+
- Ibexa\Core\Base\Exceptions\InvalidArgumentType
160+
- Ibexa\Core\FieldType\ValidationError
161+
App\Security\Limitation\Mapper\CustomLimitationFormMapper:
162+
- Ibexa\AdminUi\Limitation\LimitationFormMapperInterface
163+
- Ibexa\Core\Limitation\LimitationIdentifierToLabelConverter
164+
App\Security\Limitation\Mapper\CustomLimitationValueMapper:
165+
- Ibexa\AdminUi\Limitation\LimitationValueMapperInterface
166+
App\Security\MyPolicyProvider:
167+
- Ibexa\Bundle\Core\DependencyInjection\Security\PolicyProvider\YamlPolicyProvider
168+
App\Setting\Group\MyGroup:
169+
- Ibexa\User\UserSetting\Group\AbstractGroup
170+
App\Setting\Unit:
171+
- Ibexa\Core\Base\Exceptions\InvalidArgumentException
172+
App\ShippingMethodType\Storage\StorageDefinition:
173+
- Ibexa\Shipping\Persistence\Legacy\ShippingMethod\AbstractOptionsStorageSchema
174+
App\ShippingMethodType\Storage\StorageSchema:
175+
- Ibexa\Shipping\Persistence\Legacy\ShippingMethod\AbstractOptionsStorageSchema
176+
App\Tab\Dashboard\Everyone\EveryoneArticleTab:
177+
- Ibexa\AdminUi\Tab\Dashboard\PagerLocationToDataMapper
178+
- Ibexa\Core\Pagination\Pagerfanta\LocationSearchAdapter
179+
App\View\Matcher\Owner:
180+
- Ibexa\Core\MVC\Symfony\Matcher\ContentBased\MatcherInterface
181+
- Ibexa\Core\MVC\Symfony\View\ContentValueView
182+
- Ibexa\Core\MVC\Symfony\View\LocationValueView
183+
- Ibexa\Core\MVC\Symfony\View\View
184+
AttributeTypeExtension:
185+
- Ibexa\PageBuilder\Form\Type\Attribute\AttributeType

‎docs/content_management/images/images.md‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,17 +108,13 @@ You can also pass two additional parameters:
108108
With a placeholder generator you can download or generate placeholder images for any missing image.
109109
It proves useful when you're working on an existing database and are unable to download uploaded images to your local development environment, due to, for example, a large size of files.
110110

111-
If the original image cannot be resolved, the `PlaceholderAliasGenerator::getVariation` method generates a placeholder by delegating it to the implementation of the `PlaceholderProvider` interface, and saves it under the original path.
111+
If the original image cannot be resolved, the `PlaceholderAliasGenerator::getVariation` method generates a placeholder by delegating it to the implementation of the [PlaceholderProvider](https://github.com/ibexa/core/blob/main/src/bundle/Core/Imagine/PlaceholderProvider.php) interface, and saves it under the original path.
112112

113113
In [[= product_name =]], there are two implementations of the `PlaceholderProvider` interface:
114114

115115
- [GenericProvider](#genericprovider)
116116
- [RemoteProvider](#remoteprovider)
117117

118-
``` php
119-
[[= include_file('code_samples/back_office/images/src/PlaceholderProvider.php') =]]
120-
```
121-
122118
### GenericProvider
123119

124120
The [`GenericProvider`](https://github.com/ibexa/core/blob/main/src/bundle/Core/Imagine/PlaceholderProvider.php) package generates placeholders with basic information about the original image (see [example 1](#configuration-examples)).

‎phpstan-baseline.neon‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ parameters:
1111
path: code_samples/api/graphql/src/DependencyInjection/Compiler/MyCustomTypeGraphQLCompilerPass.php
1212

1313
-
14-
message: "#^Parameter \\#1 \\$migration of method Ibexa\\\\Migration\\\\MigrationService\\:\\:executeOne\\(\\) expects Ibexa\\\\Migration\\\\Repository\\\\Migration, Ibexa\\\\Migration\\\\Repository\\\\Migration\\|null given\\.$#"
14+
message: "#^Parameter \\#1 \\$migration of method Ibexa\\\\Contracts\\\\Migration\\\\MigrationService\\:\\:executeOne\\(\\) expects Ibexa\\\\Migration\\\\Repository\\\\Migration, Ibexa\\\\Migration\\\\Repository\\\\Migration\\|null given\\.$#"
1515
count: 1
1616
path: code_samples/api/migration/src/Command/MigrationCommand.php
1717

@@ -175,11 +175,6 @@ parameters:
175175
count: 1
176176
path: code_samples/back_office/content_type/src/EventListener/TextAnchorMenuTabListener.php
177177

178-
-
179-
message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\Imagine\\\\PlaceholderProvider\\:\\:getPlaceholder\\(\\) has parameter \\$options with no value type specified in iterable type array\\.$#"
180-
count: 1
181-
path: code_samples/back_office/images/src/PlaceholderProvider.php
182-
183178
-
184179
message: "#^Return type \\(bool\\) of method App\\\\Security\\\\Limitation\\\\Mapper\\\\CustomLimitationValueMapper\\:\\:mapLimitationValue\\(\\) should be compatible with return type \\(array\\) of method Ibexa\\\\AdminUi\\\\Limitation\\\\LimitationValueMapperInterface\\:\\:mapLimitationValue\\(\\)$#"
185180
count: 1

0 commit comments

Comments
 (0)