Skip to content

Commit e9b50b8

Browse files
authored
[v5] Moved from Criterion to CriterionInterface (#2576)
* [v5] Moved from Criterion to CriterionInterface * Added PHPdoc
1 parent 3c096b1 commit e9b50b8

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

code_samples/search/elasticsearch/src/Query/Criterion/Elasticsearch/CameraManufacturerVisitor.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,21 @@
44

55
namespace App\Query\Criterion\Elasticsearch;
66

7-
use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion;
7+
use Ibexa\Contracts\Core\Repository\Values\Content\Query\CriterionInterface;
88
use Ibexa\Contracts\Elasticsearch\Query\CriterionVisitor;
99
use Ibexa\Contracts\Elasticsearch\Query\LanguageFilter;
1010

1111
final class CameraManufacturerVisitor implements CriterionVisitor
1212
{
13-
public function supports(Criterion $criterion, LanguageFilter $languageFilter): bool
13+
public function supports(CriterionInterface $criterion, LanguageFilter $languageFilter): bool
1414
{
1515
return $criterion instanceof CameraManufacturerCriterion;
1616
}
1717

18-
public function visit(CriterionVisitor $dispatcher, Criterion $criterion, LanguageFilter $languageFilter): array
18+
/**
19+
* @param \App\Query\Criterion\Elasticsearch\CameraManufacturerCriterion $criterion
20+
*/
21+
public function visit(CriterionVisitor $dispatcher, CriterionInterface $criterion, LanguageFilter $languageFilter): array
1922
{
2023
return [
2124
'terms' => [

code_samples/search/solr/src/Query/Criterion/Solr/CameraManufacturerVisitor.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,20 @@
44

55
namespace App\Query\Criterion\Solr;
66

7-
use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion;
7+
use Ibexa\Contracts\Core\Repository\Values\Content\Query\CriterionInterface;
88
use Ibexa\Contracts\Solr\Query\CriterionVisitor;
99

1010
final class CameraManufacturerVisitor extends CriterionVisitor
1111
{
12-
public function canVisit(Criterion $criterion)
12+
public function canVisit(CriterionInterface $criterion)
1313
{
1414
return $criterion instanceof CameraManufacturerCriterion;
1515
}
1616

17-
public function visit(Criterion $criterion, CriterionVisitor $subVisitor = null)
17+
/**
18+
* @param \App\Query\Criterion\Solr\CameraManufacturerCriterion $criterion
19+
*/
20+
public function visit(CriterionInterface $criterion, CriterionVisitor $subVisitor = null)
1821
{
1922
$expressions = array_map(
2023
function ($value): string {

0 commit comments

Comments
 (0)