Added instructions on how to combine varnish with basic-auth #2526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidarl
force-pushed
the
varnish_basic_auth
branch
from
6a746b4 to
8171be8
Compare
adamwojs
approved these changes
Oct 24, 2024
mnocon
reviewed
Oct 28, 2024
docs/infrastructure_and_maintenance/cache/http_cache/reverse_proxy.md
Outdated
Show resolved
Hide resolved
|
|
||
| ``` yaml | ||
| http_cache: | ||
| purge_servers: [http://myuser:[email protected]:8081] |
There was a problem hiding this comment.
Suggested change
| purge_servers: [http://myuser:[email protected]:8081] | |
| purge_servers: [https://myuser:[email protected]:8081] |
Can we suggest using HTTPS by default, for everything?
There was a problem hiding this comment.
Yes, we can do that. But open source version of Varnish do not support HTTPS termiation, so I think it makes more sense to always use HTTP for varnish purge servers in or docs.
There was a problem hiding this comment.
Good point! My mind always goes to "HTTPS links everywhere", but it makes sense to make an exception when it's expected to see HTTP.
docs/infrastructure_and_maintenance/cache/http_cache/reverse_proxy.md
Outdated
Show resolved
Hide resolved
docs/infrastructure_and_maintenance/cache/http_cache/reverse_proxy.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Marek Nocoń <[email protected]>
mnocon
approved these changes
Oct 29, 2024
mnocon
added a commit
that referenced
this pull request
Oct 29, 2024
* Added instructions on how to combine varnish with basic-auth * fixup! Added instructions on how to combine varnish with basic-auth * Apply suggestions from code review Co-authored-by: Marek Nocoń <[email protected]> --------- Co-authored-by: Marek Nocoń <[email protected]>
|
I've also upmerged it to master - thank you for the PR Vidar! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions on how to provide basic auth credentials in purge request was missing
Checklist