PHP API Reference Fixes #2549
Merged
PHP API Reference Fixes #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriendupuis
added a commit
that referenced
this pull request
Nov 26, 2024
* PHP API Ref: Ignore `@extends` tags as only used for PHPStan * PHP API Ref: Fix "phpDocumentor Admonition" SVG size (cherry picked from commit 977421e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@extendsas it's only used for PHPStan with PHPStan syntax incompatible with regular PHPDoc syntax understood by phpDocumentor. Without it, phpDocumentor already generate proper doc from PHPextendskeyword.(I ran
grep '@extends' -R vendor/ibexa | grep contracts | sortto check every usage.)Preview:
AbstractCriterionQuerydoc has a huge deprecation warning icon and a hard-to-understand listed Extends tag.AbstractCriterionQueryhas a reasonable icon size and no Extends tag while it still document the inheritance with a working link.Checklist