Skip to content

Images: Update caution block #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 10, 2025
Merged

Images: Update caution block #2607

merged 4 commits into from
Feb 10, 2025

Conversation

@adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Feb 7, 2025 •
edited
Loading

Question Answer
JIRA Ticket N/A
Versions master, 4.6, 3.3
Edition All

Before: https://doc.ibexa.co/en/master/content_management/images/images/#configuring-image-variations
After: https://ez-systems-developer-documentation--2607.com.readthedocs.build/en/2607/content_management/images/images/#configuring-image-variations

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

mnocon
mnocon reviewed Feb 7, 2025
View reviewed changes
mnocon
mnocon approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

glye
glye requested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done in a separate PR if too off topic.

@adriendupuis adriendupuis changed the title images.md: Fix grammar Images: Update caution block Feb 7, 2025
adriendupuis
adriendupuis commented Feb 7, 2025
View reviewed changes
@adriendupuis
Copy link
Contributor Author

adriendupuis commented Feb 7, 2025

@glye @mnocon
I applied Gunnstein's update suggestion. The caution block know looks like this:
https://ez-systems-developer-documentation--2607.com.readthedocs.build/en/2607/content_management/images/images/#configuring-image-variations

adriendupuis
adriendupuis commented Feb 7, 2025
View reviewed changes
@adriendupuis adriendupuis merged commit f6f99d7 into master Feb 10, 2025
5 of 6 checks passed
@adriendupuis adriendupuis deleted the adriendupuis-patch-1 branch February 10, 2025 08:32
adriendupuis added a commit that referenced this pull request Feb 10, 2025
@adriendupuis
Images: Update caution block (#2607)
87c44bc 
(cherry picked from commit f6f99d7)
adriendupuis added a commit that referenced this pull request Feb 10, 2025
@adriendupuis
Images: Update caution block (#2607)
f55e54e 
(cherry picked from commit f6f99d7)
@mnocon mnocon mentioned this pull request Mar 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glye glye glye approved these changes

@mnocon mnocon mnocon approved these changes

Assignees

No one assigned

Labels

Ready for MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adriendupuis @glye @mnocon