[Expand Team Reviewers] Aligned the workflow with GitHub API changes #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
adjust-expand-team-reviewers-workflow
branch
2 times, most recently
from
d4b2252 to
6f8c7ce
Compare
alongosz
force-pushed
the
adjust-expand-team-reviewers-workflow
branch
from
6f8c7ce to
78148d0
Compare
alongosz
force-pushed
the
adjust-expand-team-reviewers-workflow
branch
2 times, most recently
from
2ef0812 to
2222936
Compare
alongosz
changed the title
alongosz
commented
Nov 7, 2025
Comment on lines
+50
to
+56
| exit_code=$? | ||
| if [[ $exit_code -ne 0 ]] | ||
| then | ||
| echo "Error: Failed to fetch team members" | ||
| echo "$members" # contains the error message | ||
| exit $exit_code | ||
| fi |
Member
Author
There was a problem hiding this comment.
Note
Without this, the workflow tries to input error message as a list of reviewers, which is at least a waste of GHA tokens (aka Żappsy :D)
alongosz
requested review from
Steveb-p,
ViniTou,
adamwojs,
barw4,
ciastektk,
ibexa-yuna,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
ibexa-yuna
approved these changes
Nov 7, 2025
konradoboza
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Note
gh pr edit: Ensure empty arrays for reviewers in PR API calls cli/cli#12122. Do we wait for the patch release ofghor do we merge this one as-is? The change with removing of PR author from the list is still needed.Attempting to adjust the workflow expanding team review requests into separate members request. A while ago GitHub API started returning
when PR author was in the list of members a review was requested from. Seems like breaking change, but logical. We need to filter out PR author from the members list when processing this workflow.
Another issue that gave me a bit of headache was
When executing
gh pr edit .... Seems the culprit was removal of a team. Something is broken or changed together with the other API change and it's not possible to remove a team, if this is the only reviewer we want to remove.I've opened an issue with GH CLI. It has been fixed so do we get the current solution as-is or we wait for the release of GH?
For the time being, for deleting team reviewer I swithed to raw REST API. Tested via https://github.com/ibexa/shopping-list/pull/14 and seems to be working.