Skip to content

[Expand Team Reviewers] Aligned the workflow with GitHub API changes #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Expand Team Reviewers] Aligned the workflow with GitHub API changes #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bfda72
Filtered out PR author when requesting a review
alongosz Nov 7, 2025
2222936
Extracted review removal into raw gh api call due to a bug
alongosz Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions .github/workflows/expand-team-reviewers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,45 @@ jobs:
owner: ${{ github.repository_owner }}

- name: Expand team to individual reviewers
shell: bash
run: |
org="${{ github.repository_owner }}"
repo="${{ inputs.repository }}"
team="${{ inputs.requested_team }}"
pr="${{ inputs.pull_request_number }}"
pr_author="${{ github.event.pull_request.user.login }}"
# Get team members, but filter out a PR author because review cannot be requested from the author
members=$(gh api /orgs/$org/teams/$team/members \
--paginate \
--jq '.[].login' \
| paste -sd "," -)
if [ -n "$members" ]; then
--jq '.[].login | select(. != "'"$pr_author"'")' )

exit_code=$?
if [[ $exit_code -ne 0 ]]
then
echo "Error: Failed to fetch team members"
echo "$members" # contains the error message
exit $exit_code
fi
Comment on lines +50 to +56
Copy link
Member Author

@alongosz alongosz Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Without this, the workflow tries to input error message as a list of reviewers, which is at least a waste of GHA tokens (aka Żappsy :D)


if [[ -n "$members" ]]
then
members_list=$(echo "$members" | paste -sd ",")
echo "Requesting review for $repo#$pr from $org/$team members: $members_list"

gh api \
--method DELETE \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/repos/$repo/pulls/$pr/requested_reviewers --input - <<< '{
"reviewers": [],
"team_reviewers": [
"'"$team"'"
]
}'

gh pr edit "$pr" \
--repo "$repo" \
--remove-reviewer "$org/$team" \
--add-reviewer "$members"
--add-reviewer "$members_list"
fi
env:
GITHUB_TOKEN: ${{ steps.generate_token.outputs.token }}