IBX-9727: Added missing strict types (#188)

Author: barw4

phpstan-baseline.neon

@@ -24,10 +24,6 @@ class Factory
 
     protected Repository $repository;
 
-    /**
-     * @param \Ibexa\Contracts\Core\SiteAccess\ConfigResolverInterface $configResolver
-     * @param \Ibexa\Contracts\Core\Repository\Repository $repository
-     */
     public function __construct(ConfigResolverInterface $configResolver, Repository $repository)
     {
         $this->configResolver = $configResolver;
@@ -49,10 +45,6 @@ public function getMediaFieldTypeProcessor(): MediaProcessor
 
     /**
      * Factory for ezpublish_rest.field_type_processor.ibexa_image.
-     *
-     * @param \Symfony\Component\Routing\RouterInterface $router
-     *
-     * @return \Ibexa\Rest\FieldTypeProcessor\ImageProcessor
      */
     public function getImageFieldTypeProcessor(RouterInterface $router): ImageProcessor
     {

src/bundle/ApiLoader/Factory.php

@@ -106,8 +106,8 @@ public function __construct(
         ?bool $forceEager = null,
         ?int $priority = null,
         ?string $name = null,
-        $provider = null,
-        $processor = null,
+        callable|string|null $provider = null,
+        callable|string|null $processor = null,
         ?OptionsInterface $stateOptions = null,
         array|Parameters|null $parameters = null,
         array $extraProperties = [],

src/bundle/ApiPlatform/Head.php

@@ -15,7 +15,7 @@
 
 class FieldTypeProcessorPass implements CompilerPassInterface
 {
-    private const FIELD_TYPE_PROCESSOR_SERVICE_TAG = 'ibexa.rest.field_type.processor';
+    private const string FIELD_TYPE_PROCESSOR_SERVICE_TAG = 'ibexa.rest.field_type.processor';
 
     public function process(ContainerBuilder $container): void
     {

src/bundle/DependencyInjection/Compiler/FieldTypeProcessorPass.php

@@ -20,7 +20,7 @@
  */
 class InputHandlerPass implements CompilerPassInterface
 {
-    public const INPUT_HANDLER_SERVICE_TAG = 'ibexa.rest.input.handler';
+    public const string INPUT_HANDLER_SERVICE_TAG = 'ibexa.rest.input.handler';
 
     public function process(ContainerBuilder $container): void
     {

src/bundle/DependencyInjection/Compiler/InputHandlerPass.php

@@ -20,7 +20,7 @@
  */
 class InputParserPass implements CompilerPassInterface
 {
-    public const INPUT_PARSER_SERVICE_TAG = 'ibexa.rest.input.parser';
+    public const string INPUT_PARSER_SERVICE_TAG = 'ibexa.rest.input.parser';
 
     public function process(ContainerBuilder $container): void
     {

src/bundle/DependencyInjection/Compiler/InputParserPass.php

@@ -22,7 +22,7 @@
  */
 class OutputVisitorPass implements CompilerPassInterface
 {
-    public const OUTPUT_VISITOR_SERVICE_TAG = 'ibexa.rest.output.visitor';
+    public const string OUTPUT_VISITOR_SERVICE_TAG = 'ibexa.rest.output.visitor';
 
     public function process(ContainerBuilder $container): void
     {

src/bundle/DependencyInjection/Compiler/OutputVisitorPass.php

@@ -27,7 +27,7 @@
  */
 class IbexaRestExtension extends ConfigurableExtension implements PrependExtensionInterface
 {
-    public const EXTENSION_NAME = 'ibexa_rest';
+    public const string EXTENSION_NAME = 'ibexa_rest';
 
     public function getAlias(): string
     {

src/bundle/DependencyInjection/IbexaRestExtension.php

@@ -12,5 +12,5 @@ final class RestEvents
     /**
      * The REST_CSRF_TOKEN_VALIDATED event occurs after CSRF token has been validated as correct.
      */
-    public const REST_CSRF_TOKEN_VALIDATED = 'ezpublish.rest.csrf_token_validated';
+    public const string REST_CSRF_TOKEN_VALIDATED = 'ezpublish.rest.csrf_token_validated';
 }

src/bundle/RestEvents.php

@@ -33,13 +33,8 @@ public function mapRoute(Route $route): Route
 
     /**
      * Merges the methods from $restRoute into the _method default of $optionsRoute.
-     *
-     * @param \Symfony\Component\Routing\Route $restRoute
-     * @param \Symfony\Component\Routing\Route $optionsRoute
-     *
-     * @return \Symfony\Component\Routing\Route $optionsRoute with the methods from $restRoute in the _methods default
      */
-    public function mergeMethodsDefault(Route $optionsRoute, Route $restRoute)
+    public function mergeMethodsDefault(Route $optionsRoute, Route $restRoute): Route
     {
         $mergedRoute = clone $optionsRoute;
         $mergedRoute->setDefault(