PHPStan

Author: barw4

src/bundle/ApiPlatform/Head.php

@@ -17,6 +17,19 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 final class Head extends HttpOperation
 {
+    /**
+     * @param array<string, mixed>|null $defaults
+     * @param array<string, mixed>|null $denormalizationContext
+     * @param array<string, mixed>|null $exceptionToStatus
+     * @param array<string, mixed> $extraProperties
+     * @param array<string, mixed>|null $hydraContext
+     * @param array<string, mixed>|null $mercure
+     * @param array<string, mixed>|null $normalizationContext
+     * @param array<string, mixed>|null $options
+     * @param array<string, mixed>|null $requirements
+     * @param array<string, mixed>|null $schemes
+     * @param array<string, mixed>|null $validationContext
+     */
     public function __construct(
         ?string $uriTemplate = null,
         ?array $types = null,

src/lib/Server/Controller/Section/SectionUpdateController.php

@@ -12,6 +12,7 @@
 use ApiPlatform\OpenApi\Model;
 use Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentException;
 use Ibexa\Contracts\Core\Repository\SectionService;
+use Ibexa\Contracts\Core\Repository\Values\Content\Section;
 use Ibexa\Contracts\Core\Repository\Values\Content\SectionCreateStruct;
 use Ibexa\Contracts\Core\Repository\Values\Content\SectionUpdateStruct;
 use Ibexa\Rest\Message;
@@ -127,13 +128,9 @@ public function __construct(SectionService $sectionService)
     /**
      * Updates a section.
      *
-     * @param $sectionId
-     *
      * @throws \Ibexa\Rest\Server\Exceptions\ForbiddenException
-     *
-     * @return \Ibexa\Contracts\Core\Repository\Values\Content\Section
      */
-    public function updateSection($sectionId, Request $request)
+    public function updateSection(int $sectionId, Request $request): Section
     {
         $createStruct = $this->inputDispatcher->parse(
             new Message(

src/lib/Server/Controller/Session/SessionCheckController.php

@@ -77,7 +77,7 @@ final class SessionCheckController extends SessionBaseController
     public function checkSessionAction(Request $request)
     {
         $session = $request->getSession();
-        if ($session === null || !$session->isStarted()) {
+        if (!$session->isStarted()) {
             return $this->logout($request);
         }
 

src/lib/Server/Controller/Session/SessionRefreshController.php

@@ -96,8 +96,8 @@ final class SessionRefreshController extends SessionBaseController
      *
      * @deprecated 5.0.0 The "SessionController::refreshSessionAction()" method is deprecated, will be removed in the next API version. Use SessionController::checkSessionAction() instead.
      *
-     * @throws \Ibexa\Core\Base\Exceptions\UnauthorizedException
      * @throws \Ibexa\Contracts\Core\Repository\Exceptions\NotFoundException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\UnauthorizedException
      */
     public function refreshSessionAction(string $sessionId, Request $request): Values\UserSession|Response
     {
@@ -109,7 +109,7 @@ public function refreshSessionAction(string $sessionId, Request $request): Value
 
         $session = $request->getSession();
 
-        if ($session === null || !$session->isStarted() || $session->getId() !== $sessionId || !$this->hasStoredCsrfToken()) {
+        if (!$session->isStarted() || $session->getId() !== $sessionId || !$this->hasStoredCsrfToken()) {
             return $this->logout($request);
         }
 

src/lib/Server/Controller/Trash/TrashItemDeleteController.php

@@ -56,12 +56,8 @@ public function __construct(
 
     /**
      * Deletes the given trash item.
-     *
-     * @param $trashItemId
-     *
-     * @return \Ibexa\Rest\Server\Values\NoContent
      */
-    public function deleteTrashItem($trashItemId)
+    public function deleteTrashItem(int $trashItemId): Values\NoContent
     {
         $this->trashService->deleteTrashItem(
             $this->trashService->loadTrashItem($trashItemId)

src/lib/Server/Controller/Trash/TrashItemLoadByIdController.php

@@ -78,12 +78,8 @@ public function __construct(
 
     /**
      * Returns the trash item given by id.
-     *
-     * @param $trashItemId
-     *
-     * @return \Ibexa\Rest\Server\Values\RestTrashItem
      */
-    public function loadTrashItem($trashItemId)
+    public function loadTrashItem(int $trashItemId): Values\RestTrashItem
     {
         return new Values\RestTrashItem(
             $trashItem = $this->trashService->loadTrashItem($trashItemId),

src/lib/Server/Controller/Trash/TrashItemRestoreController.php

@@ -30,13 +30,11 @@ public function __construct(
     /**
      * Restores a trashItem.
      *
-     * @param $trashItemId
-     *
-     * @return \Ibexa\Rest\Server\Values\ResourceCreated
-     *
-     * @throws \Ibexa\Rest\Server\Exceptions\ForbiddenException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\UnauthorizedException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\NotFoundException
+     * @throws \InvalidArgumentException
      */
-    public function restoreTrashItem($trashItemId, Request $request)
+    public function restoreTrashItem(int $trashItemId, Request $request): Values\ResourceCreated
     {
         $requestDestination = null;
         try {
@@ -49,11 +47,11 @@ public function restoreTrashItem($trashItemId, Request $request)
         if ($request->headers->has('Destination')) {
             $locationPathParts = explode(
                 '/',
-                $this->requestParser->parseHref($request->headers->get('Destination'), 'locationPath')
+                $this->uriParser->getAttributeFromUri((string)$request->headers->get('Destination'), 'locationPath')
             );
 
             try {
-                $parentLocation = $this->locationService->loadLocation(array_pop($locationPathParts));
+                $parentLocation = $this->locationService->loadLocation((int)array_pop($locationPathParts));
             } catch (NotFoundException $e) {
                 throw new ForbiddenException(/** @Ignore */ $e->getMessage());
             }

src/lib/Server/Controller/URLAlias/URLAliasCreateController.php

@@ -123,11 +123,11 @@ public function createURLAlias(Request $request)
         if ($urlAliasCreate['_type'] === 'LOCATION') {
             $locationPathParts = explode(
                 '/',
-                $this->requestParser->parseHref($urlAliasCreate['location']['_href'], 'locationPath')
+                $this->uriParser->getAttributeFromUri($urlAliasCreate['location']['_href'], 'locationPath')
             );
 
             $location = $this->locationService->loadLocation(
-                array_pop($locationPathParts)
+                (int)array_pop($locationPathParts)
             );
 
             try {

src/lib/Server/Controller/URLAlias/URLAliasDeleteController.php

@@ -56,12 +56,8 @@ public function __construct(
 
     /**
      * The given URL alias is deleted.
-     *
-     * @param $urlAliasId
-     *
-     * @return \Ibexa\Rest\Server\Values\NoContent
      */
-    public function deleteURLAlias($urlAliasId)
+    public function deleteURLAlias(string $urlAliasId): Values\NoContent
     {
         $this->urlAliasService->removeAliases(
             [

src/lib/Server/Controller/URLAlias/URLAliasListGlobalController.php

@@ -68,13 +68,16 @@ public function __construct(
 
     /**
      * Returns the list of global URL aliases.
-     *
-     * @return \Ibexa\Rest\Server\Values\URLAliasRefList
      */
-    public function listGlobalURLAliases()
+    public function listGlobalURLAliases(): Values\URLAliasRefList
     {
+        $globalAliasesArray = [];
+        foreach ($this->urlAliasService->listGlobalAliases() as $alias) {
+            $globalAliasesArray[] = $alias;
+        }
+
         return new Values\URLAliasRefList(
-            $this->urlAliasService->listGlobalAliases(),
+            $globalAliasesArray,
             $this->router->generate('ibexa.rest.list_global_url_aliases')
         );
     }