IBX-1489: Missing PHP8 test jobs (#90)

Author: Konrad Oboza

.github/workflows/ci.yaml

@@ -14,7 +14,7 @@ jobs:
         strategy:
             matrix:
                 php:
-                    - '7.4'
+                    - '8.0'
         steps:
             - uses: actions/checkout@v2
 
@@ -44,6 +44,8 @@ jobs:
                 php:
                     - '7.3'
                     - '7.4'
+                    - '8.0'
+                    - '8.1'
 
         steps:
             - uses: actions/checkout@v2

composer.json

@@ -52,6 +52,11 @@
         "symfony/http-client": "^5.3",
         "symfony/browser-kit": "^5.3"
     },
+    "config": {
+        "allow-plugins": {
+            "composer/package-versions-deprecated": true
+        }
+    },
     "scripts": {
         "fix-cs": "php-cs-fixer fix -v --show-progress=estimating",
         "check-cs": "@fix-cs --dry-run",

src/lib/Output/Generator/Xml.php

@@ -173,7 +173,7 @@ public function startValueElement($name, $value, $attributes = [])
             $this->xmlWriter->endAttribute();
         }
 
-        $this->xmlWriter->text($value);
+        $this->xmlWriter->text((string)$value);
     }
 
     /**
@@ -219,7 +219,7 @@ public function startAttribute($name, $value)
         $this->checkStartAttribute($name);
 
         $this->xmlWriter->startAttribute($name);
-        $this->xmlWriter->text($value);
+        $this->xmlWriter->text((string)$value);
     }
 
     /**

src/lib/Server/Input/Parser/FacetBuilder/FieldParser.php

@@ -42,7 +42,7 @@ public function parse(array $data, ParsingDispatcher $parsingDispatcher)
         if (isset($data['Field']['sort'])) {
             $type = $data['Field']['sort'];
 
-            if (!in_array($type, $sortType)) {
+            if (!array_key_exists($type, $sortType)) {
                 throw new Exceptions\Parser('<Field> unknown sort type (supported: ' . implode(', ', array_keys($sortType)) . ')');
             }
 

tests/lib/FieldTypeProcessor/BinaryInputProcessorTest.php

@@ -17,7 +17,7 @@ public function tearDown(): void
         $iterator = new \RecursiveIteratorIterator(
             new \RecursiveDirectoryIterator(
                 $this->getTempDir(),
-                \FileSystemIterator::KEY_AS_PATHNAME | \FileSystemIterator::SKIP_DOTS | \ FilesystemIterator::CURRENT_AS_FILEINFO
+                \FileSystemIterator::KEY_AS_PATHNAME | \FileSystemIterator::SKIP_DOTS | \FilesystemIterator::CURRENT_AS_FILEINFO
             ),
             \RecursiveIteratorIterator::CHILD_FIRST
         );

tests/lib/Server/Input/Parser/FacetBuilder/FacetBuilderParserTest.php

@@ -19,7 +19,7 @@
 
 class FacetBuilderParserTest extends FacetBuilderBaseTest
 {
-    public function testGenericFacetBuilder()
+    public function testGenericFacetBuilder(): void
     {
         $inputArray = [
             'Filter' => [],
@@ -53,7 +53,7 @@ public function testGenericFacetBuilder()
         $this->assertEquals($expectedQuery, $result);
     }
 
-    public function testQueryContentTypeFacetBuilder()
+    public function testQueryContentTypeFacetBuilder(): void
     {
         $inputArray = [
             'Filter' => [],
@@ -75,7 +75,7 @@ public function testQueryContentTypeFacetBuilder()
         $this->assertEquals($expectedQuery, $result);
     }
 
-    public function testQueryCriterionFacetBuilder()
+    public function testQueryCriterionFacetBuilder(): void
     {
         $inputArray = [
             'Filter' => [],
@@ -101,7 +101,7 @@ public function testQueryCriterionFacetBuilder()
         $this->assertEquals($expectedQuery, $result);
     }
 
-    public function testQueryFieldFacetBuilder()
+    public function testQueryFieldFacetBuilder(): void
     {
         $inputArray = [
             'Filter' => [],
@@ -135,7 +135,7 @@ public function testQueryFieldFacetBuilder()
         $this->assertEquals($expectedQuery, $result);
     }
 
-    public function testQueryLocationFacetBuilder()
+    public function testQueryLocationFacetBuilder(): void
     {
         $inputArray = [
             'Filter' => [],
@@ -161,7 +161,7 @@ public function testQueryLocationFacetBuilder()
         $this->assertEquals($expectedQuery, $result);
     }
 
-    public function testQuerySectionFacetBuilder()
+    public function testQuerySectionFacetBuilder(): void
     {
         $inputArray = [
             'Filter' => [],
@@ -183,7 +183,7 @@ public function testQuerySectionFacetBuilder()
         $this->assertEquals($expectedQuery, $result);
     }
 
-    public function testQueryTermFacetBuilder()
+    public function testQueryTermFacetBuilder(): void
     {
         $inputArray = [
             'Filter' => [],
@@ -205,7 +205,7 @@ public function testQueryTermFacetBuilder()
         $this->assertEquals($expectedQuery, $result);
     }
 
-    public function testQueryUserFacetBuilder()
+    public function testQueryUserFacetBuilder(): void
     {
         $inputArray = [
             'Filter' => [],
@@ -231,7 +231,7 @@ public function testQueryUserFacetBuilder()
         $this->assertEquals($expectedQuery, $result);
     }
 
-    public function testQueryNoFacetBuilders()
+    public function testQueryNoFacetBuilders(): void
     {
         $inputArray = [
             'Filter' => [],
@@ -249,7 +249,7 @@ public function testQueryNoFacetBuilders()
         $this->assertEquals($expectedQuery, $result);
     }
 
-    public function testQueryMultipleFacetBuilders()
+    public function testQueryMultipleFacetBuilders(): void
     {
         $inputArray = [
             'Filter' => [],