fix(undotree): use tmpname for tmp undo file (#2464)

Author: ibhagwan

lua/fzf-lua/fzf.lua

@@ -11,26 +11,6 @@ local libuv = require "fzf-lua.libuv"
 
 local M = {}
 
--- workaround to a potential 'tempname' bug? (#222)
--- neovim doesn't guarantee the existence of the
--- parent temp dir potentially failing `mkfifo`
--- https://github.com/neovim/neovim/issues/1432
--- https://github.com/neovim/neovim/pull/11284
-local function tempname()
-  local tmpname = vim.fn.tempname()
-  local parent = vim.fn.fnamemodify(tmpname, ":h")
-  -- parent must exist for `mkfifo` to succeed
-  -- if the neovim temp dir was deleted or the
-  -- tempname already exists, we use 'os.tmpname'
-  if not uv.fs_stat(parent) or uv.fs_stat(tmpname) then
-    tmpname = os.tmpname()
-    -- 'os.tmpname' touches the file which
-    -- will also fail `mkfifo`, delete it
-    vim.fn.delete(tmpname)
-  end
-  return tmpname
-end
-
 -- contents can be either a table with tostring()able items, or a function that
 -- can be called repeatedly for values. The latter can use coroutines for async
 -- behavior.
@@ -48,7 +28,7 @@ function M.raw_fzf(contents, fzf_cli_args, opts)
 
   if not opts then opts = {} end
   local cmd = { opts.fzf_bin or "fzf" }
-  local outputtmpname = tempname()
+  local outputtmpname = utils.tempname()
 
   -- we use a temporary env $FZF_DEFAULT_COMMAND instead of piping
   -- the command to fzf, this way fzf kills the command when it exits.

lua/fzf-lua/providers/undotree.lua

@@ -203,7 +203,7 @@ local function load_undo_buf(buf)
   end
   info.buf = buf
   info.changedtick = changedtick
-  info.tmp_file = path.join({ vim.fn.stdpath("cache") --[[@as string]], "fzf-lua-undo" })
+  info.tmp_file = path.join({ path.parent(utils.tempname()), "fzf-lua-undo" })
   info.tmp_undo = info.tmp_file .. ".undo"
   info.tmp_buf = vim.fn.bufadd(info.tmp_file)
   vim.bo[info.tmp_buf].swapfile = false

lua/fzf-lua/utils.lua

@@ -1561,6 +1561,27 @@ function M.termopen(cmd, opts)
   end
 end
 
+--- workaround to a potential 'tempname' bug? (#222)
+--- neovim doesn't guarantee the existence of the
+--- parent temp dir potentially failing `mkfifo`
+--- https://github.com/neovim/neovim/issues/1432
+--- https://github.com/neovim/neovim/pull/11284
+--- @return string
+function M.tempname()
+  local tmpname = vim.fn.tempname()
+  local parent = vim.fn.fnamemodify(tmpname, ":h")
+  -- parent must exist for `mkfifo` to succeed
+  -- if the neovim temp dir was deleted or the
+  -- tempname already exists, we use 'os.tmpname'
+  if not uv.fs_stat(parent) or uv.fs_stat(tmpname) then
+    tmpname = os.tmpname()
+    -- 'os.tmpname' touches the file which
+    -- will also fail `mkfifo`, delete it
+    vim.fn.delete(tmpname)
+  end
+  return tmpname
+end
+
 ---@param cmd string
 ---@param flag string
 ---@param enabled boolean?