Question regarding new modifiers for terminal in 0.10

[asmodeus812]

Hi @ibhagwan with the arival of 0.10, and the new support for modifiers to :terminal, such as support for :botright terminal, how would that affect the split option should we want to use this instead of using the current behaviour i.e. :botright new which splits, the current window / buffer and then i suppose fzf lua takes over loads/opens a termjob inside of that split instead.

[ibhagwan]

Hi @asmodeus812, I don't see any reason to use botright terminal , fzf-lua needs an empty buffer to work in so it can then run termopen inside it:

fzf-lua/lua/fzf-lua/fzf.lua

Line 249 in 213da0b

local jobstart = opts.is_fzf_tmux and vim.fn.jobstart or vim.fn.termopen

fzf-lua/lua/fzf-lua/fzf.lua

Line 262 in 213da0b

jobstart(shell_cmd, {

Opening a terminal window instead of a plain buffer has no advantage over botright new, in fact it might even fail termopen if I recall correctly.

[asmodeus812]

Sorry forgot about that one, yes indeed fzf lua is using termopen then it needs an empty unmodified buffer, we cant use :termianl. That seems to resolve my question. Thanks