Idea/feature request to expose cursor position in actions' opts

[nguyenvukhang]

I would like to have an action where after I type my grep query, upon pressing enter, all the entries that are still shown goes to the quickfix list and I jump to the location that my cursor was on.

  ['enter'] = {
    fn = function(selected, opts)
      opts.copen = false
      actions.file_sel_to_qf(selected, opts)
      actions.file_edit({ selected[1] }, opts)
      -- actions.file_edit({ selected[opts.__FZF_POS + 1] }, opts)
    end,
    prefix = 'select-all',
  }

This snippet gets me 90% of the way there, except that it jumps to the first entry, not the selected entry. Currently, to the best of my knowledge, there is no exposed API to obtain the last selected line (FZF_POS of sorts), from selected and opts. My current solution is to fork with this diff:

diff --git a/lua/fzf-lua/shell.lua b/lua/fzf-lua/shell.lua
index 5e058be..bf989b0 100644
--- a/lua/fzf-lua/shell.lua
+++ b/lua/fzf-lua/shell.lua
@@ -500,13 +500,14 @@ M.stringify_data2 = function(fn, opts, field_index)
     -- fix side effect of "{q} {+}": {+} is forced expanded to ""
     -- only when field_index is empty (otherwise it can be complex/unpredictable)
     -- {n} used to determine if "zero-selected && zero-match", then patch: "" -> nil
+    opts.__FZF_POS = tonumber(idx)
     if field_index == "{+} {q} {n}" then
       -- When no item is matching (empty list or non-matching query)
       -- both {n} and {+} are expanded to "".
       -- NOTE1: older versions of fzf don't expand {n} to "" (without match)
       -- in such case the (empty) items table will be in `items[2]` (#1833)
       -- NOTE2: on Windows, no match {n} is expanded to '' (#1836)
       local zero_matched = not tonumber(idx)
       local zero_selected = #items == 0 or (#items == 1 and #items[1] == 0)
       items = (zero_matched and zero_selected) and {} or items
     end

And I was wondering if this is useful enough to consider (after tidying up to a suitable location) merging to master or if there's a more idiomatic way to go about doing this. Thanks!

Edit Here's my eventual solution for this, one that doesn't involve an extra file io:

  ['enter'] = {
    fn = function(selection, opts)
      local fzf_pos = tonumber(table.remove(selection, #selection))
      opts.copen = false
      actions.file_sel_to_qf(selection, opts)
      actions.file_edit({ selection[fzf_pos] }, opts)
    end,
    prefix = 'select-all',
    field_index = '{+} $FZF_POS',
  }

[nenahp]

{+f} is just used to overcome the cmd len limit.

          ['enter'] = {
            fn = function(s, o)
              local e = vim.split(io.open(s[1], 'r'):read("*a"), o.fzf_opts['--read0'] and '\0' or '\n')
              local fzf_pos = tonumber(s[2])
              e[#e] = nil
              o.copen = false
              fa.file_sel_to_qf(e, o)
              fa.file_edit({e[fzf_pos]}, o)
            end,
            prefix = 'select-all',
            field_index = "{+f} $FZF_POS",
          },

[nenahp]

no it's hand written and tested
not sure if +f exist in doc but i reuse it in my config, u can replace any field you want, if this dont work for u

[nguyenvukhang]

Okay. What does this line do exactly?

local e = vim.split(io.open(s[1], 'r'):read("*a"), o.fzf_opts['--read0'] and '\0' or '\n')

It looks like it's reading the contents of the first of the selected entries, but may I ask why?

[nenahp]

iirc +f just pipe all selected into a temperary file
field_index will be "s" variable if u custom field_index

[nguyenvukhang]

I see

[ibhagwan]

iirc +f just pipe all selected into a temperary file field_index will be "s" variable if u custom field_index

Brilliant @nenahp, always pushing the envelope in creative ways