Is resume impacted by the reflow issue?

[MeanderingProgrammer]

Hi there, thanks for all the hard work on this plugin!

I noticed a little while ago that when I run require('fzf-lua').resume() I get a shift in the rendered list. Like the last line will disappear and the items will shift upwards. I assumed that was due to the same issue as #1929, and left it there, but after reading through it again I really can't tell. I found some similar issues but with a few differences.

• Bug: one result is duplicated after resume while hide profile is on #2019: The "duplicates" are selectable and get "fixed" when I move the cursor over them
• Bug: Prompt shift when using hide profile #2025: I'm using the layout where the prompt is at the top, this could definitely be the same issue, just a different impact based on where the prompt is

I experience no issues at any other time, it's only when I resume some search. Just wondering if anyone else is experiencing this, if this is a known problem, or if I've got some other weird thing going on.

Example

I can trigger it consistently but that's in my specific environment.

1. go to some folder and open neovim
2. trigger the file picker
3. type something

4. close fzf with <esc>
5. trigger resume
6. start scrolling down

Note

the shift happens as soon as I trigger resume, for some reason the 4th item limitations.md disappears, everything below it gets shifted up, and the last line becomes empty

7. scroll down one more

Note

when I scroll over the 4th item it changes from latex_spec.lua back to limitations.md, the one that disappeared

scrolling down further fixes the other file names one at a time

Config

local fzf = require('fzf-lua')
local actions = require('fzf-lua.actions')

---@type string[]
local rg = {
    '--column',
    '--line-number',
    '--no-heading',
    '--color=always',
    '--smart-case',
    '--max-columns=4096',
    '--hidden',
    '-e',
}

fzf.setup({
    actions = {
        files = {
            ['enter'] = actions.file_switch_or_edit,
            ['ctrl-v'] = actions.file_vsplit,
            ['ctrl-x'] = actions.file_split,
            ['ctrl-t'] = actions.file_tabedit,
            ['ctrl-q'] = {
                fn = actions.file_sel_to_qf,
                prefix = 'select-all',
            },
        },
    },
    fzf_opts = {
        ['--cycle'] = true,
    },
    defaults = {
        file_icons = 'mini',
        formatter = 'path.filename_first',
    },
    grep = {
        rg_opts = table.concat(rg, ' '),
    },
    lsp = {
        jump1 = false,
        includeDeclaration = false,
    },
})

[MeanderingProgrammer]

I have no idea why yet, but commenting out this single line of code seems to resolve the problem for me: https://github.com/ibhagwan/fzf-lua/blob/main/lua/fzf-lua/win.lua#L782

vim.bo[self.backdrop_buf].filetype = "fzflua_backdrop"

[MeanderingProgrammer]

The issue actually stems from indent-blankline.nvim, disabling that plugin solves the issue for me, clearly something is going on there, I guess it makes sense that it would cause a reflow. Sorry for the the noise!

It seems to be a combination of plugins that lead to this, more likely it is just related to timing, but will dig into it more.

[ibhagwan]

Ty @MeanderingProgrammer for the detailed report and analysis.

when I scroll over the 4th item it changes from latex_spec.lua back to limitations.md, the one that disappeared
scrolling down further fixes the other file names one at a time

This makes me suspect it’s the reflow issue in #1929, once you’re in the fzf terminal window fzf-lua has very little control on the scrolling / rendering so this can only be an upstream issue (fzf / neovim or combination of both?).

I have no idea why yet, but commenting out this single line of code seems to resolve the problem for me:
It seems to be a combination of plugins that lead to this, more likely it is just related to timing, but will dig into it more.

You can try to disable the backdrop by setting winopts.backdrop=100 but this being a terminal rendering issue makes me suspect it’s #1929.

[MeanderingProgrammer]

once you’re in the fzf terminal window fzf-lua has very little control on the scrolling / rendering

Makes sense

You can try to disable the backdrop by setting winopts.backdrop=100

Ah that probably also would have done the trick. I'm still not sure how autocommands for one buffer effect the reflow of a different buffer, it's probably just an odd coincidence.

I'm curious do you notice any difference with the change in #2458?

[ibhagwan]

I'm curious do you notice any difference with the change in #2458?

Not that I’m aware.