Skip to content

Commit 9a5ecfc

Browse files
committed
test(polars): enable now xpassing tests
1 parent a670fda commit 9a5ecfc

File tree

5 files changed

+145
-157
lines changed

5 files changed

+145
-157
lines changed

flake.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ibis/backends/tests/test_dot_sql.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
ExaQueryError,
1818
GoogleBadRequest,
1919
OracleDatabaseError,
20-
PolarsSQLInterfaceError,
2120
PyAthenaOperationalError,
2221
PyODBCProgrammingError,
2322
)
@@ -135,11 +134,6 @@ def test_table_dot_sql(backend):
135134
OracleDatabaseError,
136135
reason="oracle doesn't know which of the tables in the join to sort from",
137136
)
138-
@pytest.mark.xfail_version(
139-
polars=["polars>=1.27"],
140-
raises=PolarsSQLInterfaceError,
141-
reason="broken upstream in polars",
142-
)
143137
def test_table_dot_sql_with_join(backend):
144138
alltypes = backend.functional_alltypes
145139
t = (

ibis/backends/tests/test_temporal.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
MySQLProgrammingError,
2929
OracleDatabaseError,
3030
PolarsInvalidOperationError,
31-
PolarsPanicException,
3231
PsycoPg2InternalError,
3332
Py4JJavaError,
3433
PyAthenaOperationalError,
@@ -380,11 +379,6 @@ def test_timestamp_extract_week_of_year(backend, alltypes, df):
380379
],
381380
raises=com.UnsupportedOperationError,
382381
),
383-
pytest.mark.notimpl(
384-
["polars"],
385-
raises=PolarsPanicException,
386-
reason="attempt to calculate the remainder with a divisor of zero",
387-
),
388382
pytest.mark.notyet(
389383
["flink"],
390384
raises=Py4JJavaError,

requirements-dev.txt

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)