You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have been trying to improve the type annotations of ibis over the last year, because I value the hints my IDE gives me when I'm doing something stupid. But I wanted to get a feel for other's opinions here.
First, I just want to caveat: We don't have any type checker set up, and if we did it would have so many spurious errors it would be useless, so at this point we are judging all the following criteria on a best-effort basis, since we can't enforce any of them with CI.
I think my proposal for an official stance is
Ibis has a best-effort stance on type annotations. If you use a typechecker with your ibis code, you are going to get errors. We will try to reduce the number of these, but it is not our goal to eliminate type errors entirely.
All PRs MUST NOT worsen type coverage
New features MUST have type annotations on all public APIs.
New features weakly SHOULD (I'm fine weakening this to a COULD if you give pushback) have type annotations on internal APIs when they really would benefit from them.
Refactors COULD improve type annotations, but no expectation.
We use ty as our official implementation in case of conflicts between type checkers.
Any thoughts on this proposal? Additional stances we could take?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I have been trying to improve the type annotations of ibis over the last year, because I value the hints my IDE gives me when I'm doing something stupid. But I wanted to get a feel for other's opinions here.
First, I just want to caveat: We don't have any type checker set up, and if we did it would have so many spurious errors it would be useless, so at this point we are judging all the following criteria on a best-effort basis, since we can't enforce any of them with CI.
I think my proposal for an official stance is
Any thoughts on this proposal? Additional stances we could take?
Beta Was this translation helpful? Give feedback.
All reactions