bug fix for repl's handling of implicit arguments

Fixes #947

Author: starpit

app/content/js/repl.js

@@ -851,7 +851,8 @@ self.exec = (commandUntrimmed, execOptions) => {
                       nRequiredArgs = required.length + (oneof.length > 0 ? 1 : 0) - nPositionalsConsumed,
                       optLikeActuals = optLikeOneOfs.filter(({name, alias=''}) => parsedOptions.hasOwnProperty(unflag(name)) || parsedOptions.hasOwnProperty(unflag(alias))),
                       nOptLikeActuals = optLikeActuals.length,
-                      nActualArgs = args.length - args.indexOf(cmd) - 1 + nOptLikeActuals
+                      cmdArgsStart = args.indexOf(cmd),
+                      nActualArgs = args.length - cmdArgsStart - 1 + nOptLikeActuals
 
                 // did the user pass an unsupported optional parameter?
                 for (let optionalArg in parsedOptions) {
@@ -946,8 +947,8 @@ self.exec = (commandUntrimmed, execOptions) => {
 
                         } else {
                             // ooh, then splice in the implicit parameter
-                            args.splice(implicitIdx, 0, `/${selection.namespace}/${selection.name}`)
-                            debug('spliced in implicit argument', implicitIdx, args[implicitIdx])
+                            args.splice(implicitIdx, cmdArgsStart + 1, selection.namespace ? `/${selection.namespace}/${selection.name}` : selection.name)
+                            debug('spliced in implicit argument', cmdArgsStart, implicitIdx, args)
                         }
                     }
                 }

tests/tests/passes/07/composer-viz.js

@@ -131,7 +131,7 @@ describe('show the composer visualization without creating openwhisk assets', fu
 
     /** test: viz, then create with no args, testing for handling of implicit entity */
     it(`should create with implicit entity`, () => cli.do('app create', this.app)
-       .then(verifyTheBasicStuff(seq.file.replace(/\.[^\.]*/,''), 'composerLib'))   // the .replace part strips off the ".js" suffix
+       .then(verifyTheBasicStuff(seq.file, 'composerLib'))
        .then(verifyNodeExists('seq1', false)) // not deployed
        .then(verifyNodeExists('seq2', false)) // not deployed
        .then(verifyNodeExists('seq3', false)) // not deployed
@@ -158,7 +158,7 @@ describe('show the composer visualization without creating openwhisk assets', fu
 
     /** test: viz, then create with -r, testing for handling of implicit entity and auto-deploy */
     it(`should create wookiechat and dependent actions with implicit entity`, () => cli.do('app update -r', this.app)
-       .then(verifyTheBasicStuff('app', 'composerLib'))   // the .replace part strips off the ".js" suffix
+       .then(verifyTheBasicStuff('app.js', 'composerLib'))
        .then(verifyNodeExists('swapi', true)) // expect to be deployed
        .then(verifyNodeExists('stapi', true)) // expect to be deployed
        .then(verifyNodeExists('validate-swapi', true)) // expect to be deployed