fixes for headless commands with "args with spaces"

Fixes #954

Author: starpit

app/bin/fsh

@@ -24,4 +24,4 @@ ROOTDIR="$DIR/.."
 # determine which argv to ignore
 export DEVMODE=true
 
-exec "$ROOTDIR/node_modules/.bin/electron" "$ROOTDIR" --fsh-headless $@
+exec "$ROOTDIR/node_modules/.bin/electron" "$ROOTDIR" --fsh-headless "$@"

app/headless.js

@@ -636,7 +636,7 @@ const main = (app, mainFunctions) => {
         //
         // execute a single command from the CLI
         //
-        const cmd = argv.join(' ').trim()
+        const cmd = argv.map(_ => _.match(/\s+/) ? `"${_}"` : _).join(' ').trim()
         if (cmd && cmd.length > 0) {
             debug('about to execute command')
             return Promise.resolve().then(() => eval(cmd)).catch(maybeRetry)

tests/tests/passes/02/headless.js

@@ -133,4 +133,13 @@ describe('Headless mode', function() {
     it('should create an action with an env var parameter', () => cli.do('action create envfun ./data/echo.js -p fun $FUN', { FUN: 3 })
        .then(cli.expectOK('ok: updated action envfun\n', { exact: true }))
        .catch(common.oops(this)))
+
+    it('should create an action with params-with-spaces', () => cli.do('action create spacey ./data/echo.js -p fun "space cadet"')
+       .then(cli.expectOK('ok: updated action spacey\n', { exact: true }))
+       .catch(common.oops(this)))
+
+    it('should invoke spacey', () => cli.do('action invoke spacey')
+       .then(cli.expectOK('fun: "space cadet"'))
+       .catch(common.oops(this)))
+
 })