Skip to content

Commit 445440b

Browse files
author
Sebastien Pereira
committed
Remove clickhandler hack for Android 4.1.1. fixes #18. Supported Android now starts from 4.1.2 (Ref #31).
1 parent 5e9c80a commit 445440b

File tree

1 file changed

+0
-35
lines changed

1 file changed

+0
-35
lines changed

events.js

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ define([
3535
}
3636
}
3737
}
38-
registerClickHandler();
3938
this._targetElement = targetElement;
4039
};
4140

@@ -47,7 +46,6 @@ define([
4746
touch.deregisterHandlers(this._targetElement);
4847
mouse.deregisterHandlers(this._targetElement);
4948
mspointer && mspointer.deregisterHandlers(this._targetElement);
50-
deregisterClickHandler();
5149
}
5250
this._targetElement = null;
5351
};
@@ -153,39 +151,6 @@ define([
153151
}
154152
}
155153

156-
/**
157-
* register click handler.
158-
*/
159-
function registerClickHandler() {
160-
utils.addEventListener(window.document, "click", clickHandler, true);
161-
}
162-
163-
/**
164-
* deregister click handler
165-
*/
166-
function deregisterClickHandler() {
167-
utils.removeEventListener(window.document, "click", clickHandler, true);
168-
}
169-
170-
/**
171-
* handler for Click events.
172-
*
173-
* @param e click event
174-
*/
175-
function clickHandler(e) {
176-
if (has("touch-events")) {
177-
// (7) Android 4.1.1 generates a click after touchend even when touchstart is prevented.
178-
// if we receive a native click at an element with touch action disabled we just have to absorb it.
179-
// (fixed in Android 4.1.2+)
180-
if (utils.isNativeClickEvent(e) && (touch.determineTouchAction(e.target) !== utils.TouchAction.AUTO)) {
181-
e.preventDefault();
182-
e.stopImmediatePropagation();
183-
return false;
184-
}
185-
}
186-
return true;
187-
}
188-
189154
// start listening to native events
190155
pointerEvents.enable();
191156

0 commit comments

Comments
 (0)