This fix is to handle , When JMS header key comes as empty from MQ properties, the kafka connect pipeline is failing with NullpointerException while sinking the data to kafka . This scenario is handled in try block in the JmsToKafkaHeaderConverter class

Author: balajisekarraman

src/main/java/com/ibm/eventstreams/connect/mqsource/processor/JmsToKafkaHeaderConverter.java

@@ -48,7 +48,13 @@ public ConnectHeaders convertJmsPropertiesToKafkaHeaders(final Message message)
 
             jmsPropertyKeys.forEach(key -> {
                 try {
-                    connectHeaders.addString(key.toString(), message.getObjectProperty(key.toString()).toString());
+                    String value = "";
+                    if (message.getObjectProperty(key.toString()) != null)
+                    {
+                        value = message.getObjectProperty(key.toString()).toString();
+                    }
+                    connectHeaders.addString(key.toString(), value);
+                   //connectHeaders.addString(key.toString(), message.getObjectProperty(key.toString()).toString());
                 } catch (final JMSException e) {
                     // Not failing the message processing if JMS properties cannot be read for some
                     // reason.

src/test/java/com/ibm/eventstreams/connect/mqsource/JmsToKafkaHeaderConverterTest.java

@@ -44,22 +44,23 @@ public class JmsToKafkaHeaderConverterTest {
     @Test
     public void convertJmsPropertiesToKafkaHeaders() throws JMSException {
 
-        final List<String> keys = Arrays.asList("facilityCountryCode", "facilityNum");
+        final List<String> keys = Arrays.asList("facilityCountryCode", "facilityNum","nullProperty");
 
         final Enumeration<String> keyEnumeration = Collections.enumeration(keys);
 
         // Arrange
         when(message.getPropertyNames()).thenReturn(keyEnumeration);
         when(message.getObjectProperty("facilityCountryCode")).thenReturn("US");
         when(message.getObjectProperty("facilityNum")).thenReturn("12345");
+        when(message.getObjectProperty("nullProperty")).thenReturn(null);
 
         // Act
         final ConnectHeaders actualConnectHeaders = jmsToKafkaHeaderConverter
                 .convertJmsPropertiesToKafkaHeaders(message);
 
 
         //Verify
-        assertEquals("Both custom JMS properties were copied to kafka successfully.", 2, actualConnectHeaders.size());
+        assertEquals("Both custom JMS properties were copied to kafka successfully.", 3, actualConnectHeaders.size());
 
 
     }