Skip to content

Commit 281786a

Browse files
athira1693Athira Sreekumar
andauthored
fix: Updated Node packages to fix CVE-2023-45133 (#371)
* fix: Updated Node packages to fix CVEs Resolves: #368 Signed-off-by: Athira Sreekumar <[email protected]> * fix: Updated Node packages to fix CVEs Resolves: #368 Signed-off-by: Athira Sreekumar [email protected] --------- Signed-off-by: Athira Sreekumar <[email protected]> Signed-off-by: Athira Sreekumar [email protected] Co-authored-by: Athira Sreekumar <[email protected]>
1 parent ea6921d commit 281786a

File tree

9 files changed

+1316
-1246
lines changed

9 files changed

+1316
-1246
lines changed

.github/actions/bundle/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ COPY package-lock.json .
66

77
RUN npm install
88

9-
ENTRYPOINT ["node", "/index.js"];
9+
ENTRYPOINT ["node", "/index.js"]

.github/actions/commenter/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ COPY package-lock.json .
66

77
RUN npm install
88

9-
ENTRYPOINT ["node", "/index.js"];
9+
ENTRYPOINT ["node", "/index.js"]

.github/actions/coverage-report/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ COPY package-lock.json .
66

77
RUN npm install
88

9-
ENTRYPOINT ["node", "/index.js"];
9+
ENTRYPOINT ["node", "/index.js"]

.github/workflows/node-pr-jobs.yml

Lines changed: 17 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,17 @@ on:
77

88
jobs:
99
build:
10-
runs-on: ubuntu-latest
10+
runs-on: ubuntu-22.04
1111
name: Build and Test
1212
defaults:
1313
run:
1414
working-directory: ui
1515
steps:
16-
- uses: actions/checkout@v2
17-
- name: Use Node.js 12.x
18-
uses: actions/setup-node@v1
16+
- uses: actions/checkout@v3
17+
- name: Use Node.js 16.x
18+
uses: actions/setup-node@v3
1919
with:
20-
node-version: 12.x
20+
node-version: 16.x
2121
- name: Install Dependencies
2222
run: npm ci
2323
- name: Build
@@ -31,50 +31,44 @@ jobs:
3131
id: coverage
3232
if: ${{ always() }}
3333
uses: ./.github/actions/coverage-report
34-
- name: Comment on PR
35-
if: ${{ always() }}
36-
uses: ./.github/actions/commenter
37-
with:
38-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
39-
BUNDLE_SIZE: ${{ steps.bundle.outputs.bundle_size }}
40-
TEST_COVERAGE: ${{ steps.coverage.outputs.test_coverage }}
4134

4235
lint:
43-
runs-on: ubuntu-latest
36+
runs-on: ubuntu-22.04
4437
name: ESLint
4538
defaults:
4639
run:
4740
working-directory: ui
4841

4942
steps:
50-
- uses: actions/checkout@v2
51-
- name: Use Node.js 12.x
52-
uses: actions/setup-node@v1
43+
- uses: actions/checkout@v3
44+
- name: Use Node.js 16.x
45+
uses: actions/setup-node@v3
5346
with:
54-
node-version: 12.x
47+
node-version: 16.x
5548
- name: Install Dependencies
5649
run: npm ci
5750
- name: Code lint
5851
run: npm run lint
5952

6053
e2e-tests:
61-
runs-on: ubuntu-latest # or macos-latest, windows-latest
54+
runs-on: ubuntu-22.04 # or macos-latest, windows-latest
6255
defaults:
6356
run:
6457
working-directory: ui
6558
steps:
66-
- uses: actions/checkout@v2
59+
- uses: actions/checkout@v3
6760
- name: Increase file watcher limit
6861
run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
69-
- uses: actions/setup-node@v1
62+
- uses: actions/setup-node@v3
7063
with:
71-
node-version: 12.x
72-
- uses: microsoft/playwright-github-action@v1
64+
node-version: 16.x
7365
- name: Install dependencies
7466
run: npm ci
67+
- name: set up playwright environment
68+
run: npx playwright install
7569
- name: run tests
7670
run: npm run test:e2e
77-
- uses: actions/upload-artifact@v2
71+
- uses: actions/upload-artifact@v4
7872
if: failure()
7973
with:
8074
name: failures

MAINTAINERS.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# MAINTAINERS
22

3-
Kate Stanley - [email protected]
4-
Grace Jansen - [email protected]
3+
4+
Graeme McRobert - [email protected]
5+
Neeraj Laad - [email protected]

ui/.eslintrc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414
"sourceType": "module",
1515
"ecmaFeatures": {
1616
"jsx": true
17+
},
18+
"babelOptions": {
19+
"presets": ["@babel/preset-env", "@babel/preset-react"]
1720
}
1821
},
1922
"env": {
@@ -28,7 +31,7 @@
2831
},
2932
"import/resolver": "webpack"
3033
},
31-
"parser": "babel-eslint",
34+
"parser": "@babel/eslint-parser",
3235
"rules": {
3336
"prettier/prettier": "error",
3437
"strict": [2, "global"],

ui/e2e/features/step_definitions/producer.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ const stepDefs = (cucumber) => {
3232
'I set the payload to {string}',
3333
async (world, payload) => {
3434
await page.fill(getSelector('producer_value_input'), payload);
35+
await page.waitForTimeout(150);
3536
await page.waitForSelector(getSelector('producer_value_input'));
3637
}
3738
);

0 commit comments

Comments
 (0)