Adding missing tasks and updating to fix bug with ARM64 #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bimsara-yasitha01
requested changes
Nov 27, 2025
Contributor
bimsara-yasitha01
left a comment
bimsara-yasitha01
left a comment
There was a problem hiding this comment.
Very minor readability change, looks good!
Comment on lines
+67
to
+69
| when: | ||
| - item.files is defined and item.files | length > 0 and item.files.0.path is defined | ||
| - ansible_architecture == 'aarch64' |
Contributor
There was a problem hiding this comment.
Not sure if this changes the behaviour, but could the conditions be broken down further to make it more readable?
Very minor though - if this suggestion changes the logic don't worry about it! Otherwise looks great
Suggested change
| when: | |
| - item.files is defined and item.files | length > 0 and item.files.0.path is defined | |
| - ansible_architecture == 'aarch64' | |
| when: | |
| - item.files is defined | |
| - item.files | length > 0 | |
| - item.files.0.path is defined | |
| - ansible_architecture == 'aarch64' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.