Skip to content

Commit 0eacad5

Browse files
committed
Fix docker version check to do both major and minor checks at same time
1 parent bf4cdfc commit 0eacad5

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

Makefile

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
BASE_IMAGE ?= ubuntu:16.04
2121
# MQ_VERSION is the fully qualified MQ version number to build
2222
MQ_VERSION ?= 9.0.4.0
23-
# MQ_ARCHIVE is the name of the file, under the downloads directory, from which MQ Advanced can
23+
# MQ_ARCHIVE is the name of the file, under the downloads directory, from which MQ Advanced can
2424
# be installed. The default value is derived from MQ_VERSION, BASE_IMAGE and architecture
2525
# Does not apply to MQ Advanced for Developers.
2626
MQ_ARCHIVE ?= IBM_MQ_$(MQ_VERSION)_$(MQ_ARCHIVE_TYPE)_$(MQ_ARCHIVE_ARCH).tar.gz
@@ -190,7 +190,7 @@ define docker-build-mq
190190
--detach \
191191
nginx:alpine
192192
# Make sure we have the latest base image
193-
$(DOCKER) pull $(BASE_IMAGE)
193+
$(DOCKER) pull $(BASE_IMAGE)
194194
# Build the new image
195195
$(DOCKER) build \
196196
--tag $1 \
@@ -209,10 +209,8 @@ DOCKER_SERVER_VERSION=$(shell docker version --format "{{ .Server.Version }}")
209209
DOCKER_CLIENT_VERSION=$(shell docker version --format "{{ .Client.Version }}")
210210
.PHONY: docker-version
211211
docker-version:
212-
@test "$(word 1,$(subst ., ,$(DOCKER_CLIENT_VERSION)))" -ge "17" || (echo "Error: Docker client 17.05 or greater is required" && exit 1)
213-
@test "$(word 2,$(subst ., ,$(DOCKER_CLIENT_VERSION)))" -ge "05" || (echo "Error: Docker client 17.05 or greater is required" && exit 1)
214-
@test "$(word 1,$(subst ., ,$(DOCKER_SERVER_VERSION)))" -ge "17" || (echo "Error: Docker server 17.05 or greater is required" && exit 1)
215-
@test "$(word 2,$(subst ., ,$(DOCKER_SERVER_VERSION)))" -ge "05" || (echo "Error: Docker server 17.05 or greater is required" && exit 1)
212+
@test "$(word 1,$(subst ., ,$(DOCKER_CLIENT_VERSION)))" -ge "17" || ("$(word 1,$(subst ., ,$(DOCKER_CLIENT_VERSION)))" -eq "17" && "$(word 2,$(subst ., ,$(DOCKER_CLIENT_VERSION)))" -ge "05") || (echo "Error: Docker client 17.05 or greater is required" && exit 1)
213+
@test "$(word 1,$(subst ., ,$(DOCKER_SERVER_VERSION)))" -ge "17" || ("$(word 1,$(subst ., ,$(DOCKER_SERVER_VERSION)))" -eq "17" && "$(word 2,$(subst ., ,$(DOCKER_CLIENT_VERSION)))" -ge "05") || (echo "Error: Docker server 17.05 or greater is required" && exit 1)
216214

217215
.PHONY: build-advancedserver
218216
build-advancedserver: downloads/$(MQ_ARCHIVE) docker-version

0 commit comments

Comments
 (0)