Skip to content

Commit 04ae9c8

Browse files
Divya-Singh1693hkantare
authored andcommitted
added resource validator and corrected documentation
1 parent 3166f94 commit 04ae9c8

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

ibm/provider/provider.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2169,8 +2169,9 @@ func Validator() validate.ValidatorDict {
21692169

21702170
// Added for Event Notifications
21712171

2172-
"ibm_en_smtp_configuration": eventnotification.ResourceIBMEnSMTPConfigurationValidator(),
2173-
"ibm_en_smtp_user": eventnotification.ResourceIBMEnSMTPUserValidator(),
2172+
"ibm_en_smtp_configuration": eventnotification.ResourceIBMEnSMTPConfigurationValidator(),
2173+
"ibm_en_smtp_user": eventnotification.ResourceIBMEnSMTPUserValidator(),
2174+
"ibm_en_destination_custom_email": eventnotification.ResourceIBMEnEmailDestinationValidator(),
21742175

21752176
// Added for VMware as a Service
21762177
"ibm_vmaas_vdc": vmware.ResourceIbmVmaasVdcValidator(),

ibm/service/eventnotification/resource_ibm_en_destination_custom_email.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010

1111
"github.com/IBM-Cloud/terraform-provider-ibm/ibm/conns"
1212
"github.com/IBM-Cloud/terraform-provider-ibm/ibm/flex"
13+
"github.com/IBM-Cloud/terraform-provider-ibm/ibm/validate"
1314
"github.com/IBM/go-sdk-core/v5/core"
1415
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
1516
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -153,6 +154,23 @@ func ResourceIBMEnCustomEmailDestination() *schema.Resource {
153154
}
154155
}
155156

157+
func ResourceIBMEnEmailDestinationValidator() *validate.ResourceValidator {
158+
validateSchema := make([]validate.ValidateSchema, 0)
159+
validateSchema = append(validateSchema,
160+
validate.ValidateSchema{
161+
Identifier: "verification_type",
162+
ValidateFunctionIdentifier: validate.ValidateAllowedStringValue,
163+
Type: validate.TypeString,
164+
Optional: true,
165+
AllowedValues: "spf,dkim",
166+
MinValueLength: 1,
167+
},
168+
)
169+
170+
resourceValidator := validate.ResourceValidator{ResourceName: "ibm_en_destination_custom_email", Schema: validateSchema}
171+
return &resourceValidator
172+
}
173+
156174
func resourceIBMEnCustomEmailDestinationCreate(context context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
157175
enClient, err := meta.(conns.ClientSession).EventNotificationsApiV1()
158176
if err != nil {

website/docs/r/en_destination_custom_email.html.markdown

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ resource "ibm_en_destination_custom_email" "custom_domain_en_destination" {
1717
instance_guid = ibm_resource_instance.en_terraform_test_resource.guid
1818
name = "Custom Email EN Destination"
1919
type = "smtp_custom"
20-
verification_type = ""
2120
collect_failed_events = true
2221
description = "Destination Custom Email for event notification"
2322
config {

0 commit comments

Comments
 (0)