2 - vni phase 2 - instance changes (#279)

* instance changes

* vni bare metal changes

* Update resource_ibm_is_instance.go

* some changes

* updated instance

* updating tests

* doc udpate

* fixed show change issue

* Update main.tf

* reverted bm changes

* added deprecation message

* merge issues

* Update resource_ibm_is_instance_network_attachment.go

* Update data_source_ibm_is_instances_test.go

* template changes

* instance profile changes

* test

* Update resource_ibm_is_instance_template.go

* doc update

* updated tests

* removed deprecation

* Update data_source_ibm_is_instance_network_interfaces.go

* network attachments test cases

* doc update and test update

* Update resource_ibm_is_instance_network_interface_floating_ip.go

* Update resource_ibm_is_instance_network_attachment_test.go

* instance template changes

* it changes removed

* doc cleanup

* max items set

* Update resource_ibm_is_instance_network_attachment.go

* test changes

* some code changes to fix auto delete change

* Update resource_ibm_is_instance.go

* Update resource_ibm_is_instance.go

* Update resource_ibm_is_instance.go

* doc fix

* Update is_instance.html.markdown

Author: uibm

examples/ibm-is-ng/main.tf

@@ -1458,3 +1458,41 @@ resource "ibm_is_virtual_network_interface_ip" "testacc_vni_reservedip" {
 	virtual_network_interface = ibm_is_virtual_network_interface.testacc_vni.id
 	reserved_ip = ibm_is_subnet_reserved_ip.testacc_reservedip.reserved_ip
 }
+
+resource "ibm_is_virtual_network_interface" "testacc_vni2"{
+	name = "${var.name}-2"
+    subnet = ibm_is_subnet.testacc_subnet.id
+	enable_infrastructure_nat = true
+	allow_ip_spoofing = true
+}
+resource "ibm_is_virtual_network_interface" "testacc_vni3"{
+	name = "${var.name}-3"
+    subnet = ibm_is_subnet.testacc_subnet.id
+	enable_infrastructure_nat = true
+	allow_ip_spoofing = true
+}
+resource "ibm_is_ssh_key" "testacc_sshkey" {
+	name       			= "${var.name}-ssh"
+	public_key 			= file("~/.ssh/id_rsa.pub")
+}
+resource "ibm_is_instance_network_attachment" "ina" {
+  instance = ibm_is_instance.ins.id
+  name = "viability-undecided-jalapeno-unbuilt"
+  virtual_network_interface {
+    id = ibm_is_virtual_network_interface.testacc_vni2.id
+  }
+}
+resource "ibm_is_instance" "ins" {
+	name   				= "${var.name}-vsi2"
+	profile 			= "bx2-2x8"
+  image = "r134-f47cc24c-e020-4db5-ad96-1e5be8b5853b"
+	primary_network_attachment {
+        name = "vni-test"
+        virtual_network_interface { 
+            id = ibm_is_virtual_network_interface.testacc_vni3.id
+        }
+	}
+	vpc     = ibm_is_vpc.testacc_vpc.id
+	zone    = "${var.region}-2"
+	keys    = [ibm_is_ssh_key.testacc_sshkey.id]
+}

ibm/provider/provider.go

@@ -435,6 +435,8 @@ func Provider() *schema.Provider {
 			"ibm_is_instance_profiles":               vpc.DataSourceIBMISInstanceProfiles(),
 			"ibm_is_instance":                        vpc.DataSourceIBMISInstance(),
 			"ibm_is_instances":                       vpc.DataSourceIBMISInstances(),
+			"ibm_is_instance_network_attachment":     vpc.DataSourceIBMIsInstanceNetworkAttachment(),
+			"ibm_is_instance_network_attachments":    vpc.DataSourceIBMIsInstanceNetworkAttachments(),
 			"ibm_is_instance_network_interface":      vpc.DataSourceIBMIsInstanceNetworkInterface(),
 			"ibm_is_instance_network_interfaces":     vpc.DataSourceIBMIsInstanceNetworkInterfaces(),
 			"ibm_is_instance_disk":                   vpc.DataSourceIbmIsInstanceDisk(),
@@ -1028,6 +1030,7 @@ func Provider() *schema.Provider {
 			"ibm_is_flow_log":                               vpc.ResourceIBMISFlowLog(),
 			"ibm_is_instance":                               vpc.ResourceIBMISInstance(),
 			"ibm_is_instance_action":                        vpc.ResourceIBMISInstanceAction(),
+			"ibm_is_instance_network_attachment":            vpc.ResourceIBMIsInstanceNetworkAttachment(),
 			"ibm_is_instance_network_interface":             vpc.ResourceIBMIsInstanceNetworkInterface(),
 			"ibm_is_instance_network_interface_floating_ip": vpc.ResourceIBMIsInstanceNetworkInterfaceFloatingIp(),
 			"ibm_is_instance_disk_management":               vpc.ResourceIBMISInstanceDiskManagement(),
@@ -1458,6 +1461,7 @@ func Validator() validate.ValidatorDict {
 				"ibm_is_instance_template":                vpc.ResourceIBMISInstanceTemplateValidator(),
 				"ibm_is_instance":                         vpc.ResourceIBMISInstanceValidator(),
 				"ibm_is_instance_action":                  vpc.ResourceIBMISInstanceActionValidator(),
+				"ibm_is_instance_network_attachment":      vpc.ResourceIBMIsInstanceNetworkAttachmentValidator(),
 				"ibm_is_instance_network_interface":       vpc.ResourceIBMIsInstanceNetworkInterfaceValidator(),
 				"ibm_is_instance_disk_management":         vpc.ResourceIBMISInstanceDiskManagementValidator(),
 				"ibm_is_instance_volume_attachment":       vpc.ResourceIBMISInstanceVolumeAttachmentValidator(),