Skip to content

Commit 2145c1f

Browse files
authored
fix(is-image): fixed the access_tags set on is_image (IBM-Cloud#6280)
* fix(is-image): fixed the access_tags set on is_image * added acceptance test
1 parent 1102c82 commit 2145c1f

File tree

2 files changed

+41
-1
lines changed

2 files changed

+41
-1
lines changed

ibm/service/vpc/resource_ibm_is_image.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -860,7 +860,7 @@ func imgGet(context context.Context, d *schema.ResourceData, meta interface{}, i
860860
log.Printf(
861861
"Error on get of resource vpc Image (%s) access tags: %s", d.Id(), err)
862862
}
863-
if err = d.Set("encryption", accesstags); err != nil {
863+
if err = d.Set("access_tags", accesstags); err != nil {
864864
err = fmt.Errorf("Error setting access_tags: %s", err)
865865
return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_is_image", "read", "set-access_tags").GetDiag()
866866
}

ibm/service/vpc/resource_ibm_is_image_test.go

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,46 @@ func TestAccIBMISImage_basic(t *testing.T) {
4040
},
4141
})
4242
}
43+
44+
func TestAccIBMISImage_accessTags(t *testing.T) {
45+
var image string
46+
name := fmt.Sprintf("tfimg-access-tags-%d", acctest.RandIntRange(10, 100))
47+
48+
resource.Test(t, resource.TestCase{
49+
PreCheck: func() { acc.TestAccPreCheckImage(t) },
50+
Providers: acc.TestAccProviders,
51+
CheckDestroy: checkImageDestroy,
52+
Steps: []resource.TestStep{
53+
{
54+
Config: testAccCheckIBMISImageAccessTagsConfig(name),
55+
Check: resource.ComposeTestCheckFunc(
56+
testAccCheckIBMISImageExists("ibm_is_image.isExampleImage", image),
57+
resource.TestCheckResourceAttr("ibm_is_image.isExampleImage", "name", name),
58+
resource.TestCheckResourceAttr("ibm_is_image.isExampleImage", "operating_system", acc.Image_operating_system),
59+
resource.TestCheckResourceAttrSet("ibm_is_image.isExampleImage", "user_data_format"),
60+
resource.TestCheckResourceAttrSet("ibm_is_image.isExampleImage", "status"),
61+
resource.TestCheckResourceAttrSet("ibm_is_image.isExampleImage", "visibility"),
62+
63+
// Access tags validation
64+
resource.TestCheckResourceAttr("ibm_is_image.isExampleImage", "access_tags.#", "1"),
65+
resource.TestCheckResourceAttr("ibm_is_image.isExampleImage", "access_tags.0", "test:access"),
66+
),
67+
},
68+
},
69+
})
70+
}
71+
72+
func testAccCheckIBMISImageAccessTagsConfig(name string) string {
73+
return fmt.Sprintf(`
74+
resource "ibm_is_image" "isExampleImage" {
75+
href = "%s"
76+
name = "%s"
77+
operating_system = "%s"
78+
access_tags = ["test:access"]
79+
}
80+
`, acc.Image_cos_url, name, acc.Image_operating_system)
81+
}
82+
4383
func TestAccIBMISImage_lifecycle(t *testing.T) {
4484
var image string
4585
name := fmt.Sprintf("tfimg-name-%d", acctest.RandIntRange(10, 100))

0 commit comments

Comments
 (0)