Enabled the user to set 'enabled' value for feature flag (IBM-Cloud#5940)

* covered plain Fmt.ErrorF with flex.FmtErrorF wrapper

* coverted error logs to flex errors

* reverted flex error to plain error for get client function

* resolved struct name changes from go-admin-sdk 0.3.0 to 0.4.4 upgrade

* made code compliant with go fmt requirements

* solving errors in struct type matching and string array conversion

* test file changes

* added switch cases for hrefUrl

* enabled toggle of feature to be set by user

* Added code to read enabled value and set in go-admin-sdk call

* add documentation for app config feature "enabled" attribute

* enabled update function to check for change in "enabled" value

Author: prajwal-jarali

ibm/service/appconfiguration/resource_ibm_app_config_feature.go

@@ -140,7 +140,7 @@ func ResourceIBMIbmAppConfigFeature() *schema.Resource {
 			},
 			"enabled": {
 				Type:        schema.TypeBool,
-				Computed:    true,
+				Optional:    true,
 				Description: "The state of the feature flag.",
 			},
 			"created_time": {
@@ -187,6 +187,9 @@ func resourceIbmIbmAppConfigFeatureCreate(d *schema.ResourceData, meta interface
 	if _, ok := d.GetOk("tags"); ok {
 		options.SetTags(d.Get("tags").(string))
 	}
+	if _, ok := d.GetOk("enabled"); ok {
+		options.SetEnabled(d.Get("enabled").(bool))
+	}
 
 	if _, ok := d.GetOk("segment_rules"); ok {
 		var segmentRules []appconfigurationv1.FeatureSegmentRule
@@ -233,14 +236,17 @@ func resourceIbmIbmAppConfigFeatureUpdate(d *schema.ResourceData, meta interface
 	options.SetEnvironmentID(parts[1])
 	options.SetFeatureID(parts[2])
 
-	if ok := d.HasChanges("name", "enabled_value", "disabled_value", "description", "rollout_percentage", "tags", "segment_rules", "collections"); ok {
+	if ok := d.HasChanges("name", "enabled_value", "disabled_value", "description", "rollout_percentage", "tags", "segment_rules", "collections", "enabled"); ok {
 		options.SetName(d.Get("name").(string))
 		options.SetEnabledValue(d.Get("enabled_value").(string))
 		options.SetDisabledValue(d.Get("disabled_value").(string))
 
 		if _, ok := d.GetOk("description"); ok {
 			options.SetDescription(d.Get("description").(string))
 		}
+		if _, ok := d.GetOk("enabled"); ok {
+			options.SetEnabled(d.Get("enabled").(bool))
+		}
 		if _, ok := d.GetOk("rollout_percentage"); ok {
 			options.SetRolloutPercentage(int64(d.Get("rollout_percentage").(int)))
 		}

ibm/service/appconfiguration/resource_ibm_app_config_feature_test.go

@@ -44,6 +44,7 @@ func TestAccIbmIbmAppConfigFeatureBasic(t *testing.T) {
 					resource.TestCheckResourceAttrSet("ibm_app_config_feature.ibm_app_config_feature_resource1", "tags"),
 					resource.TestCheckResourceAttrSet("ibm_app_config_feature.ibm_app_config_feature_resource1", "feature_id"),
 					resource.TestCheckResourceAttrSet("ibm_app_config_feature.ibm_app_config_feature_resource1", "description"),
+					resource.TestCheckResourceAttrSet("ibm_app_config_feature.ibm_app_config_feature_resource1", "enabled"),
 					resource.TestCheckResourceAttrSet("ibm_app_config_feature.ibm_app_config_feature_resource1", "enabled_value"),
 					resource.TestCheckResourceAttrSet("ibm_app_config_feature.ibm_app_config_feature_resource1", "disabled_value"),
 					resource.TestCheckResourceAttrSet("ibm_app_config_feature.ibm_app_config_feature_resource1", "rollout_percentage"),
@@ -80,6 +81,7 @@ func testAccCheckIbmAppConfigFeatureConfigBasic(name, envName, featureID, featur
 			description    	    = "%s"
 			tags    		    = "%s"
 			rollout_percentage  = "80"
+			enabled             = false
 		}`, name, envName, featureID, featureType, description, tags)
 }
 

website/docs/r/app_config_feature.html.markdown

@@ -13,6 +13,7 @@ Create, update, or delete an environment by using IBM Cloud™ App Configuration
 ## Example usage
 
 ```terraform
+# Example 1
 resource "ibm_app_config_feature" "app_config_feature" {
   guid = "guid"
   name = "name"
@@ -24,6 +25,25 @@ resource "ibm_app_config_feature" "app_config_feature" {
   environment_id = "environment_id"
   disabled_value = "disabled_value"
   rollout_percentage = "rollout_percentage"
+  enabled = false
+}
+
+# Example 2
+resource "ibm_app_config_feature" "app_config_feature" {
+  guid = "guid"
+  name = "name"
+  type = "type"
+  tags = "tags"
+  format="format"
+  feature_id = "feature_id"
+  enabled_value = "enabled_value"
+  environment_id = "environment_id"
+  disabled_value = "disabled_value"
+  rollout_percentage = "rollout_percentage"
+  collections {
+    collection_id = "collection_id"
+  }
+  enabled = true
 }
 ```
 
@@ -39,6 +59,7 @@ Review the argument reference that you can specify for your resource.
 - `type` - (Required, String) The feature type. Supported values are **BOOLEAN**, **STRING**, or **NUMERIC**.
 - `enabled_value` - (Required, String) The value of the feature when it is enabled. The value can be **BOOLEAN**, **STRING**, or **NUMERIC** value as per the `type` attribute.
 - `disabled_value` - (Required, String) The value of the feature when it is disabled. The value can be **BOOLEAN**, **STRING**, or **NUMERIC** value as per the `type` attribute.
+- `enabled` - (Optional, Boolean) The value of the state of feature. (Note:- If enabled is set to *false*, collections is optional but for setting enabled to *true* collections is required to be set).
 - `description` - (Optional, String) The feature description.
 - `tags` - (Optional, String) Tags associated with the feature.
 - `rollout_percentage` - (String) Rollout percentage of the feature.