fix: correct argument capitalization, update cm account doc (IBM-Cloud#6486)

* fix: correct argument capitalization, update cm account doc

* fix: add update test

Author: benbuchanan

ibm/service/catalogmanagement/resource_ibm_cm_account.go

@@ -384,8 +384,8 @@ func resourceIBMCmAccountUpdate(context context.Context, d *schema.ResourceData,
 	updateCatalogAccountOptions.SetID(*account.ID)
 	updateCatalogAccountOptions.SetRev(*account.Rev)
 
-	if d.HasChange("hide_IBM_cloud_catalog") {
-		if v, ok := d.GetOk("hide_IBM_cloud_catalog"); ok {
+	if d.HasChange("hide_ibm_cloud_catalog") {
+		if v, ok := d.GetOk("hide_ibm_cloud_catalog"); ok {
 			updateCatalogAccountOptions.SetHideIBMCloudCatalog(v.(bool))
 		}
 	} else if account.HideIBMCloudCatalog != nil {

ibm/service/catalogmanagement/resource_ibm_cm_account_test.go

@@ -30,12 +30,15 @@ func TestAccIBMCmAccountBasic(t *testing.T) {
 				Config: testAccCheckIBMCmAccountConfigBasic(),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckIBMCmAccountExists("ibm_cm_account.cm_account", conf),
+					resource.TestCheckResourceAttr("ibm_cm_account.cm_account", "hide_ibm_cloud_catalog", "true"),
 				),
 			},
 			resource.TestStep{
-				ResourceName:      "ibm_cm_account.cm_account",
-				ImportState:       true,
-				ImportStateVerify: true,
+				Config: testAccCheckIBMCmAccountConfigBasicUpdate(),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					testAccCheckIBMCmAccountExists("ibm_cm_account.cm_account", conf),
+					resource.TestCheckResourceAttr("ibm_cm_account.cm_account", "hide_ibm_cloud_catalog", "false"),
+				),
 			},
 		},
 	})
@@ -49,6 +52,37 @@ func testAccCheckIBMCmAccountConfigBasic() string {
 		}
 
 		resource "ibm_cm_account" "cm_account" {
+			hide_ibm_cloud_catalog = true
+			terraform_engines {
+				name             = "my-tfe-instance"
+				type             = "terraform-enterprise"
+				public_endpoint  = "foo"
+				private_endpoint = "foo"
+				api_token        = "foo"
+				da_creation {
+					enabled                    = true
+					default_private_catalog_id = ibm_cm_catalog.cm_catalog.id
+					polling_info {
+						scopes {
+							name = "foo-project"
+							type = "project"
+						}
+					}
+				}
+			}
+		}
+	`)
+}
+
+func testAccCheckIBMCmAccountConfigBasicUpdate() string {
+	return fmt.Sprintf(`
+		resource "ibm_cm_catalog" "cm_catalog" {
+			label = "test_tf_account_catalog_label_1"
+			kind = "offering"
+		}
+
+		resource "ibm_cm_account" "cm_account" {
+			hide_ibm_cloud_catalog = false
 			terraform_engines {
 				name             = "my-tfe-instance"
 				type             = "terraform-enterprise"

website/docs/r/cm_account.html.markdown

@@ -69,11 +69,10 @@ resource "ibm_cm_account" "cm_account_instance" {
 ```
 
 
-## Attribute Reference
+## Argument Reference
 
 After your resource is created, you can read values from the listed arguments and the following attributes.
 
-* `id` - The unique identifier of the cm_account.
 * `account_filters` - (List, Optional) Filters for account and catalog filters.
 Nested schema for **account_filters**:
 	* `category_filters` - (List, Optional) Filter against offering properties.
@@ -94,6 +93,50 @@ Nested schema for **account_filters**:
 	* `include_all` - (Boolean, Optional) -> true - Include all of the public catalog when filtering. Further settings will specifically exclude some offerings. false - Exclude all of the public catalog when filtering. Further settings will specifically include some offerings.
 * `hide_ibm_cloud_catalog` - (Boolean, Optional) Hide the public catalog in this account.
 * `region_filter` - (String, Optional) Region filter string.
+* `terraform_engines` - (List, Optional) List of terraform engines configured for this account.
+Nested schema for **terraform_engines**:
+	* `api_token` - (String, Optional) The api key used to access the engine instance.
+	* `da_creation` - (List, Optional) The settings that determines how deployable architectures are auto-created from workspaces in the terraform engine.
+	Nested schema for **da_creation**:
+		* `default_private_catalog_id` - (String, Optional) Default private catalog to create the deployable architectures in.
+		* `enabled` - (Boolean, Optional) Determines whether deployable architectures are auto-created from workspaces in the engine.
+		* `polling_info` - (List, Optional) Determines which workspace scope to query to auto-create deployable architectures from.
+		Nested schema for **polling_info**:
+			* `scopes` - (List, Optional) List of scopes to auto-create deployable architectures from workspaces in the engine.
+			Nested schema for **scopes**:
+				* `name` - (String, Optional) Identifier for the specified type in the scope.
+				* `type` - (String, Optional) Scope to auto-create deployable architectures from. The supported scopes today are workspace, org, and project.
+	* `name` - (String, Optional) User provided name for the specified engine.
+	* `private_endpoint` - (String, Optional) The private endpoint for the engine instance.
+	* `public_endpoint` - (String, Optional) The public endpoint for the engine instance.
+	* `type` - (String, Optional) The terraform engine type. The only one supported at the moment is terraform-enterprise.
+
+
+## Attribute Reference
+
+After your resource is created, you can read values from the listed arguments and the following attributes.
+
+* `id` - The unique identifier of the cm_account.
+* `account_filters` - (List) Filters for account and catalog filters.
+Nested schema for **account_filters**:
+	* `category_filters` - (List) Filter against offering properties.
+	Nested schema for **category_filters**:
+    	* `category_name` - (String, Required) Name of the category.
+    	* `include` -  (Boolean) Whether to include the category in the catalog filter.
+    	* `filter` - (List) Filter terms related to the category.
+		Nested schema for **filter**:
+			* `filter_terms` - (List) List of values to match against. If include is true, then if the offering has one of the values then the offering is included. If include is false, then if the offering has one of the values then the offering is excluded.
+	* `id_filters` - (List) Filter on offering ID's. There is an include filter and an exclule filter. Both can be set.
+	Nested schema for **id_filters**:
+		* `exclude` - (List) Offering filter terms.
+		Nested schema for **exclude**:
+			* `filter_terms` - (List) List of values to match against. If include is true, then if the offering has one of the values then the offering is included. If include is false, then if the offering has one of the values then the offering is excluded.
+		* `include` - (List) Offering filter terms.
+		Nested schema for **include**:
+			* `filter_terms` - (List) List of values to match against. If include is true, then if the offering has one of the values then the offering is included. If include is false, then if the offering has one of the values then the offering is excluded.
+	* `include_all` - (Boolean) -> true - Include all of the public catalog when filtering. Further settings will specifically exclude some offerings. false - Exclude all of the public catalog when filtering. Further settings will specifically include some offerings.
+* `hide_ibm_cloud_catalog` - (Boolean) Hide the public catalog in this account.
+* `region_filter` - (String) Region filter string.
 * `rev` - (String) Cloudant revision.
 * `terraform_engines` - (List) List of terraform engines configured for this account.
 Nested schema for **terraform_engines**:
@@ -117,7 +160,6 @@ Nested schema for **terraform_engines**:
 	* `public_endpoint` - (String) The public endpoint for the engine instance.
 	* `type` - (String) The terraform engine type. The only one supported at the moment is terraform-enterprise.
 
-
 ## Import
 
 You can import the `ibm_cm_account` resource by using `id`. Account identification.