Skip to content

Commit 896c4d1

Browse files
chore: updated Event Notifications SDK version to mark API key as an optional parameter (IBM-Cloud#6195)
* added enablement for error toolchain, added support for cron schedulerfor event-notifications resources * EN template update bug fix, support spf and dkim verification method for custom email destination * removing debug line * added resource validator and corrected documentation * added validator invoaction on verification field * removing setting the verification_type * Pagerduty template support * removed local package reference * module updates * updated event-notifications go version * feat: Event Streams destination support * fix: Setting deprecation message for pagerduty destination and setting parameter as default and optional * updated deprecated param for api key, fixed description for fields in pagerduty resources and data sources * chore: updated Event Notifications SDK version to mark API key as an optional parameter * fix: Fix Event Streams resources documentation and topic param update
1 parent 55012c3 commit 896c4d1

8 files changed

+4
-7
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ require (
1515
github.com/IBM/configuration-aggregator-go-sdk v0.0.2
1616
github.com/IBM/container-registry-go-sdk v1.1.0
1717
github.com/IBM/continuous-delivery-go-sdk/v2 v2.0.2
18-
github.com/IBM/event-notifications-go-admin-sdk v0.14.0
18+
github.com/IBM/event-notifications-go-admin-sdk v0.15.0
1919
github.com/IBM/eventstreams-go-sdk v1.4.0
2020
github.com/IBM/go-sdk-core/v5 v5.20.1
2121
github.com/IBM/ibm-backup-recovery-sdk-go v1.0.3

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ github.com/IBM/container-registry-go-sdk v1.1.0 h1:sYyknIod8R4RJZQqAheiduP6wbSTp
116116
github.com/IBM/container-registry-go-sdk v1.1.0/go.mod h1:4TwsCnQtVfZ4Vkapy/KPvQBKFc3VOyUZYkwRU4FTPrs=
117117
github.com/IBM/continuous-delivery-go-sdk/v2 v2.0.2 h1:yCJJnSLNYkpF7v9n0tw8CpQbSy43E/NbFOopRf1PgoM=
118118
github.com/IBM/continuous-delivery-go-sdk/v2 v2.0.2/go.mod h1:2MajFr6C5H2jyj7qtjBxAPnZAjbPiK4CAJNk3fKNnPo=
119-
github.com/IBM/event-notifications-go-admin-sdk v0.14.0 h1:J6sUsEqZ5FVSLxaqrXOVGmqdPxCaHN9ujoRjXN2rdFQ=
120-
github.com/IBM/event-notifications-go-admin-sdk v0.14.0/go.mod h1:jhDfWFpQ7NhVWhgr2KSCIoWz32k0jur6Lde7LvvLODc=
119+
github.com/IBM/event-notifications-go-admin-sdk v0.15.0 h1:5rmEbZmGhJiS+WZOK+ABp83nXmlIG5nLL0b1dCswO1Y=
120+
github.com/IBM/event-notifications-go-admin-sdk v0.15.0/go.mod h1:9fG6k1gYRqiChZvmn1iRIjaKCXuDBCOlPH6xPJN+mMU=
121121
github.com/IBM/eventstreams-go-sdk v1.4.0 h1:yS/Ns29sBOe8W2tynQmz9HTKqQZ0ckse4Py5Oy/F2rM=
122122
github.com/IBM/eventstreams-go-sdk v1.4.0/go.mod h1:2tuAxaYLctfqfr5jvyqSrxxEQGMwYPm3yJGWSj85YVQ=
123123
github.com/IBM/go-sdk-core/v5 v5.0.0/go.mod h1:vyNdbFujJtdTj9HbihtvKwwS3k/GKSKpOx9ZIQ6MWDY=

ibm/service/eventnotification/data_source_ibm_en_destination_pagerduty_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ func testAccCheckIBMEnPagerDutyDestinationDataSourceConfigBasic(instanceName, na
5555
config {
5656
params {
5757
routing_key = "33220320pgdpgpewwp"
58-
api_key = "dwvdouqufqwojji"
5958
}
6059
}
6160
}

ibm/service/eventnotification/resource_ibm_en_destination_pagerduty.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ func ResourceIBMEnPagerDutyDestination() *schema.Resource {
6868
Type: schema.TypeString,
6969
Sensitive: true,
7070
Optional: true,
71-
Default: "",
7271
Description: "API Key for the PagerDuty account.",
7372
Deprecated: "The api_key parameter under config has been deprecated and will be removed in future",
7473
},

ibm/service/eventnotification/resource_ibm_en_destination_pagerduty_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ func testAccCheckIBMEnPagerDutyDestinationConfig(instanceName, name, description
7676
config {
7777
params {
7878
routing_key = "33220320pgdpgpewwp"
79-
api_key = "dwvdouqufqwojji"
8079
}
8180
}
8281
}

ibm/service/eventnotification/resource_ibm_en_topic.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func ResourceIBMEnTopic() *schema.Resource {
9090
},
9191
"ends_at": {
9292
Type: schema.TypeString,
93-
Required: true,
93+
Optional: true,
9494
Description: "event schedule end time.",
9595
},
9696
"expression": {
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)