feat(bare-metal): Remove CRN from resource creation and updation

Author: keerthi-gp

ibm/service/vpc/resource_ibm_is_bare_metal_server.go

@@ -1135,7 +1135,6 @@ func ResourceIBMIsBareMetalServer() *schema.Resource {
 									},
 									"crn": {
 										Type:        schema.TypeString,
-										Optional:    true,
 										Computed:    true,
 										Description: "The CRN for this trusted profile",
 									},
@@ -1513,23 +1512,15 @@ func resourceIBMISBareMetalServerCreate(context context.Context, d *schema.Resou
 			}
 			if targetIntf, ok := defaultTrustedProfileMap["target"]; ok {
 				targetMap := targetIntf.([]interface{})[0].(map[string]interface{})
-				var id, crn *string
+				var id *string
 				if idIntf, ok := targetMap["id"]; ok {
 					if idStr, ok := idIntf.(string); ok && idStr != "" {
 						id = &idStr
 					}
 				}
-
-				if crnIntf, ok := targetMap["crn"]; ok {
-					if crnStr, ok := crnIntf.(string); ok && crnStr != "" {
-						crn = &crnStr
-					}
-				}
-
-				if id != nil || crn != nil {
+				if id != nil {
 					defaultTrustedProfilePrototype.Target = &vpcv1.TrustedProfileIdentity{
 						ID:  id,
-						CRN: crn,
 					}
 				}
 			}
@@ -2764,13 +2755,6 @@ func bareMetalServerUpdate(context context.Context, d *schema.ResourceData, meta
 			}
 		}
 
-		if d.HasChange("default_trusted_profile.0.target.0.crn") {
-			newTargetCRN := d.Get("default_trusted_profile.0.target.0.crn").(string)
-			defaultTrustedProfile.Target = &vpcv1.TrustedProfileIdentity{
-				CRN: &newTargetCRN,
-			}
-		}
-
 		if defaultTrustedProfile.AutoLink != nil || defaultTrustedProfile.Target != nil {
 			initializationPatch.DefaultTrustedProfile = defaultTrustedProfile
 		}

ibm/service/vpc/resource_ibm_is_bare_metal_server_initialization.go

@@ -64,7 +64,6 @@ func ResourceIBMIsBareMetalServerInitialization() *schema.Resource {
 									},
 									"crn": {
 										Type:        schema.TypeString,
-										Optional:    true,
 										Computed:    true,
 										Description: "The CRN for this trusted profile",
 									},
@@ -158,23 +157,15 @@ func resourceIBMISBareMetalServerInitializationCreate(context context.Context, d
 
 		if targetIntf, ok := defaultTrustedProfileMap["target"]; ok {
 			targetMap := targetIntf.([]interface{})[0].(map[string]interface{})
-			var id, crn *string
+			var id *string
 			if idIntf, ok := targetMap["id"]; ok {
 				if idStr, ok := idIntf.(string); ok && idStr != "" {
 					id = &idStr
 				}
 			}
-
-			if crnIntf, ok := targetMap["crn"]; ok {
-				if crnStr, ok := crnIntf.(string); ok && crnStr != "" {
-					crn = &crnStr
-				}
-			}
-
-			if id != nil || crn != nil {
+			if id != nil {
 				defaultTrustedProfilePrototype.Target = &vpcv1.TrustedProfileIdentity{
-					ID:  id,
-					CRN: crn,
+					ID: id,
 				}
 			}
 		}

website/docs/r/is_bare_metal_server.markdown

@@ -238,9 +238,8 @@ Review the argument references that you can specify for your resource.
   Nested scheme for `default_trusted_profile`:
   - `auto_link` - (Boolean) If set to true, the system will create a link to the specified target trusted profile during server creation. Regardless of whether a link is created by the system or manually using the IAM Identity service, it will be automatically deleted when the server is deleted.
   - `target` - (List) The default IAM trusted profile to use for this bare metal server.
-    Nested `target` blocks have the following structure: 
-    - `id` - (String) The unique identifier for this trusted profile
-    - `crn` - (String) The CRN for this trusted profile
+     Nested scheme for `target`: 
+     - `id` - (String) The unique identifier for this trusted profile
 - `delete_type` - (Optional, String) Type of deletion on destroy. **soft** signals running operating system to quiesce and shutdown cleanly, **hard** immediately stop the server. By default its `hard`.
 - `enable_secure_boot` - (Optional, Boolean) Indicates whether secure boot is enabled. If enabled, the image must support secure boot or the server will fail to boot. Updating `enable_secure_boot` requires the server to be stopped and then it would be started.
 - `health_reasons` - (List) The reasons for the current health_state (if any).
@@ -263,26 +262,6 @@ Review the argument references that you can specify for your resource.
 
   -> **NOTE:**
     To reinitialize a bare metal server, the server status must be stopped, or have failed a previous reinitialization. For more information, see [Managing Bare Metal Servers for VPC](https://cloud.ibm.com/docs/vpc?topic=vpc-managing-bare-metal-servers&interface=api#reinitialize-bare-metal-servers-api).
-
-
-- `default_trusted_profile`- (Optional, List) The default trusted profile to be used when initializing the bare metal server.
-
-  Nested scheme for `default_trusted_profile`:
-  - `auto_link` - (Boolean) If set to true, the system will create a link to the specified target trusted profile during server creation. Regardless of whether a link is created by the system or manually using the IAM Identity service, it will be automatically deleted when the server is deleted.
-  - `target` - (List) The default IAM trusted profile to use for this bare metal server.
-    Nested `target` blocks have the following structure: 
-    - `id` - (String) The unique identifier for this trusted profile
-    - `crn` - (String) The CRN for this trusted profile
-     
-  
-- `default_trusted_profile`- (Optional, List) The default trusted profile to be used when initializing the bare metal server.
-
-  Nested scheme for `default_trusted_profile`:
-  - `auto_link` - (Boolean) If set to true, the system will create a link to the specified target trusted profile during server creation. Regardless of whether a link is created by the system or manually using the IAM Identity service, it will be automatically deleted when the server is deleted.
-  - `target` - (List) The default IAM trusted profile to use for this bare metal server.
-    Nested `target` blocks have the following structure: 
-    - `id` - (String) The unique identifier for this trusted profile
-    - `crn` - (String) The CRN for this trusted profile
 
 - `metadata_service`- (Optional, List) The metadata service configuration for the bare metal server.
 

website/docs/r/is_bare_metal_server_initialization.markdown

@@ -35,7 +35,7 @@ resource "ibm_is_bare_metal_server_initialization" "initialization" {
   default_trusted_profile {
     auto_link = true
     target {
-      id = "Profile-3a1dd8b4-db34-4281-88b2-42b194da30d6"
+      id = var.profile_id
     }
   }
 }
@@ -44,7 +44,7 @@ resource "ibm_is_bare_metal_server_initialization" "initialization" {
 resource "ibm_is_bare_metal_server" "bms" {
   ....
   lifecycle{
-    ignore_changes = [ image, keys, user_data ]
+    ignore_changes = [ image, keys, user_data, default_trusted_profile ]
   }
 }
 ```
@@ -60,9 +60,8 @@ Review the argument references that you can specify for your resource.
   Nested scheme for `default_trusted_profile`:
   - `auto_link` - (Boolean) If set to true, the system will create a link to the specified target trusted profile during server creation. Regardless of whether a link is created by the system or manually using the IAM Identity service, it will be automatically deleted when the server is deleted.
   - `target` - (List) The default IAM trusted profile to use for this bare metal server.
-    Nested `target` blocks have the following structure: 
-    - `id` - (String) The unique identifier for this trusted profile
-    - `crn` - (String) The CRN for this trusted profile
+     Nested scheme for `target`: 
+     - `id` - (String) The unique identifier for this trusted profile
 - `image` - (Required, String) Image id to use to reinitialize the bare metal server. 
 - `keys` - (Required, Array) Keys ids to use to reinitialize the bare metal server. 
 - `user_data` - (Optional, String) User data to transfer to the server bare metal server. If unspecified, no user data will be made available. (For reload/reinitialize provide the same user data as at the time of provisioning)