fix(Cloud Databases): Remove outdated notification (IBM-Cloud#6294)

* Revert "Add version validation (IBM-Cloud#5791)"

This reverts commit f542550.

* Remove notification

---------

Co-authored-by: Lorna-Kelly <[email protected]>

Author: lornakelly

ibm/service/database/resource_ibm_database.go

@@ -1762,11 +1762,6 @@ func resourceIBMDatabaseInstanceRead(context context.Context, d *schema.Resource
 		}
 	}
 
-	// This can be removed any time after August once all old multitenant instances are switched over to the new multitenant
-	if groupList.Groups[0].HostFlavor == nil && (groupList.Groups[0].CPU != nil && *groupList.Groups[0].CPU.AllocationCount == 0) {
-		return appendSwitchoverWarning()
-	}
-
 	endpoint, _ := instance.Parameters["service-endpoints"]
 	if endpoint == "public" || endpoint == "public-and-private" {
 		return publicServiceEndpointsWarning()
@@ -2859,20 +2854,6 @@ func validateMultitenantMemoryCpu(resourceDefaults *Group, group *Group, cpuEnfo
 	}
 }
 
-// This can be removed any time after August once all old multitenant instances are switched over to the new multitenant
-func appendSwitchoverWarning() diag.Diagnostics {
-	var diags diag.Diagnostics
-
-	warning := diag.Diagnostic{
-		Severity: diag.Warning,
-		Summary:  "Note: IBM Cloud Databases released new Hosting Models on May 1. All existing multi-tenant instances will have their resources adjusted to Shared Compute allocations during August 2024. To monitor your current resource needs, and learn about how the transition to Shared Compute will impact your instance, see our documentation https://cloud.ibm.com/docs/cloud-databases?topic=cloud-databases-hosting-models",
-	}
-
-	diags = append(diags, warning)
-
-	return diags
-}
-
 func upgradeInProgressWarning(task *clouddatabasesv5.Task) diag.Diagnostics {
 	var diags diag.Diagnostics
 

ibm/service/database/resource_ibm_database_test.go

@@ -200,23 +200,6 @@ func TestValidateRBACRole(t *testing.T) {
 	}
 }
 
-func TestAppendSwitchoverWarning(t *testing.T) {
-	diags := appendSwitchoverWarning()
-	warningNote := "Note: IBM Cloud Databases released new Hosting Models on May 1. All existing multi-tenant instances will have their resources adjusted to Shared Compute allocations during August 2024. To monitor your current resource needs, and learn about how the transition to Shared Compute will impact your instance, see our documentation https://cloud.ibm.com/docs/cloud-databases?topic=cloud-databases-hosting-models"
-
-	if len(diags) != 1 {
-		t.Fatalf("expected 1 diagnostic, got %d", len(diags))
-	}
-
-	if diags[0].Severity != diag.Warning {
-		t.Errorf("expected severity %v, got %v", diag.Warning, diags[0].Severity)
-	}
-
-	if diags[0].Summary != warningNote {
-		t.Errorf("expected summary %v, got %v", warningNote, diags[0].Summary)
-	}
-}
-
 func TestPublicServiceEndpointsWarning(t *testing.T) {
 	diags := publicServiceEndpointsWarning()
 	warningNote := "IBM recommends using private endpoints only to improve security by restricting access to your database to the IBM Cloud private network. For more information, please refer to our security best practices, https://cloud.ibm.com/docs/cloud-databases?topic=cloud-databases-manage-security-compliance."