fix(VSI-Profile-patch): Remove validation for VSI profile patching

Author: deepaksibm

ibm/flex/structures.go

@@ -2746,22 +2746,6 @@ func ResourceVolumeAttachmentValidate(diff *schema.ResourceDiff) error {
 	return nil
 }
 
-func InstanceProfileValidate(diff *schema.ResourceDiff) error {
-	if diff.Id() != "" && diff.HasChange("profile") {
-		o, n := diff.GetChange("profile")
-		old := o.(string)
-		new := n.(string)
-		log.Println("old profile : ", old)
-		log.Println("new profile : ", new)
-		if !strings.Contains(old, "d") && strings.Contains(new, "d") {
-			diff.ForceNew("profile")
-		} else if strings.Contains(old, "d") && !strings.Contains(new, "d") {
-			diff.ForceNew("profile")
-		}
-	}
-	return nil
-}
-
 func ResourceIPSecPolicyValidate(diff *schema.ResourceDiff) error {
 
 	newEncAlgo := diff.Get("encryption_algorithm").(string)

ibm/service/vpc/resource_ibm_is_instance.go

@@ -174,10 +174,6 @@ func ResourceIBMISInstance() *schema.Resource {
 		},
 
 		CustomizeDiff: customdiff.All(
-			customdiff.Sequence(
-				func(_ context.Context, diff *schema.ResourceDiff, v interface{}) error {
-					return flex.InstanceProfileValidate(diff)
-				}),
 			customdiff.Sequence(
 				func(_ context.Context, diff *schema.ResourceDiff, v interface{}) error {
 					return flex.ResourceTagsCustomizeDiff(diff)

website/docs/r/is_instance.html.markdown

@@ -522,9 +522,7 @@ Review the argument references that you can specify for your resource.
   When the `profile` is changed, the VSI is restarted. The new profile must:
     1. Have matching instance disk support. Any disks associated with the current profile will be deleted, and any disks associated with the requested profile will be created.        
     2. Be compatible with any placement_target(`dedicated_host`, `dedicated_host_group`, `placement_group`) constraints. For example, if the instance is placed on a dedicated host, the requested profile family must be the same as the dedicated host family.
-  
-  ~> **NOTE**
-   Changing a `profile` without disk to a `profile` with disk or vise versa will result in recreating(forcenew) the resource.
+
 - `resource_group` - (Optional, Forces new resource, String) The ID of the resource group where you want to create the instance.
 - `instance_template` - (Optional, String) ID of the instance template to create the instance from. To create an instance template, use `ibm_is_instance_template` resource.