Standardize Arg_CloudInstanceID argument across all data source and resource (IBM-Cloud#6249)

There were a couple of data sources that did not have the
validation.NoZeroValues check that is required, and force new
was added to the resources. The resources need force new on
this argument because a user could accidentally update that
field and think it does something when in reality it just
messes up the state. Data sources don't need the value
because data sources don't do updates.

Author: ismirlia

ibm/service/power/data_source_ibm_pi_datacenter.go

@@ -22,9 +22,10 @@ func DataSourceIBMPIDatacenter() *schema.Resource {
 		Schema: map[string]*schema.Schema{
 			// Arguments
 			Arg_CloudInstanceID: {
-				Description: "The GUID of the service instance associated with an account.",
-				Optional:    true,
-				Type:        schema.TypeString,
+				Description:  "The GUID of the service instance associated with an account.",
+				Optional:     true,
+				Type:         schema.TypeString,
+				ValidateFunc: validation.NoZeroValues,
 			},
 			Arg_DatacenterZone: {
 				Description:  "Datacenter zone you want to retrieve.",

ibm/service/power/data_source_ibm_pi_datacenters.go

@@ -11,6 +11,7 @@ import (
 	"github.com/hashicorp/go-uuid"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
 func DataSourceIBMPIDatacenters() *schema.Resource {
@@ -19,9 +20,10 @@ func DataSourceIBMPIDatacenters() *schema.Resource {
 		Schema: map[string]*schema.Schema{
 			// Arguments
 			Arg_CloudInstanceID: {
-				Description: "The GUID of the service instance associated with an account.",
-				Optional:    true,
-				Type:        schema.TypeString,
+				Description:  "The GUID of the service instance associated with an account.",
+				Optional:     true,
+				Type:         schema.TypeString,
+				ValidateFunc: validation.NoZeroValues,
 			},
 
 			// Attributes

ibm/service/power/data_source_ibm_pi_host.go

@@ -24,14 +24,12 @@ func DataSourceIBMPIHost() *schema.Resource {
 			// Arguments
 			Arg_CloudInstanceID: {
 				Description:  "The GUID of the service instance associated with an account.",
-				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,
 			},
 			Arg_HostID: {
 				Description:  "Host ID.",
-				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,

ibm/service/power/data_source_ibm_pi_hosts.go

@@ -25,7 +25,6 @@ func DataSourceIBMPIHosts() *schema.Resource {
 			// Arguments
 			Arg_CloudInstanceID: {
 				Description:  "The GUID of the service instance associated with an account.",
-				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,

ibm/service/power/data_source_ibm_pi_network_interface.go

@@ -25,21 +25,18 @@ func DataSourceIBMPINetworkInterface() *schema.Resource {
 			// Arguments
 			Arg_CloudInstanceID: {
 				Description:  "The GUID of the service instance associated with an account.",
-				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,
 			},
 			Arg_NetworkID: {
 				Description:  "Network ID.",
-				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,
 			},
 			Arg_NetworkInterfaceID: {
 				Description:  "Network interface ID.",
-				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,

ibm/service/power/data_source_ibm_pi_network_interfaces.go

@@ -25,14 +25,12 @@ func DataSourceIBMPINetworkInterfaces() *schema.Resource {
 			// Arguments
 			Arg_CloudInstanceID: {
 				Description:  "The GUID of the service instance associated with an account.",
-				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,
 			},
 			Arg_NetworkID: {
 				Description:  "Network ID.",
-				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,

ibm/service/power/resource_ibm_pi_instance_console_language.go

@@ -33,6 +33,7 @@ func ResourceIBMPIInstanceConsoleLanguage() *schema.Resource {
 			// Arguments
 			Arg_CloudInstanceID: {
 				Description:  "The GUID of the service instance associated with an account.",
+				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,

ibm/service/power/resource_ibm_pi_instance_snapshot.go

@@ -37,6 +37,7 @@ func ResourceIBMPIInstanceSnapshot() *schema.Resource {
 			// Arguments
 			Arg_CloudInstanceID: {
 				Description:  "The GUID of the service instance associated with an account.",
+				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,

ibm/service/power/resource_ibm_pi_key.go

@@ -34,6 +34,7 @@ func ResourceIBMPIKey() *schema.Resource {
 			// Arguments
 			Arg_CloudInstanceID: {
 				Description:  "The GUID of the service instance associated with an account.",
+				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,

ibm/service/power/resource_ibm_pi_network.go

@@ -56,6 +56,7 @@ func ResourceIBMPINetwork() *schema.Resource {
 			},
 			Arg_CloudInstanceID: {
 				Description:  "The GUID of the service instance associated with an account.",
+				ForceNew:     true,
 				Required:     true,
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,