feat(cluster-network-gaudi3):fixed review comments

Author: shreyasms07

ibm/service/vpc/resource_ibm_is_cluster_network_subnet.go

@@ -78,7 +78,7 @@ func ResourceIBMIsClusterNetworkSubnet() *schema.Resource {
 			},
 			"isolation_group": &schema.Schema{
 				Type:        schema.TypeInt,
-				Computed:    true,
+				Optional:    true,
 				Description: "The isolation group for the cluster network subnet.The value will not be greater than the cluster network profile's isolation_group_count.",
 			},
 			"href": &schema.Schema{

website/docs/d/is_cluster_network_profile.html.markdown

@@ -31,6 +31,21 @@ After your data source is created, you can read values from the following attrib
 - `id` - The unique identifier of the ClusterNetworkProfile.(same as `name`)
 - `family` - (String) The product family this cluster network profile belongs to.The enumerated values for this property may[expand](https://cloud.ibm.com/apidocs/vpc#property-value-expansion) in the future.
 - `href` - (String) The URL for this cluster network profile.
+- `address_configuration_services`- (List) The services that provide address configuration information for a cluster network with this profile.
+	Nested schema for **address_configuration_services**:
+	- `type` - (String) The type for this profile field
+	- `values` - (String) A service providing cluster network attachment address configuration:
+							dhcp: The DHCP service may be used.
+							is: The API for VPC Infrastructure Services (is) may be used.
+							is_metadata: The API for the VPC Instance Metadata Service may be used.
+- `isolation_group_count`- (List) The number of isolation groups in a cluster network using this profile.
+	Nested schema for **address_configuration_services**:
+	- `type` - (String) The type for this profile field
+	- `value` - (Integer) The value for this profile field
+- `subnet_routing_supported`- (List) Indicates whether cluster networks with this profile support routing traffic between cluster network subnets in the same isolation group.
+	Nested schema for **address_configuration_services**:
+	- `type` - (String) The type for this profile field
+	- `value` - (Boolean) The value for this profile field
 - `resource_type` - (String) The resource type.
 - `supported_instance_profiles` - (List) The instance profiles that support this cluster network profile.
 	Nested schema for **supported_instance_profiles**:

website/docs/d/is_cluster_network_profiles.html.markdown

@@ -30,6 +30,21 @@ After your data source is created, you can read values from the following attrib
 	- `href` - (String) The URL for this cluster network profile.
 	- `name` - (String) The globally unique name for this cluster network profile.
 	- `resource_type` - (String) The resource type.
+	- `address_configuration_services`- (List) The services that provide address configuration information for a cluster network with this profile.
+	Nested schema for **address_configuration_services**:
+		- `type` - (String) The type for this profile field
+		- `values` - (String) A service providing cluster network attachment address configuration:
+							dhcp: The DHCP service may be used.
+							is: The API for VPC Infrastructure Services (is) may be used.
+							is_metadata: The API for the VPC Instance Metadata Service may be used.
+	- `isolation_group_count`- (List) The number of isolation groups in a cluster network using this profile.
+	Nested schema for **address_configuration_services**:
+		- `type` - (String) The type for this profile field
+		- `value` - (Integer) The value for this profile field
+	- `subnet_routing_supported`- (List) Indicates whether cluster networks with this profile support routing traffic between cluster network subnets in the same isolation group.
+	Nested schema for **address_configuration_services**:
+		- `type` - (String) The type for this profile field
+		- `value` - (Boolean) The value for this profile field
 	- `supported_instance_profiles` - (List) The instance profiles that support this cluster network profile.
 	Nested schema for **supported_instance_profiles**:
 		- `href` - (String) The URL for this virtual server instance profile.

website/docs/d/is_cluster_network_subnet.html.markdown

@@ -36,6 +36,7 @@ After your data source is created, you can read values from the following attrib
 - `href` - (String) The URL for this cluster network subnet.
 - `ip_version` - (String) The IP version for this cluster network subnet.The enumerated values for this property may[expand](https://cloud.ibm.com/apidocs/vpc#property-value-expansion) in the future.
 - `ipv4_cidr_block` - (String) The IPv4 range of this cluster network subnet, expressed in CIDR format.
+- `isolation_group` - (Integer) The isolation group for the cluster network subnet.
 - `lifecycle_reasons` - (List) The reasons for the current `lifecycle_state` (if any).
 
   Nested schema for **lifecycle_reasons**:

website/docs/d/is_cluster_network_subnets.html.markdown

@@ -40,6 +40,7 @@ After your data source is created, you can read values from the following attrib
 	- `id` - (String) The unique identifier for this cluster network subnet.
 	- `ip_version` - (String) The IP version for this cluster network subnet.The enumerated values for this property may[expand](https://cloud.ibm.com/apidocs/vpc#property-value-expansion) in the future.
 	- `ipv4_cidr_block` - (String) The IPv4 range of this cluster network subnet, expressed in CIDR format.
+	- `isolation_group` - (Integer) The isolation group for the cluster network subnet.
 	- `lifecycle_reasons` - (List) The reasons for the current `lifecycle_state` (if any).
 		Nested schema for **lifecycle_reasons**:
 		- `code` - (String) A reason code for this lifecycle state:- `internal_error`: internal error (contact IBM support)- `resource_suspended_by_provider`: The resource has been suspended (contact IBM  support)The enumerated values for this property may[expand](https://cloud.ibm.com/apidocs/vpc#property-value-expansion) in the future.

website/docs/d/is_instance_profile.html.markdown

@@ -142,6 +142,12 @@ In addition to the argument reference list, you can access the following attribu
 - `href` - (String) The URL for this virtual server instance profile.
 - `memory` - (List) Nested `memory` blocks have the following structure:
 
+- `cluster_network_attachment_isolation_policy` - (List) 
+
+  Nested scheme for `cluster_network_attachment_isolation_policy`:
+      - `type` - (String) The type for this profile field.
+      - `value` - (String) The policy the system will use to assign the isolation groups to cluster network attachments.
+
   Nested scheme for `memory`:
   - `default` - (String) The default value for this profile field.
   - `max` - (String) The maximum value for this profile field.
@@ -206,3 +212,5 @@ In addition to the argument reference list, you can access the following attribu
   - `default` - (String) The default VCPU manufacturer for an instance with this profile.
   - `type` - (String) The type for this profile field.
   - `value` - (String) The VCPU manufacturer for an instance with this profile.
+
+

website/docs/d/is_instance_profiles.html.markdown

@@ -61,6 +61,12 @@ You can access the following attribute references after your data source is crea
       - `type` - (String) The type for this profile field.
       - `values` - (List) The permitted values for this profile field.
 
+  - `cluster_network_attachment_isolation_policy` - (List) 
+
+      Nested schema for **cluster_network_attachment_isolation_policy**:
+      - `type` - (String) The type for this profile field.
+      - `value` - (String) The policy the system will use to assign the isolation groups to cluster network attachments.
+
   - `confidential_compute_modes` - (List) 
 
       Nested schema for **confidential_compute_modes**:

website/docs/r/is_cluster_network_subnet.html.markdown

@@ -30,7 +30,7 @@ You can specify the following arguments for this resource.
 - `cluster_network_id` - (Required, Forces new resource, String) The cluster network identifier.
 - `ip_version` - (Optional, String) The IP version for this cluster network subnet.The enumerated values for this property may[expand](https://cloud.ibm.com/apidocs/vpc#property-value-expansion) in the future. Allowable values are: `ipv4`.
 - `ipv4_cidr_block` - (Optional, String) The IPv4 range of this cluster network subnet, expressed in CIDR format.
-- `isolation_group` - (Optional, Integer) The isolation group for the cluster network subnet.The specified value must not exceed the cluster network's profile's       isolation_group_count.
+- `isolation_group` - (Optional, Integer) The isolation group for the cluster network subnet.The specified value must not exceed the cluster network's profile's isolation_group_count.
 - `name` - (Optional, String) The name for this cluster network subnet. The name is unique across all cluster network subnets in the cluster network.
 - `total_ipv4_address_count` - (Optional, Integer) The total number of IPv4 addresses in this cluster network subnet.Note: This is calculated as 2<sup>(32 - prefix length)
 </sup>. For example, the prefix length `/24` gives:<br> 2<sup>(32 - 24)</sup> = 2<sup>8</sup> = 256 addresses.
@@ -42,7 +42,7 @@ After your resource is created, you can read values from the listed arguments an
 
 - `id` - The unique identifier of the ClusterNetworkSubnet.
 - `available_ipv4_address_count` - (Integer) The number of IPv4 addresses in this cluster network subnet that are not in use, and have not been reserved by the user or the provider.
-- `isolation_group` - (Optional, Integer) The isolation group for the cluster network subnet.The specified value must not exceed the cluster network's profile's 
+- `isolation_group` - (Integer) The isolation group for the cluster network subnet.
 - `created_at` - (String) The date and time that the cluster network subnet was created.
 - `href` - (String) The URL for this cluster network subnet.
 - `cluster_network_subnet_id` - (String) The unique identifier for this cluster network subnet.