Skip to content

Commit f93bee0

Browse files
HarasztiaPeterHarasztiaPeter
authored
fix(patner-center-sell): remove required flag on tag fields (IBM-Cloud#6055)
* feat(partner center sell): tags not required on plans and deployments and not needed sensitive flag removed Signed-off-by: Peter Harasztia <[email protected]> * feat(partner center sell): refactor Signed-off-by: Peter Harasztia <[email protected]> * feat(partner center sell): restore eployment tests Signed-off-by: Peter Harasztia <[email protected]> * feat(partner center sell): restore sum and mof files Signed-off-by: Peter Harasztia <[email protected]> * fix buidl fail Signed-off-by: Peter Harasztia <[email protected]> --------- Signed-off-by: Peter Harasztia <[email protected]>
1 parent 23e77da commit f93bee0

11 files changed

+61
-33
lines changed

‎examples/ibm-partner-center-sell/README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ resource "ibm_onboarding_catalog_deployment" "onboarding_catalog_deployment_inst
112112
| disabled | Determines the global visibility for the catalog entry, and its children. If it is not enabled, all plans are disabled. | `bool` | true |
113113
| kind | The kind of the global catalog object. | `string` | true |
114114
| overview_ui | The object that contains the service details from the Overview page in global catalog. | `` | false |
115-
| tags | A list of tags that carry information about your product. These tags can be used to find your product in the IBM Cloud catalog. | `list(string)` | true |
115+
| tags | A list of tags that carry information about your product. These tags can be used to find your product in the IBM Cloud catalog. | `list(string)` | false |
116116
| object_provider | The provider or owner of the product. | `` | true |
117117
| metadata | Global catalog deployment metadata. | `` | false |
118118

@@ -158,7 +158,7 @@ resource "ibm_onboarding_catalog_plan" "onboarding_catalog_plan_instance" {
158158
| disabled | Determines the global visibility for the catalog entry, and its children. If it is not enabled, all plans are disabled. | `bool` | true |
159159
| kind | The kind of the global catalog object. | `string` | true |
160160
| overview_ui | The object that contains the service details from the Overview page in global catalog. | `` | false |
161-
| tags | A list of tags that carry information about your product. These tags can be used to find your product in the IBM Cloud catalog. | `list(string)` | true |
161+
| tags | A list of tags that carry information about your product. These tags can be used to find your product in the IBM Cloud catalog. | `list(string)` | false |
162162
| pricing_tags | A list of tags that carry information about the pricing information of your product. | `list(string)` | false |
163163
| object_provider | The provider or owner of the product. | `` | true |
164164
| metadata | Global catalog plan metadata. | `` | false |

‎go.mod‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ require (
3333
github.com/IBM/logs-router-go-sdk v1.0.7
3434
github.com/IBM/mqcloud-go-sdk v0.2.0
3535
github.com/IBM/networking-go-sdk v0.51.3
36-
github.com/IBM/platform-services-go-sdk v0.77.0
36+
github.com/IBM/platform-services-go-sdk v0.78.0
3737
github.com/IBM/project-go-sdk v0.3.5
3838
github.com/IBM/push-notifications-go-sdk v0.0.0-20210310100607-5790b96c47f5
3939
github.com/IBM/sarama v1.45.0
@@ -79,6 +79,7 @@ require (
7979
require github.com/BurntSushi/toml v1.2.0 // indirect
8080

8181
require (
82+
github.com/Bowery/prompt v0.0.0-20190916142128-fa8279994f75 // indirect
8283
github.com/Logicalis/asn1 v0.0.0-20190312173541-d60463189a56 // indirect
8384
github.com/Masterminds/semver/v3 v3.2.1 // indirect
8485
github.com/PromonLogicalis/asn1 v0.0.0-20190312173541-d60463189a56 // indirect
@@ -94,6 +95,7 @@ require (
9495
github.com/containernetworking/cni v1.2.0-rc1 // indirect
9596
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
9697
github.com/dchest/bcrypt_pbkdf v0.0.0-20150205184540-83f37f9c154a // indirect
98+
github.com/dchest/safefile v0.0.0-20151022103144-855e8d98f185 // indirect
9799
github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect
98100
github.com/eapache/go-resiliency v1.7.0 // indirect
99101
github.com/eapache/go-xerial-snappy v0.0.0-20230731223053-c322873962e3 // indirect
@@ -126,6 +128,7 @@ require (
126128
github.com/google/gnostic-models v0.6.8 // indirect
127129
github.com/google/go-querystring v1.1.0 // indirect
128130
github.com/google/gofuzz v1.2.0 // indirect
131+
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect
129132
github.com/gorilla/websocket v1.5.0 // indirect
130133
github.com/hashicorp/errwrap v1.1.0 // indirect
131134
github.com/hashicorp/go-checkpoint v0.5.0 // indirect
@@ -165,6 +168,7 @@ require (
165168
github.com/josharian/intern v1.0.0 // indirect
166169
github.com/json-iterator/go v1.1.12 // indirect
167170
github.com/k8snetworkplumbingwg/network-attachment-definition-client v1.7.0 // indirect
171+
github.com/kardianos/govendor v1.0.9 // indirect
168172
github.com/klauspost/compress v1.17.11 // indirect
169173
github.com/kube-object-storage/lib-bucket-provisioner v0.0.0-20221122204822-d1a8c34382f1 // indirect
170174
github.com/leodido/go-urn v1.4.0 // indirect
@@ -175,6 +179,8 @@ require (
175179
github.com/mitchellh/copystructure v1.2.0 // indirect
176180
github.com/mitchellh/go-testing-interface v1.14.1 // indirect
177181
github.com/mitchellh/go-wordwrap v1.0.1 // indirect
182+
github.com/mitchellh/gox v1.0.1 // indirect
183+
github.com/mitchellh/iochan v1.0.0 // indirect
178184
github.com/mitchellh/mapstructure v1.5.0 // indirect
179185
github.com/mitchellh/reflectwalk v1.0.2 // indirect
180186
github.com/moby/spdystream v0.4.0 // indirect
@@ -212,11 +218,13 @@ require (
212218
golang.org/x/net v0.37.0 // indirect
213219
golang.org/x/oauth2 v0.22.0 // indirect
214220
golang.org/x/sync v0.12.0 // indirect
215-
golang.org/x/sys v0.31.0 // indirect
221+
golang.org/x/sys v0.32.0 // indirect
216222
golang.org/x/term v0.30.0 // indirect
217223
golang.org/x/text v0.23.0 // indirect
218224
golang.org/x/time v0.3.0 // indirect
219225
golang.org/x/tools v0.26.0 // indirect
226+
golang.org/x/tools/cmd/cover v0.1.0-deprecated // indirect
227+
golang.org/x/tools/go/vcs v0.1.0-deprecated // indirect
220228
google.golang.org/appengine v1.6.8 // indirect
221229
google.golang.org/genproto/googleapis/rpc v0.0.0-20240814211410-ddb44dafa142 // indirect
222230
google.golang.org/grpc v1.67.1 // indirect

‎go.sum‎

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ github.com/Azure/go-autorest/logger v0.2.0/go.mod h1:T9E3cAhj2VqvPOtCYAvby9aBXkZ
8585
github.com/Azure/go-autorest/logger v0.2.1/go.mod h1:T9E3cAhj2VqvPOtCYAvby9aBXkZmbF5NWuPV8+WeEW8=
8686
github.com/Azure/go-autorest/tracing v0.5.0/go.mod h1:r/s2XiOKccPW3HrqB+W0TQzfbtp2fGCgRFtBroKn4Dk=
8787
github.com/Azure/go-autorest/tracing v0.6.0/go.mod h1:+vhtPC754Xsa23ID7GlGsrdKBpUA79WCAKPPZVC2DeU=
88+
github.com/Bowery/prompt v0.0.0-20190916142128-fa8279994f75 h1:xGHheKK44eC6K0u5X+DZW/fRaR1LnDdqPHMZMWx5fv8=
89+
github.com/Bowery/prompt v0.0.0-20190916142128-fa8279994f75/go.mod h1:4/6eNcqZ09BZ9wLK3tZOjBA1nDj+B0728nlX5YRlSmQ=
8890
github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
8991
github.com/BurntSushi/toml v1.2.0 h1:Rt8g24XnyGTyglgET/PRUNlrUeu9F5L+7FilkXfZgs0=
9092
github.com/BurntSushi/toml v1.2.0/go.mod h1:CxXYINrC8qIiEnFrOxCa7Jy5BFHlXnUU2pbicEuybxQ=
@@ -156,8 +158,8 @@ github.com/IBM/mqcloud-go-sdk v0.2.0 h1:QOWk8ZGk0QfIL0MOGTKzNdM3Qe0Hk+ifAFtNSFQo
156158
github.com/IBM/mqcloud-go-sdk v0.2.0/go.mod h1:VZQKMtqmcdXKhmLhLiPuS/UHMs/5yo2tA/nD83cQt9E=
157159
github.com/IBM/networking-go-sdk v0.51.3 h1:GW2VLP7XVcAHin6eWnCNA9l3gsv5tnyjf5UgGwMA7hk=
158160
github.com/IBM/networking-go-sdk v0.51.3/go.mod h1:T27XI2gtPjT7tW9nkHgrpBUNbmAc9OR41Z78Y493PoA=
159-
github.com/IBM/platform-services-go-sdk v0.77.0 h1:ifvcAYe+3/sa/ztgpqxLZVXnFyb9UzcSuxDNmmmd+iw=
160-
github.com/IBM/platform-services-go-sdk v0.77.0/go.mod h1:sX7rPXMNqmAt6wQyjnF+oISRFwz6I6XNX9My/mzLqp4=
161+
github.com/IBM/platform-services-go-sdk v0.78.0 h1:OqfO8Qd4HQJcpgP/CLnjqFPgXtXLPbPxXlRzX4SQUH0=
162+
github.com/IBM/platform-services-go-sdk v0.78.0/go.mod h1:sX7rPXMNqmAt6wQyjnF+oISRFwz6I6XNX9My/mzLqp4=
161163
github.com/IBM/project-go-sdk v0.3.5 h1:L+YClFUa14foS0B/hOOY9n7sIdsT5/XQicnXOyJSpyM=
162164
github.com/IBM/project-go-sdk v0.3.5/go.mod h1:FOJM9ihQV3EEAY6YigcWiTNfVCThtdY8bLC/nhQHFvo=
163165
github.com/IBM/push-notifications-go-sdk v0.0.0-20210310100607-5790b96c47f5 h1:NPUhkoOCRuv3OFWt19PmwjXGGTKlvmbuPg9fUrBUNe4=
@@ -310,6 +312,8 @@ github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1
310312
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
311313
github.com/dchest/bcrypt_pbkdf v0.0.0-20150205184540-83f37f9c154a h1:saTgr5tMLFnmy/yg3qDTft4rE5DY2uJ/cCxCe3q0XTU=
312314
github.com/dchest/bcrypt_pbkdf v0.0.0-20150205184540-83f37f9c154a/go.mod h1:Bw9BbhOJVNR+t0jCqx2GC6zv0TGBsShs56Y3gfSCvl0=
315+
github.com/dchest/safefile v0.0.0-20151022103144-855e8d98f185 h1:3T8ZyTDp5QxTx3NU48JVb2u+75xc040fofcBaN+6jPA=
316+
github.com/dchest/safefile v0.0.0-20151022103144-855e8d98f185/go.mod h1:cFRxtTwTOJkz2x3rQUNCYKWC93yP1VKjR8NUhqFxZNU=
313317
github.com/dgryski/go-sip13 v0.0.0-20181026042036-e10d5fee7954/go.mod h1:vAd38F8PWV+bWy6jNmig1y/TA+kYO4g3RSRF0IAv0no=
314318
github.com/docker/docker v0.7.3-0.20190327010347-be7ac8be2ae0/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
315319
github.com/docker/go-units v0.3.3/go.mod h1:fgPhTUdO+D/Jk86RDLlptpiXQzgHJF7gydDDbaIK4Dk=
@@ -649,6 +653,8 @@ github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1/go.mod h1:kpwsk12EmLe
649653
github.com/google/pprof v0.0.0-20241029153458-d1b30febd7db h1:097atOisP2aRj7vFgYQBbFN4U4JNXUNYpxael3UzMyo=
650654
github.com/google/pprof v0.0.0-20241029153458-d1b30febd7db/go.mod h1:vavhavw2zAxS5dIdcRluK6cSGGPlZynqzFM8NdvU144=
651655
github.com/google/renameio v0.1.0/go.mod h1:KWCgfxg9yswjAJkECMjeO8J8rahYeXnNhOm40UhjYkI=
656+
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 h1:El6M4kTTCOh6aBiKaUGG7oYTSPP8MxqL4YI3kZKwcP4=
657+
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510/go.mod h1:pupxD2MaaD3pAXIBCelhxNneeOaAeabZDe5s4K6zSpQ=
652658
github.com/google/uuid v1.0.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
653659
github.com/google/uuid v1.1.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
654660
github.com/google/uuid v1.1.2/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
@@ -740,6 +746,7 @@ github.com/hashicorp/go-uuid v1.0.1/go.mod h1:6SBZvOh/SIDV7/2o3Jml5SYk/TvGqwFJ/b
740746
github.com/hashicorp/go-uuid v1.0.2/go.mod h1:6SBZvOh/SIDV7/2o3Jml5SYk/TvGqwFJ/bN7x4byOro=
741747
github.com/hashicorp/go-uuid v1.0.3 h1:2gKiV6YVmrJ1i2CKKa9obLvRieoRGviZFL26PcT/Co8=
742748
github.com/hashicorp/go-uuid v1.0.3/go.mod h1:6SBZvOh/SIDV7/2o3Jml5SYk/TvGqwFJ/bN7x4byOro=
749+
github.com/hashicorp/go-version v1.0.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
743750
github.com/hashicorp/go-version v1.2.1/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
744751
github.com/hashicorp/go-version v1.7.0 h1:5tqGy27NaOTB8yJKUZELlFAS/LTKJkrmONwQKeRZfjY=
745752
github.com/hashicorp/go-version v1.7.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
@@ -843,6 +850,8 @@ github.com/jtolds/gls v4.20.0+incompatible/go.mod h1:QJZ7F/aHp+rZTRtaJ1ow/lLfFfV
843850
github.com/julienschmidt/httprouter v1.2.0/go.mod h1:SYymIcj16QtmaHHD7aYtjjsJG7VTCxuUUipMqKk8s4w=
844851
github.com/k8snetworkplumbingwg/network-attachment-definition-client v1.7.0 h1:47q2PIbDYHmOaqLxgGnvpLq96v9UKDsJfNW6j/KbfpQ=
845852
github.com/k8snetworkplumbingwg/network-attachment-definition-client v1.7.0/go.mod h1:KDX0bPKeuhMakcNzLf2sWXKPNZ30wH01bsY/KJZLxFY=
853+
github.com/kardianos/govendor v1.0.9 h1:WOH3FcVI9eOgnIZYg96iwUwrL4eOVx+aQ66oyX2R8Yc=
854+
github.com/kardianos/govendor v1.0.9/go.mod h1:yvmR6q9ZZ7nSF5Wvh40v0wfP+3TwwL8zYQp+itoZSVM=
846855
github.com/karrick/godirwalk v1.8.0/go.mod h1:H5KPZjojv4lE+QYImBI8xVtrBRgYrIVsaRPx4tDPEn4=
847856
github.com/karrick/godirwalk v1.10.3/go.mod h1:RoGL9dQei4vP9ilrpETWE8CLOZ1kiN0LhBygSwrAsHA=
848857
github.com/kevinburke/ssh_config v1.2.0 h1:x584FjTGwHzMwvHx18PXxbBVzfnxogHaAReU4gf13a4=
@@ -938,6 +947,10 @@ github.com/mitchellh/go-testing-interface v1.14.1/go.mod h1:gfgS7OtZj6MA4U1UrDRp
938947
github.com/mitchellh/go-wordwrap v1.0.0/go.mod h1:ZXFpozHsX6DPmq2I0TCekCxypsnAUbP2oI0UX1GXzOo=
939948
github.com/mitchellh/go-wordwrap v1.0.1 h1:TLuKupo69TCn6TQSyGxwI1EblZZEsQ0vMlAFQflz0v0=
940949
github.com/mitchellh/go-wordwrap v1.0.1/go.mod h1:R62XHJLzvMFRBbcrT7m7WgmE1eOyTSsCt+hzestvNj0=
950+
github.com/mitchellh/gox v1.0.1 h1:x0jD3dcHk9a9xPSDN6YEL4xL6Qz0dvNYm8yZqui5chI=
951+
github.com/mitchellh/gox v1.0.1/go.mod h1:ED6BioOGXMswlXa2zxfh/xdd5QhwYliBFn9V18Ap4z4=
952+
github.com/mitchellh/iochan v1.0.0 h1:C+X3KsSTLFVBr/tK1eYN/vs4rJcvsiLU338UhYPJWeY=
953+
github.com/mitchellh/iochan v1.0.0/go.mod h1:JwYml1nuB7xOzsp52dPpHFffvOCDupsG0QubkSMEySY=
941954
github.com/mitchellh/mapstructure v0.0.0-20160808181253-ca63d7c062ee/go.mod h1:FVVH3fgwuzCH5S8UJGiWEs2h04kUh9fWfEaFds41c1Y=
942955
github.com/mitchellh/mapstructure v1.1.2/go.mod h1:FVVH3fgwuzCH5S8UJGiWEs2h04kUh9fWfEaFds41c1Y=
943956
github.com/mitchellh/mapstructure v1.3.3/go.mod h1:bFUtVrKA4DC2yAKiSyO/QUcy7e+RRV2QTWOzhPopBRo=
@@ -1641,6 +1654,8 @@ golang.org/x/sys v0.19.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
16411654
golang.org/x/sys v0.20.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
16421655
golang.org/x/sys v0.31.0 h1:ioabZlmFYtWhL+TRYpcnNlLwhyxaM9kWTDEmfnprqik=
16431656
golang.org/x/sys v0.31.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
1657+
golang.org/x/sys v0.32.0 h1:s77OFDvIQeibCmezSnk/q6iAfkdiQaJi4VzroCFrN20=
1658+
golang.org/x/sys v0.32.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
16441659
golang.org/x/term v0.0.0-20201117132131-f5c789dd3221/go.mod h1:Nr5EML6q2oocZ2LXRh80K7BxOlk5/8JxuGnuhpl+muw=
16451660
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
16461661
golang.org/x/term v0.0.0-20210615171337-6886f2dfbf5b/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
@@ -1783,6 +1798,10 @@ golang.org/x/tools v0.13.0/go.mod h1:HvlwmtVNQAhOuCjW7xxvovg8wbNq7LwfXh/k7wXUl58
17831798
golang.org/x/tools v0.16.1/go.mod h1:kYVVN6I1mBNoB1OX+noeBjbRk4IUEPa7JJ+TJMEooJ0=
17841799
golang.org/x/tools v0.26.0 h1:v/60pFQmzmT9ExmjDv2gGIfi3OqfKoEP6I5+umXlbnQ=
17851800
golang.org/x/tools v0.26.0/go.mod h1:TPVVj70c7JJ3WCazhD8OdXcZg/og+b9+tH/KxylGwH0=
1801+
golang.org/x/tools/cmd/cover v0.1.0-deprecated h1:Rwy+mWYz6loAF+LnG1jHG/JWMHRMMC2/1XX3Ejkx9lA=
1802+
golang.org/x/tools/cmd/cover v0.1.0-deprecated/go.mod h1:hMDiIvlpN1NoVgmjLjUJE9tMHyxHjFX7RuQ+rW12mSA=
1803+
golang.org/x/tools/go/vcs v0.1.0-deprecated h1:cOIJqWBl99H1dH5LWizPa+0ImeeJq3t3cJjaeOWUAL4=
1804+
golang.org/x/tools/go/vcs v0.1.0-deprecated/go.mod h1:zUrvATBAvEI9535oC0yWYsLsHIV4Z7g63sNPVMtuBy8=
17861805
golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
17871806
golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
17881807
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=

‎ibm/service/partnercentersell/resource_ibm_onboarding_catalog_deployment.go‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Licensed under the Mozilla Public License v2.0
33

44
/*
5-
* IBM OpenAPI Terraform Generator Version: 3.103.0-e8b84313-20250402-201816
5+
* IBM OpenAPI Terraform Generator Version: 3.101.0-62624c1e-20250225-192301
66
*/
77

88
package partnercentersell
@@ -122,7 +122,7 @@ func ResourceIbmOnboardingCatalogDeployment() *schema.Resource {
122122
},
123123
"tags": &schema.Schema{
124124
Type: schema.TypeList,
125-
Required: true,
125+
Optional: true,
126126
Description: "A list of tags that carry information about your product. These tags can be used to find your product in the IBM Cloud catalog.",
127127
Elem: &schema.Schema{Type: schema.TypeString},
128128
},
@@ -194,7 +194,6 @@ func ResourceIbmOnboardingCatalogDeployment() *schema.Resource {
194194
"unique_api_key": &schema.Schema{
195195
Type: schema.TypeBool,
196196
Computed: true,
197-
Sensitive: true,
198197
Description: "Indicates whether the deployment uses a unique API key or not.",
199198
},
200199
"parameters": &schema.Schema{
@@ -978,9 +977,11 @@ func resourceIbmOnboardingCatalogDeploymentRead(context context.Context, d *sche
978977
return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_onboarding_catalog_deployment", "read", "set-overview_ui").GetDiag()
979978
}
980979
}
981-
if err = d.Set("tags", globalCatalogDeployment.Tags); err != nil {
982-
err = fmt.Errorf("Error setting tags: %s", err)
983-
return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_onboarding_catalog_deployment", "read", "set-tags").GetDiag()
980+
if !core.IsNil(globalCatalogDeployment.Tags) {
981+
if err = d.Set("tags", globalCatalogDeployment.Tags); err != nil {
982+
err = fmt.Errorf("Error setting tags: %s", err)
983+
return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_onboarding_catalog_deployment", "read", "set-tags").GetDiag()
984+
}
984985
}
985986
objectProviderMap, err := ResourceIbmOnboardingCatalogDeploymentCatalogProductProviderToMap(globalCatalogDeployment.ObjectProvider)
986987
if err != nil {

‎ibm/service/partnercentersell/resource_ibm_onboarding_catalog_deployment_test.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@ func testAccCheckIbmOnboardingCatalogDeploymentConfigBasic(productID string, cat
149149
disabled = %s
150150
kind = "%s"
151151
object_id = "%s"
152-
tags = ["sample"]
153152
object_provider {
154153
name = "name"
155154
email = "[email protected]"

‎ibm/service/partnercentersell/resource_ibm_onboarding_catalog_plan.go‎

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ func ResourceIbmOnboardingCatalogPlan() *schema.Resource {
115115
},
116116
"tags": &schema.Schema{
117117
Type: schema.TypeList,
118-
Required: true,
118+
Optional: true,
119119
Description: "A list of tags that carry information about your product. These tags can be used to find your product in the IBM Cloud catalog.",
120120
Elem: &schema.Schema{Type: schema.TypeString},
121121
},
@@ -350,7 +350,6 @@ func ResourceIbmOnboardingCatalogPlan() *schema.Resource {
350350
"unique_api_key": &schema.Schema{
351351
Type: schema.TypeBool,
352352
Computed: true,
353-
Sensitive: true,
354353
Description: "Indicates whether the deployment uses a unique API key or not.",
355354
},
356355
},
@@ -525,12 +524,6 @@ func resourceIbmOnboardingCatalogPlanCreate(context context.Context, d *schema.R
525524
createCatalogPlanOptions.SetActive(d.Get("active").(bool))
526525
createCatalogPlanOptions.SetDisabled(d.Get("disabled").(bool))
527526
createCatalogPlanOptions.SetKind(d.Get("kind").(string))
528-
var tags []string
529-
for _, v := range d.Get("tags").([]interface{}) {
530-
tagsItem := v.(string)
531-
tags = append(tags, tagsItem)
532-
}
533-
createCatalogPlanOptions.SetTags(tags)
534527
objectProviderModel, err := ResourceIbmOnboardingCatalogPlanMapToCatalogProductProvider(d.Get("object_provider.0").(map[string]interface{}))
535528
if err != nil {
536529
return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_onboarding_catalog_plan", "create", "parse-object_provider").GetDiag()
@@ -546,6 +539,14 @@ func resourceIbmOnboardingCatalogPlanCreate(context context.Context, d *schema.R
546539
}
547540
createCatalogPlanOptions.SetOverviewUi(overviewUiModel)
548541
}
542+
if _, ok := d.GetOk("tags"); ok {
543+
var tags []string
544+
for _, v := range d.Get("tags").([]interface{}) {
545+
tagsItem := v.(string)
546+
tags = append(tags, tagsItem)
547+
}
548+
createCatalogPlanOptions.SetTags(tags)
549+
}
549550
if _, ok := d.GetOk("pricing_tags"); ok {
550551
var pricingTags []string
551552
for _, v := range d.Get("pricing_tags").([]interface{}) {
@@ -642,9 +643,11 @@ func resourceIbmOnboardingCatalogPlanRead(context context.Context, d *schema.Res
642643
return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_onboarding_catalog_plan", "read", "set-overview_ui").GetDiag()
643644
}
644645
}
645-
if err = d.Set("tags", globalCatalogPlan.Tags); err != nil {
646-
err = fmt.Errorf("Error setting tags: %s", err)
647-
return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_onboarding_catalog_plan", "read", "set-tags").GetDiag()
646+
if !core.IsNil(globalCatalogPlan.Tags) {
647+
if err = d.Set("tags", globalCatalogPlan.Tags); err != nil {
648+
err = fmt.Errorf("Error setting tags: %s", err)
649+
return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_onboarding_catalog_plan", "read", "set-tags").GetDiag()
650+
}
648651
}
649652
if !core.IsNil(globalCatalogPlan.PricingTags) {
650653
if err = d.Set("pricing_tags", globalCatalogPlan.PricingTags); err != nil {

‎ibm/service/partnercentersell/resource_ibm_onboarding_catalog_plan_test.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ func testAccCheckIbmOnboardingCatalogPlanConfigBasic(productID string, catalogPr
146146
disabled = %s
147147
kind = "%s"
148148
object_id = "%s"
149-
tags = ["tag"]
150149
object_provider {
151150
name = "name"
152151
email = "[email protected]"

‎ibm/service/partnercentersell/resource_ibm_onboarding_catalog_product.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,6 @@ func ResourceIbmOnboardingCatalogProduct() *schema.Resource {
367367
"unique_api_key": &schema.Schema{
368368
Type: schema.TypeBool,
369369
Optional: true,
370-
Sensitive: true,
371370
Description: "Indicates whether the deployment uses a unique API key or not.",
372371
},
373372
"async_provisioning_supported": &schema.Schema{

0 commit comments

Comments
 (0)