feat(Legacy_Vendor_Images): terraform fixed review comments

Author: shreyasms07

ibm/service/vpc/data_source_ibm_is_image.go

@@ -437,24 +437,14 @@ func imageGetById(d *schema.ResourceData, meta interface{}, identifier string) e
 		fmt.Printf("[WARN] Given image %s is deprecated and soon will be obsolete.", name)
 	}
 
-	if image.Remote != nil && image.Remote.Account != nil {
-		accountMap := map[string]interface{}{}
-
-		if image.Remote.Account.ID != nil {
-			accountMap["id"] = *image.Remote.Account.ID
-		}
-		if image.Remote.Account.ResourceType != nil {
-			accountMap["resource_type"] = *image.Remote.Account.ResourceType
-		}
-
-		remoteMap := map[string]interface{}{
-			"account": []interface{}{accountMap},
-		}
-		remoteList := []interface{}{remoteMap}
-
-		if err := d.Set(isImageRemote, remoteList); err != nil {
-			return fmt.Errorf("error setting image remote: %s", err)
+	if image.Remote != nil {
+		imageRemoteList := []map[string]interface{}{}
+		imageRemoteMap, err := dataSourceImageRemote(*image)
+		if err != nil {
+			return err
 		}
+		imageRemoteList = append(imageRemoteList, imageRemoteMap)
+		d.Set(isImageRemote, imageRemoteList)
 	}
 
 	if len(image.StatusReasons) > 0 {

website/docs/d/is_image.html.markdown

@@ -104,12 +104,15 @@ In addition to all argument reference list, you can access the following attribu
 
 - `source_volume` - The source volume id of the image.
 - `user_data_format` - (String) The user data format for this image.
-- `remote` - (Optional, List) If present, this property indicates that the resource associated with this referenceis remote and therefore may not be directly retrievable.
-	            Nested schema for **remote**:			
-      - `account` - (Optional, List) If present, this property indicates that the referenced resource is remote to thisaccount, and identifies the owning account.
-				Nested schema for **account**:			
-           - `id` - (Computed, String) The unique identifier for this account.
-           - `resource_type` - (Computed, String) The resource type.
+- `remote` - (Optional, List) If present, this property indicates that the resource associated with this reference is remote and therefore may not be directly retrievable.
+
+      **Nested schema for `remote`:**
+       - `account` - (Optional, List)  Indicates that the referenced resource is remote to this account, and identifies the owning account.
+
+          **Nested schema for `account`:**
+           - `id` – (Computed, String) The unique identifier for this account.  
+           - `resource_type` – (Computed, String) The resource type.
+    
 
   ~> **Note:** </br> Supported values are : </br>
   **&#x2022;** `cloud_init`: user_data will be interpreted according to the cloud-init standard.</br>

website/docs/d/is_images.html.markdown

@@ -111,11 +111,15 @@ You can access the following attribute references after your data source is crea
       - `more_info` - (String) Link to documentation about this status reason
   - `visibility` - (String) The visibility of the image public or private.
   - `source_volume` - The source volume id of the image.
-  - `remote` - (Optional, List) If present, this property indicates that the resource associated with this referenceis remote and therefore may not be directly retrievable.
-	            Nested schema for **remote**:
-      - `account` - (Optional, List) If present, this property indicates that the referenced resource is remote to thisaccount, and identifies the owning account.
-				Nested schema for **account**:
-           - `id` - (Computed, String) The unique identifier for this account.
-           - `resource_type` - (Computed, String) The resource type.
+  - `remote` - (Optional, List) If present, this property indicates that the resource associated with this reference is remote and therefore may not be directly retrievable.
+
+      **Nested schema for `remote`:**
+       - `account` - (Optional, List)  Indicates that the referenced resource is remote to this account, and identifies the owning account.
+
+          **Nested schema for `account`:**
+           - `id` – (Computed, String) The unique identifier for this account.  
+           - `resource_type` – (Computed, String) The resource type.
+
+