Skip to content

Commit 2d3ddb9

Browse files
committed
Update tests to expect the extra request to check we can connect
1 parent d658f52 commit 2d3ddb9

File tree

2 files changed

+23
-8
lines changed

2 files changed

+23
-8
lines changed

src/PHPCouchDB/Server.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ public function __construct(array $options)
5252
} catch (\GuzzleHttp\Exception\ConnectException $e) {
5353
throw new \PHPCouchDB\Exception\ServerException(
5454
"Could not connect to database. Error: " . $e->getMessage(),
55-
0, $e
55+
0,
56+
$e
5657
);
5758
}
58-
5959
}
6060

6161
/**

tests/PHPCouchDB/ServerTest.php

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function testGetVersion() {
3636
$response1 = new Response(200, [], $couchdb1);
3737

3838
// Create a mock and queue two responses.
39-
$mock = new MockHandler([ $response1 ]);
39+
$mock = new MockHandler([ $response1, $response1 ]);
4040

4141
$handler = HandlerStack::create($mock);
4242
$client = new Client(['handler' => $handler]);
@@ -48,10 +48,13 @@ public function testGetVersion() {
4848
}
4949

5050
public function testGetAllDbs() {
51+
$couchdb1 = '{"couchdb":"Welcome","uuid":"fce3d5aabfe189c988273c0ffa8d375b","version":"1.6.0","vendor":{"name":"Ubuntu","version":"15.10"}}';
52+
$db_response = new Response(200, [], $couchdb1);
53+
5154
$dbs = ["test", "items"];
5255
$response1 = new Response(200, [], json_encode($dbs));
5356

54-
$mock = new MockHandler([ $response1 ]);
57+
$mock = new MockHandler([ $db_response, $response1 ]);
5558
$handler = HandlerStack::create($mock);
5659
$client = new Client(['handler' => $handler]);
5760

@@ -62,10 +65,13 @@ public function testGetAllDbs() {
6265
}
6366

6467
public function testUseADbThatDoesExist() {
68+
$couchdb1 = '{"couchdb":"Welcome","uuid":"fce3d5aabfe189c988273c0ffa8d375b","version":"1.6.0","vendor":{"name":"Ubuntu","version":"15.10"}}';
69+
$db_response = new Response(200, [], $couchdb1);
70+
6571
$egdb1 = '{"db_name":"egdb","update_seq":"0-g1AAAABXeJzLYWBgYMpgTmEQTM4vTc5ISXLIyU9OzMnILy7JAUklMiTV____PyuRAY-iPBYgydAApP5D1GYBAJmvHGw","sizes":{"file":8488,"external":0,"active":0},"purge_seq":0,"other":{"data_size":0},"doc_del_count":0,"doc_count":0,"disk_size":8488,"disk_format_version":6,"data_size":0,"compact_running":false,"instance_start_time":"0"}';
6672
$response1 = new Response(200, [], $egdb1);
6773

68-
$mock = new MockHandler([ $response1 ]);
74+
$mock = new MockHandler([ $db_response, $response1 ]);
6975
$handler = HandlerStack::create($mock);
7076
$client = new Client(['handler' => $handler]);
7177

@@ -75,10 +81,13 @@ public function testUseADbThatDoesExist() {
7581
}
7682

7783
public function testUseADbWithCreateThatDoesExist() {
84+
$couchdb1 = '{"couchdb":"Welcome","uuid":"fce3d5aabfe189c988273c0ffa8d375b","version":"1.6.0","vendor":{"name":"Ubuntu","version":"15.10"}}';
85+
$db_response = new Response(200, [], $couchdb1);
86+
7887
$egdb1 = '{"db_name":"egdb","update_seq":"0-g1AAAABXeJzLYWBgYMpgTmEQTM4vTc5ISXLIyU9OzMnILy7JAUklMiTV____PyuRAY-iPBYgydAApP5D1GYBAJmvHGw","sizes":{"file":8488,"external":0,"active":0},"purge_seq":0,"other":{"data_size":0},"doc_del_count":0,"doc_count":0,"disk_size":8488,"disk_format_version":6,"data_size":0,"compact_running":false,"instance_start_time":"0"}';
7988
$response1 = new Response(200, [], $egdb1);
8089

81-
$mock = new MockHandler([ $response1 ]);
90+
$mock = new MockHandler([ $db_response, $response1 ]);
8291
$handler = HandlerStack::create($mock);
8392
$client = new Client(['handler' => $handler]);
8493

@@ -91,10 +100,13 @@ public function testUseADbWithCreateThatDoesExist() {
91100
* @expectedException \PHPCouchDB\Exception\ServerException
92101
*/
93102
public function testUseADbThatDoesNotExist() {
103+
$couchdb1 = '{"couchdb":"Welcome","uuid":"fce3d5aabfe189c988273c0ffa8d375b","version":"1.6.0","vendor":{"name":"Ubuntu","version":"15.10"}}';
104+
$db_response = new Response(200, [], $couchdb1);
105+
94106
$egdb1 = '{"error":"not_found","reason":"Database does not exist."}';
95107
$response1 = new Response(404, [], $egdb1);
96108

97-
$mock = new MockHandler([ $response1 ]);
109+
$mock = new MockHandler([ $db_response, $response1 ]);
98110
$handler = HandlerStack::create($mock);
99111
$client = new Client(['handler' => $handler]);
100112

@@ -104,13 +116,16 @@ public function testUseADbThatDoesNotExist() {
104116
}
105117

106118
public function testUseADbWithCreateThatDoesNotExist() {
119+
$couchdb1 = '{"couchdb":"Welcome","uuid":"fce3d5aabfe189c988273c0ffa8d375b","version":"1.6.0","vendor":{"name":"Ubuntu","version":"15.10"}}';
120+
$db_response = new Response(200, [], $couchdb1);
121+
107122
$egdb1 = '{"error":"not_found","reason":"Database does not exist."}';
108123
$response1 = new Response(404, [], $egdb1);
109124

110125
$egdb2 = '{"ok":true}';
111126
$response2 = new Response(201, [], $egdb2);
112127

113-
$mock = new MockHandler([ $response1, $response2 ]);
128+
$mock = new MockHandler([ $db_response, $response1, $response2 ]);
114129
$handler = HandlerStack::create($mock);
115130
$client = new Client(['handler' => $handler]);
116131

0 commit comments

Comments
 (0)