Skip to content

Commit 0dae3d0

Browse files
authored
Merge pull request #496 from pshipton/vendor
Rename CLOSEDJ9 variables to be called VENDOR
2 parents 820e2c6 + e5f2a66 commit 0dae3d0

File tree

5 files changed

+28
-20
lines changed

5 files changed

+28
-20
lines changed

closed/OpenJ9.gmk

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ $(call GetVersion, openjdk, OPENJDK_SHA, $(TOPDIR), required)
6565
$(call GetVersion, openj9, OPENJ9_SHA, $(OPENJ9_TOPDIR), required)
6666
$(call GetVersion, omr, OPENJ9OMR_SHA, $(OPENJ9OMR_TOPDIR), required)
6767
$(call GetVersion, openssl, OPENSSL_SHA, $(OPENSSL_DIR))
68-
$(call GetVersion, closedj9, CLOSEDJ9_SHA, $(CLOSEDJ9_TOPDIR))
68+
$(call GetVersion, vendor, VENDOR_SHA, $(VENDOR_TOPDIR))
6969

7070
# Find OpenJ9 tag associated with current commit (suppressing stderr in case there is no such tag).
7171
OPENJ9_TAG := $(shell $(GIT) -C $(OPENJ9_TOPDIR) describe --exact-match HEAD 2>/dev/null)
@@ -198,7 +198,6 @@ $(foreach file, \
198198
$(eval $(call openj9_test_image_rules, $(file)))))
199199

200200
OPENJ9_VERSION_VARS := \
201-
CLOSEDJ9_SHA \
202201
COMPANY_NAME \
203202
CXX_VERSION_STRING \
204203
DEBUG_LEVEL \
@@ -214,11 +213,12 @@ OPENJ9_VERSION_VARS := \
214213
PRODUCT_NAME \
215214
PRODUCT_SUFFIX \
216215
USERNAME \
216+
VENDOR_SHA \
217217
VERSION_STRING \
218218
#
219219

220220
OPENJ9_VERSION_SCRIPT := \
221-
$(if $(CLOSEDJ9_SHA),,-e '/ VENDOR_SHA /d') \
221+
$(if $(VENDOR_SHA),,-e '/ VENDOR_SHA /d') \
222222
$(foreach var,$(OPENJ9_VERSION_VARS),-e 's|@$(var)@|$(value $(var))|g')
223223

224224
$(OPENJ9_VM_BUILD_DIR)/include/openj9_version_info.h : $(TOPDIR)/closed/openj9_version_info.h.in
@@ -261,8 +261,8 @@ CMAKE_ARGS := \
261261
-DOPENJ9_SHA=$(OPENJ9_SHA) \
262262
#
263263

264-
ifneq (,$(CLOSEDJ9_SHA))
265-
CMAKE_ARGS += -DJ9VM_VENDOR_DIR=$(CLOSEDJ9_TOPDIR)
264+
ifneq (,$(VENDOR_TOPDIR))
265+
CMAKE_ARGS += -DJ9VM_VENDOR_DIR=$(VENDOR_TOPDIR)
266266
endif
267267

268268
ifeq ($(call isTargetOs, windows), true)

closed/autoconf/custom-hook.m4

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,30 @@
2121
AC_DEFUN_ONCE([CUSTOM_EARLY_HOOK],
2222
[
2323
# Where are the OpenJ9 sources.
24-
CLOSEDJ9_TOPDIR="$TOPDIR/closedj9"
2524
OPENJ9OMR_TOPDIR="$TOPDIR/omr"
2625
OPENJ9_TOPDIR="$TOPDIR/openj9"
2726
27+
AC_ARG_WITH(vendor-source, [AS_HELP_STRING([--with-vendor-source], [set the vendor source directory])])
28+
if test "x$with_vendor_source" = x || test "x$with_vendor_source" = xno ; then
29+
VENDOR_TOPDIR=
30+
else
31+
VENDOR_TOPDIR="$TOPDIR/$with_vendor_source"
32+
if ! test -d "$VENDOR_TOPDIR" ; then
33+
AC_MSG_ERROR(["Cannot locate vendor sources: $VENDOR_TOPDIR! Try 'bash get_source.sh' and restart configure."])
34+
fi
35+
fi
36+
2837
if ! test -d "$OPENJ9_TOPDIR" ; then
29-
AC_MSG_ERROR(["Cannot locate the path to OpenJ9 sources: $OPENJ9_TOPDIR! Try 'bash get_source.sh' and restart configure"])
38+
AC_MSG_ERROR(["Cannot locate OpenJ9 sources: $OPENJ9_TOPDIR! Try 'bash get_source.sh' and restart configure."])
3039
fi
3140
3241
if ! test -d "$OPENJ9OMR_TOPDIR" ; then
33-
AC_MSG_ERROR(["Cannot locate the path to OMR sources: $OPENJ9OMR_TOPDIR! Try 'bash get_source.sh' and restart configure"])
42+
AC_MSG_ERROR(["Cannot locate OMR sources: $OPENJ9OMR_TOPDIR! Try 'bash get_source.sh' and restart configure."])
3443
fi
3544
36-
AC_SUBST(CLOSEDJ9_TOPDIR)
3745
AC_SUBST(OPENJ9OMR_TOPDIR)
3846
AC_SUBST(OPENJ9_TOPDIR)
47+
AC_SUBST(VENDOR_TOPDIR)
3948
4049
OPENJ9_BASIC_SETUP_FUNDAMENTAL_TOOLS
4150
OPENJ9_PLATFORM_SETUP

closed/autoconf/custom-spec.gmk.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ define IncludeCustomExtension
3232
endif
3333
endef
3434

35-
CLOSEDJ9_TOPDIR := @CLOSEDJ9_TOPDIR@
3635
OPENJ9_TOPDIR := @OPENJ9_TOPDIR@
3736
OPENJ9OMR_TOPDIR := @OPENJ9OMR_TOPDIR@
37+
VENDOR_TOPDIR := @VENDOR_TOPDIR@
3838

3939
# compiler overrides
4040
OPENJ9_CC := @OPENJ9_CC@

closed/custom/ReleaseFile.gmk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ ifeq (true,$(BUILD_OPENJCEPLUS))
2525
SOURCE_REVISION += OpenJCEPlus:$(shell $(GIT) -C $(OPENJCEPLUS_TOPDIR) rev-parse --short HEAD)
2626
endif
2727

28-
ifneq (,$(wildcard $(CLOSEDJ9_TOPDIR)))
29-
SOURCE_REVISION += IBM:$(shell $(GIT) -C $(CLOSEDJ9_TOPDIR) rev-parse --short HEAD)
28+
ifneq (,$(VENDOR_TOPDIR))
29+
SOURCE_REVISION += IBM:$(shell $(GIT) -C $(VENDOR_TOPDIR) rev-parse --short HEAD)
3030
endif

closed/openj9_version_info.h.in

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,20 @@
2424
#define OPENJ9_VERSION_INFO_H
2525

2626
#define J9COMPILER_VERSION_STRING "@CXX_VERSION_STRING@"
27+
#define J9JDK_EXT_NAME "@J9JDK_EXT_NAME@"
28+
#define J9JDK_EXT_VERSION "@J9JDK_EXT_VERSION@"
29+
#define J9JVM_VERSION_STRING "@OPENJ9_VERSION_STRING@"
2730
#define J9PRODUCT_NAME "@PRODUCT_NAME@ @PRODUCT_SUFFIX@"
2831
#define J9TARGET_CPU_BITS "@OPENJDK_TARGET_CPU_BITS@"
2932
#define J9TARGET_CPU_OSARCH "@OPENJDK_TARGET_CPU_OSARCH@"
3033
#define J9TARGET_OS "@OPENJDK_TARGET_OS@"
3134
#define J9USERNAME "@USERNAME@"
3235
#define J9VERSION_STRING "@VERSION_STRING@"
33-
#define OPENJDK_SHA "@OPENJDK_SHA@"
34-
#define OPENJDK_TAG "@OPENJDK_TAG@"
35-
#define J9JVM_VERSION_STRING "@OPENJ9_VERSION_STRING@"
36-
#define OPENJ9_TAG "@OPENJ9_TAG@"
37-
#define J9JDK_EXT_VERSION "@J9JDK_EXT_VERSION@"
38-
#define J9JDK_EXT_NAME "@J9JDK_EXT_NAME@"
39-
#define VENDOR_SHA "@CLOSEDJ9_SHA@"
4036
#define JAVA_VENDOR "@COMPANY_NAME@"
41-
4237
#define JDK_DEBUG_LEVEL "@DEBUG_LEVEL@"
38+
#define OPENJ9_TAG "@OPENJ9_TAG@"
39+
#define OPENJDK_SHA "@OPENJDK_SHA@"
40+
#define OPENJDK_TAG "@OPENJDK_TAG@"
41+
#define VENDOR_SHA "@VENDOR_SHA@"
4342

4443
#endif /* OPENJ9_VERSION_INFO_H */

0 commit comments

Comments
 (0)