Skip to content

Commit 20a6dd8

Browse files
authored
Merge pull request #159 from ChengJin01/fix_c_long_valist_aix_zlinux
[FFI/VaList] Replace C_LONG with C_LONG_LONG for the type check on Power & zLinux
2 parents f47a899 + 459dfe0 commit 20a6dd8

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/ppc64/TypeClass.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,6 @@ public enum TypeClass {
5353
POINTER,
5454
STRUCT;
5555

56-
private static String osName = System.getProperty("os.name").toLowerCase();
57-
/* long long is 64 bits on AIX/ppc64, which is the same as Windows */
58-
private static ValueLayout longLayout = osName.contains("aix") ? C_LONG_LONG : C_LONG;
59-
6056
public static VarHandle classifyVarHandle(ValueLayout layout) {
6157
VarHandle argHandle = null;
6258
Class<?> carrier = classifyCarrier(layout);
@@ -69,7 +65,7 @@ public static VarHandle classifyVarHandle(ValueLayout layout) {
6965
|| (carrier == int.class)
7066
|| (carrier == long.class)
7167
) {
72-
argHandle = SharedUtils.vhPrimitiveOrAddress(long.class, longLayout);
68+
argHandle = SharedUtils.vhPrimitiveOrAddress(long.class, C_LONG_LONG);
7369
} else if (carrier == float.class) {
7470
argHandle = SharedUtils.vhPrimitiveOrAddress(double.class, C_DOUBLE);
7571
} else if ((carrier == double.class)

src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/s390x/sysv/TypeClass.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ static VarHandle classifyVarHandle(MemoryLayout layout) {
9595
|| (carrier == int.class)
9696
|| (carrier == long.class)
9797
) {
98-
argHandle = SharedUtils.vhPrimitiveOrAddress(long.class, C_LONG);
98+
argHandle = SharedUtils.vhPrimitiveOrAddress(long.class, C_LONG_LONG);
9999
} else if ((carrier == float.class)
100100
|| (carrier == double.class)
101101
) {

0 commit comments

Comments
 (0)