mds: fix dump stray command

salieri11 · salieri11 · commit 0f62d4f6d9b7 · 2025-04-03T07:40:00.000Z
close object section only if it was opened Signed-off-by: Igor Golikov <igolikov@ibm.com> Fixes: https://tracker.ceph.com/issues/70707
diff --git a/src/mds/MDCache.h b/src/mds/MDCache.h
@@ -665,7 +665,9 @@ class MDCache {
     }
   }
   void end_dump() {
-    get_formatter()->close_section();
+    if(started) {
+      get_formatter()->close_section();
+    }
   }
   C_MDS_DumpStrayDirCtx(MDCache *c, Formatter* f, std::function<void(int)>&& ext_on_finish) : 
    MDSInternalContext(c->mds), cache(c), dump_formatter(f), on_finish(std::move(ext_on_finish)) {}

Original file line number	Diff line number	Diff line change
`@@ -665,7 +665,9 @@ class MDCache {`
`665`	`665`	`}`
`666`	`666`	`}`
`667`	`667`	`void end_dump() {`
`668`		`- get_formatter()->close_section();`
	`668`	`+ if(started) {`
	`669`	`+ get_formatter()->close_section();`
	`670`	`+ }`
`669`	`671`	`}`
`670`	`672`	`C_MDS_DumpStrayDirCtx(MDCache c, Formatter f, std::function<void(int)>&& ext_on_finish) :`
`671`	`673`	`MDSInternalContext(c->mds), cache(c), dump_formatter(f), on_finish(std::move(ext_on_finish)) {}`