Merge pull request ceph#57782 from myoungwon/wip-nvme-pi

crimson/os/seastore: add checksum offload to RBM

Reviewed-by: Yingxin Cheng <[email protected]>

Author: cyx1231st

src/common/options/crimson.yaml.in

@@ -154,3 +154,10 @@ options:
   level: dev
   desc: overwrite the existing data block based on delta if the overwrite size is equal to or less than the value, otherwise do overwrite based on remapping, set to 0 to enforce the remap-based overwrite.
   default: 0
+- name: seastore_disable_end_to_end_data_protection 
+  type: bool
+  level: dev
+  desc: When false, upon mkfs, try to discover whether the nvme device supports
+        internal checksum feature without using sever CPU then enable if available,
+        set to true to disable unconditionally.
+  default: true

src/crimson/os/seastore/cache.cc

@@ -1562,7 +1562,13 @@ void Cache::complete_commit(
       is_inline = true;
       i->set_paddr(final_block_start.add_relative(i->get_paddr()));
     }
-    assert(i->get_last_committed_crc() == i->calc_crc32c());
+#ifndef NDEBUG
+    if (i->get_paddr().is_root() || epm.get_checksum_needed(i->get_paddr())) {
+      assert(i->get_last_committed_crc() == i->calc_crc32c());
+    } else {
+      assert(i->get_last_committed_crc() == CRC_NULL);
+    }
+#endif
     i->pending_for_transaction = TRANS_ID_NULL;
     i->on_initial_write();
 

src/crimson/os/seastore/cache.h

@@ -1651,7 +1651,7 @@ class Cache {
       extent->get_length(),
       extent->get_bptr()
     ).safe_then(
-      [extent=std::move(extent)]() mutable {
+      [extent=std::move(extent), this]() mutable {
         LOG_PREFIX(Cache::read_extent);
 	if (likely(extent->state == CachedExtent::extent_state_t::CLEAN_PENDING)) {
 	  extent->state = CachedExtent::extent_state_t::CLEAN;
@@ -1662,7 +1662,11 @@ class Cache {
 	if (extent->is_valid()) {
 	  // crc will be checked against LBA leaf entry for logical extents,
 	  // or check against in-extent crc for physical extents.
-	  extent->last_committed_crc = extent->calc_crc32c();
+	  if (epm.get_checksum_needed(extent->get_paddr())) {
+	    extent->last_committed_crc = extent->calc_crc32c();
+	  } else {
+	    extent->last_committed_crc = CRC_NULL;
+	  }
 	  extent->on_clean_read();
 	}
         extent->complete_io();

src/crimson/os/seastore/device.h

@@ -137,6 +137,10 @@ class Device {
 
   virtual secondary_device_set_t& get_secondary_devices() = 0;
 
+  virtual bool is_end_to_end_data_protection() const {
+    return false;
+  }
+
   using close_ertr = crimson::errorator<
     crimson::ct_error::input_output_error>;
   virtual close_ertr::future<> close() = 0;

src/crimson/os/seastore/extent_placement_manager.h

@@ -551,6 +551,15 @@ class ExtentPlacementManager {
     return background_process.run_until_halt();
   }
 
+  bool get_checksum_needed(paddr_t addr) {
+    // checksum offloading only for blocks physically stored in the device
+    if (addr.is_fake()) {
+      return true;
+    }
+    assert(addr.is_absolute());
+    return !devices_by_id[addr.get_device_id()]->is_end_to_end_data_protection();
+  }
+
 private:
   rewrite_gen_t adjust_generation(
       data_category_t category,

src/crimson/os/seastore/journal.h

@@ -107,6 +107,8 @@ class Journal {
   virtual ~Journal() {}
 
   virtual backend_type_t get_type() = 0;
+
+  virtual bool is_checksum_needed() = 0; 
 };
 using JournalRef = std::unique_ptr<Journal>;
 

src/crimson/os/seastore/journal/circular_bounded_journal.h

@@ -186,6 +186,10 @@ class CircularBoundedJournal : public Journal, RecordScanner {
     return get_journal_end();
   }
 
+  bool is_checksum_needed() final {
+    return cjs.is_checksum_needed();
+  }
+
   // Test interfaces
 
   CircularJournalSpace& get_cjs() {

src/crimson/os/seastore/journal/circular_journal_space.cc

@@ -152,16 +152,18 @@ ceph::bufferlist CircularJournalSpace::encode_header()
 {
   bufferlist bl;
   encode(header, bl);
-  auto header_crc_filler = bl.append_hole(sizeof(checksum_t));
-  auto bliter = bl.cbegin();
-  auto header_crc = bliter.crc32c(
-    ceph::encoded_sizeof_bounded<cbj_header_t>(),
-    -1);
-  ceph_le32 header_crc_le;
-  header_crc_le = header_crc;
-  header_crc_filler.copy_in(
-    sizeof(checksum_t),
-    reinterpret_cast<const char *>(&header_crc_le));
+  if (!device->is_end_to_end_data_protection()) {
+    auto header_crc_filler = bl.append_hole(sizeof(checksum_t));
+    auto bliter = bl.cbegin();
+    auto header_crc = bliter.crc32c(
+      ceph::encoded_sizeof_bounded<cbj_header_t>(),
+      -1);
+    ceph_le32 header_crc_le;
+    header_crc_le = header_crc;
+    header_crc_filler.copy_in(
+      sizeof(checksum_t),
+      reinterpret_cast<const char *>(&header_crc_le));
+  }
   return bl;
 }
 
@@ -193,7 +195,7 @@ CircularJournalSpace::read_header()
 			device->get_block_size()));
   DEBUG("reading {}", device->get_shard_journal_start());
   return device->read(device->get_shard_journal_start(), bptr
-  ).safe_then([bptr, FNAME]() mutable
+  ).safe_then([bptr, FNAME, this]() mutable
     -> read_header_ret {
     bufferlist bl;
     bl.append(bptr);
@@ -205,18 +207,20 @@ CircularJournalSpace::read_header()
       ERROR("unable to read header block");
       return crimson::ct_error::enoent::make();
     }
-    auto bliter = bl.cbegin();
-    auto test_crc = bliter.crc32c(
-      ceph::encoded_sizeof_bounded<cbj_header_t>(),
-      -1);
-    ceph_le32 recorded_crc_le;
-    decode(recorded_crc_le, bliter);
-    uint32_t recorded_crc = recorded_crc_le;
-    if (test_crc != recorded_crc) {
-      ERROR("error, header crc mismatch.");
-      return read_header_ret(
-	read_header_ertr::ready_future_marker{},
-	std::nullopt);
+    if (!device->is_end_to_end_data_protection()) {
+      auto bliter = bl.cbegin();
+      auto test_crc = bliter.crc32c(
+	ceph::encoded_sizeof_bounded<cbj_header_t>(),
+	-1);
+      ceph_le32 recorded_crc_le;
+      decode(recorded_crc_le, bliter);
+      uint32_t recorded_crc = recorded_crc_le;
+      if (test_crc != recorded_crc) {
+	ERROR("error, header crc mismatch.");
+	return read_header_ret(
+	  read_header_ertr::ready_future_marker{},
+	  std::nullopt);
+      }
     }
     return read_header_ret(
       read_header_ertr::ready_future_marker{},

src/crimson/os/seastore/journal/circular_journal_space.h

@@ -242,6 +242,10 @@ class CircularJournalSpace : public JournalAllocator {
     return header;
   }
 
+  bool is_checksum_needed() {
+    return !device->is_end_to_end_data_protection();
+  }
+
  private:
   std::string print_name;
   cbj_header_t header;

src/crimson/os/seastore/journal/segmented_journal.h

@@ -63,6 +63,11 @@ class SegmentedJournal : public Journal {
     return seastar::now();
   }
 
+  bool is_checksum_needed() final {
+    // segmented journal always requires checksum
+    return true;
+  }
+
 private:
   submit_record_ret do_submit_record(
     record_t &&record,