Merge pull request ceph#62673 from adamemerson/wip-test-osd-signed-comparison

SrinivasaBharath · web-flow · commit 1a8f084986b8 · 2025-04-11T07:52:32.000+05:30
test/osd: Fix signed comparison warning
diff --git a/src/test/osd/TestOSDMap.cc b/src/test/osd/TestOSDMap.cc
@@ -426,7 +426,7 @@ class OSDMapTest : public testing::Test,
         cout << "<<<<<PGs distribution:" << std::endl;
       }
       int high_load_after = 0;
-      for (auto i = 0 ; i < weights.size() ; i++) {
+      for (auto i = 0 ; std::cmp_less(i, weights.size()) ; i++) {
         int pgs = pgs_by_osd[i].size();
         int prims = prim_pgs_by_osd[i].size();
         int cur_load = prims * 100 + (pgs - prims) * (100 - rr);

Original file line number	Diff line number	Diff line change
`@@ -426,7 +426,7 @@ class OSDMapTest : public testing::Test,`
`426`	`426`	`cout << "<<<<<PGs distribution:" << std::endl;`
`427`	`427`	`}`
`428`	`428`	`int high_load_after = 0;`
`429`		`- for (auto i = 0 ; i < weights.size() ; i++) {`
	`429`	`+ for (auto i = 0 ; std::cmp_less(i, weights.size()) ; i++) {`
`430`	`430`	`int pgs = pgs_by_osd[i].size();`
`431`	`431`	`int prims = prim_pgs_by_osd[i].size();`
`432`	`432`	`int cur_load = prims * 100 + (pgs - prims) * (100 - rr);`