Skip to content

Commit 1ec2f26

Browse files
authored
Merge pull request ceph#57609 from Svelar/asan_rbd_mirror
test/rbd-mirror: free remote_journaler in PrepareRemoteImageRequest tests Reviewed-by: Ilya Dryomov <[email protected]>
2 parents 5717482 + 27eb87b commit 1ec2f26

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/test/rbd_mirror/image_replayer/test_mock_PrepareRemoteImageRequest.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,8 @@ TEST_F(TestMockImageReplayerPrepareRemoteImageRequest, SuccessJournal) {
328328
ASSERT_TRUE(mock_journal_state_builder.remote_journaler != nullptr);
329329
ASSERT_EQ(cls::journal::CLIENT_STATE_DISCONNECTED,
330330
mock_journal_state_builder.remote_client_state);
331+
// owned by StateBuilder, normally freed in StateBuilder::close()
332+
delete mock_journal_state_builder.remote_journaler;
331333
}
332334

333335
TEST_F(TestMockImageReplayerPrepareRemoteImageRequest, SuccessSnapshot) {
@@ -431,6 +433,8 @@ TEST_F(TestMockImageReplayerPrepareRemoteImageRequest, SuccessNotRegistered) {
431433
ASSERT_TRUE(mock_journal_state_builder.remote_journaler != nullptr);
432434
ASSERT_EQ(cls::journal::CLIENT_STATE_CONNECTED,
433435
mock_journal_state_builder.remote_client_state);
436+
// owned by StateBuilder, normally freed in StateBuilder::close()
437+
delete mock_journal_state_builder.remote_journaler;
434438
}
435439

436440
TEST_F(TestMockImageReplayerPrepareRemoteImageRequest, GetMirrorImageIdError) {

0 commit comments

Comments
 (0)