Skip to content

Commit 2ea43ec

Browse files
zhscnMatan-B
authored andcommitted
crimson/os/seastore/FixedKVBtree: remove with_btree_ret helper function
Signed-off-by: Zhang Song <[email protected]> (cherry picked from commit 725ec09)
1 parent d313b3a commit 2ea43ec

File tree

3 files changed

+4
-25
lines changed

3 files changed

+4
-25
lines changed

src/crimson/os/seastore/backref/btree_backref_manager.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ BtreeBackrefManager::get_mapping(
9191
LOG_PREFIX(BtreeBackrefManager::get_mapping);
9292
TRACET("{}", t, offset);
9393
auto c = get_context(t);
94-
return with_btree_ret<BackrefBtree, BackrefMapping>(
94+
return with_btree<BackrefBtree>(
9595
cache,
9696
c,
9797
[c, offset](auto &btree) {
@@ -503,7 +503,7 @@ BtreeBackrefManager::remove_mapping(
503503
paddr_t addr)
504504
{
505505
auto c = get_context(t);
506-
return with_btree_ret<BackrefBtree, remove_mapping_result_t>(
506+
return with_btree<BackrefBtree>(
507507
cache,
508508
c,
509509
[c, addr](auto &btree) mutable {
@@ -574,7 +574,7 @@ BtreeBackrefManager::retrieve_backref_extents_in_range(
574574
ent.key);
575575

576576
auto c = get_context(t);
577-
return with_btree_ret<BackrefBtree, CachedExtentRef>(
577+
return with_btree<BackrefBtree>(
578578
cache,
579579
c,
580580
[c, &ent](auto &btree) {

src/crimson/os/seastore/btree/fixed_kv_btree.h

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2204,25 +2204,4 @@ auto with_btree_state(
22042204
cache, c, State{}, std::forward<F>(f));
22052205
}
22062206

2207-
template <
2208-
typename tree_type_t,
2209-
typename Ret,
2210-
typename F>
2211-
auto with_btree_ret(
2212-
Cache &cache,
2213-
op_context_t c,
2214-
F &&f) {
2215-
return with_btree_state<tree_type_t, Ret>(
2216-
cache,
2217-
c,
2218-
[f=std::forward<F>(f)](auto &btree, auto &ret) mutable {
2219-
return f(
2220-
btree
2221-
).si_then([&ret](auto &&_ret) {
2222-
ret = std::move(_ret);
2223-
});
2224-
});
22252207
}
2226-
2227-
}
2228-

src/crimson/os/seastore/lba/btree_lba_manager.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -707,7 +707,7 @@ BtreeLBAManager::get_physical_extent_if_live(
707707
t, type, laddr, addr, len);
708708
ceph_assert(is_lba_node(type));
709709
auto c = get_context(t);
710-
return with_btree_ret<LBABtree, CachedExtentRef>(
710+
return with_btree<LBABtree>(
711711
cache,
712712
c,
713713
[c, type, addr, laddr, len](auto &btree) {

0 commit comments

Comments
 (0)